[ 
https://issues.apache.org/jira/browse/TUBEMQ-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123744#comment-17123744
 ] 

Guangxu Cheng edited comment on TUBEMQ-180 at 6/2/20, 12:53 PM:
----------------------------------------------------------------

Sorry, I closed the issue by mistake. Reopen it again


was (Author: andrewcheng):
Merged. Thanks for your contribution.

> Improvement for BrokerSamplePrint
> ---------------------------------
>
>                 Key: TUBEMQ-180
>                 URL: https://issues.apache.org/jira/browse/TUBEMQ-180
>             Project: Apache TubeMQ
>          Issue Type: Improvement
>            Reporter: Guo Jiwei
>            Assignee: Guo Jiwei
>            Priority: Normal
>              Labels: pull-request-available
>
> 1. BrokerSamplePrint uses the logger transferred from the TubeBroker,  
> actually not necessary. We can create logger in this class.
> 2. Remove the buidler in the log context
> {code:java}
> logger.error(sBuilder
>                                 .append("[heartbeat failed] heartbeat to 
> master exception 2 is ")
>                                 .append(e.toString()).toString());
> logger.error(sBuilder
>                             .append("[heartbeat failed] heartbeat to master 
> exception 4 is ")
>                             .append(e.toString()).toString());
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to