[jira] [Commented] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429901#comment-15429901 ] ASF GitHub Bot commented on TWILL-182: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread Terence Yim (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim resolved TWILL-182. --- Resolution: Fixed > ApplicationBundler will overwrite dependencies with identical names > -

[jira] [Commented] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread Terence Yim (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429902#comment-15429902 ] Terence Yim commented on TWILL-182: --- Thanks for the contribution. Changes merged. > Appl

[GitHub] twill pull request #1: TWILL-182, prefix jar names with the source path in t...

2016-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Updated] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread Terence Yim (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim updated TWILL-182: -- Assignee: Martin Serrano > ApplicationBundler will overwrite dependencies with identical names >

[jira] [Commented] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429856#comment-15429856 ] ASF GitHub Bot commented on TWILL-182: -- Github user serranom commented on a diff in th

[GitHub] twill pull request #1: TWILL-182, prefix jar names with the source path in t...

2016-08-21 Thread serranom
Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/1#discussion_r75601503 --- Diff: twill-core/src/test/java/org/apache/twill/internal/utils/ApplicationBundlerTest.java --- @@ -68,6 +71,56 @@ public void testFindDependencies() throws

Re: eclipse preferences for project?

2016-08-21 Thread Terence Yim
Agree. I personally use IntelliJ. I will update the site to include the settings Xmx file. Anyone uses eclipse and willing to share? Terence Sent from my iPhone > On Aug 21, 2016, at 7:08 AM, Martin Serrano wrote: > > Hello Committers, > > Seems like it would be handy to have official pref

[jira] [Commented] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429842#comment-15429842 ] ASF GitHub Bot commented on TWILL-182: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #1: TWILL-182, prefix jar names with the source path in t...

2016-08-21 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/1#discussion_r75600610 --- Diff: twill-core/src/test/java/org/apache/twill/internal/utils/ApplicationBundlerTest.java --- @@ -68,6 +71,56 @@ public void testFindDependencies() throws I

[jira] [Commented] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429840#comment-15429840 ] ASF GitHub Bot commented on TWILL-182: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #1: TWILL-182, prefix jar names with the source path in t...

2016-08-21 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/1#discussion_r75600604 --- Diff: twill-core/src/test/java/org/apache/twill/internal/utils/ApplicationBundlerTest.java --- @@ -68,6 +71,56 @@ public void testFindDependencies() throws I

[jira] [Commented] (TWILL-182) ApplicationBundler will overwrite dependencies with identical names

2016-08-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429758#comment-15429758 ] ASF GitHub Bot commented on TWILL-182: -- Github user serranom commented on the issue:

[GitHub] twill issue #1: TWILL-182, prefix jar names with the source path in the bund...

2016-08-21 Thread serranom
Github user serranom commented on the issue: https://github.com/apache/twill/pull/1 Fixed these and some other checkstyle related parts. I was running full builds but was not seeing the checkstyle failures. I'm not sure what mistake I made. Anyway, these issues are now fixed. Tha

eclipse preferences for project?

2016-08-21 Thread Martin Serrano
Hello Committers, Seems like it would be handy to have official preference files for the common IDEs or whatever IDE you use. That would make it easier to contribute I think. Thoughts? -Martin