[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664846#comment-15664846 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-14 Thread yaojiefeng
Github user yaojiefeng commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r87877029 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java --- @@ -89,4 +90,30 @@ * @return A {@link Future} that will be completed

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664787#comment-15664787 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664791#comment-15664791 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664789#comment-15664789 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664786#comment-15664786 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664785#comment-15664785 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-14 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r87875415 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java --- @@ -56,24 +66,27 @@ public

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-14 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r87353516 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java --- @@ -89,4 +90,30 @@ * @return A {@link Future} that will be completed

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-14 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r87864069 --- Diff: twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java --- @@ -90,8 +104,14 @@ public Integer getDebugPort() { }

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-14 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r87353645 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java --- @@ -227,15 +227,34 @@ TwillPreparer addSecureStore(SecureStore

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-14 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r87863869 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java --- @@ -227,15 +227,34 @@ TwillPreparer addSecureStore(SecureStore