[jira] [Commented] (TWILL-199) Get next offset and handle offset error in KafkaConsumer.MessageCallback

2016-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685673#comment-15685673 ] ASF GitHub Bot commented on TWILL-199: -- Github user maochf commented on a diff in the pull request:

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

2016-11-21 Thread maochf
Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89042464 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (TWILL-199) Get next offset and handle offset error in KafkaConsumer.MessageCallback

2016-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685670#comment-15685670 ] ASF GitHub Bot commented on TWILL-199: -- Github user maochf commented on a diff in the pull request:

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

2016-11-21 Thread maochf
Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89042093 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (TWILL-199) Get next offset and handle offset error in KafkaConsumer.MessageCallback

2016-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685583#comment-15685583 ] ASF GitHub Bot commented on TWILL-199: -- Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

2016-11-21 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89038561 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (TWILL-199) Get next offset and handle offset error in KafkaConsumer.MessageCallback

2016-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685578#comment-15685578 ] ASF GitHub Bot commented on TWILL-199: -- Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

2016-11-21 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89038468 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (TWILL-199) Get next offset and handle offset error in KafkaConsumer.MessageCallback

2016-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685575#comment-15685575 ] ASF GitHub Bot commented on TWILL-199: -- Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

2016-11-21 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r89038384 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -35,8 +35,10 @@ * Invoked when new messages is available.

[jira] [Commented] (TWILL-199) Get next offset and handle offset error in KafkaConsumer.MessageCallback

2016-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685552#comment-15685552 ] ASF GitHub Bot commented on TWILL-199: -- GitHub user maochf opened a pull request: