[jira] [Resolved] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread Terence Yim (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim resolved TWILL-241. --- Resolution: Fixed > Allow specifying reserved off-heap memory and extra JVM options per runnable >

[jira] [Commented] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117926#comment-16117926 ] ASF GitHub Bot commented on TWILL-241: -- Github user asfgit closed the pull request at:

[GitHub] twill pull request #59: (TWILL-241) Added per runnable configuration and jvm...

2017-08-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Commented] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117509#comment-16117509 ] ASF GitHub Bot commented on TWILL-241: -- Github user chtyim commented on the issue:

[GitHub] twill issue #59: (TWILL-241) Added per runnable configuration and jvm option...

2017-08-07 Thread chtyim
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/59 @anew Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117383#comment-16117383 ] ASF GitHub Bot commented on TWILL-241: -- Github user anew commented on the issue:

[GitHub] twill issue #59: (TWILL-241) Added per runnable configuration and jvm option...

2017-08-07 Thread anew
Github user anew commented on the issue: https://github.com/apache/twill/pull/59 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117272#comment-16117272 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117276#comment-16117276 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117277#comment-16117277 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117271#comment-16117271 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117274#comment-16117274 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762189 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -291,6 +300,24 @@ public void run() { // S

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117273#comment-16117273 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117275#comment-16117275 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131761743 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131761843 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762593 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java --- @@ -85,13 +105,29 @@ public TimeoutAction launchTimeout(Iterable time

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762365 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131762894 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java --- @@ -85,13 +105,29 @@ public TimeoutAction launchTimeout(Iterable time

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-08-07 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r131761787 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java --- @@ -22,5 +22,9 @@ */ public interface EventHandlerContext {

[jira] [Commented] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116858#comment-16116858 ] ASF GitHub Bot commented on TWILL-241: -- Github user anew commented on a diff in the pu

[GitHub] twill pull request #59: (TWILL-241) Added per runnable configuration and jvm...

2017-08-07 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/59#discussion_r131708600 --- Diff: twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java --- @@ -171,9 +168,27 @@ public String getKafkaZKConnect() { /

[jira] [Commented] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116857#comment-16116857 ] ASF GitHub Bot commented on TWILL-241: -- Github user anew commented on a diff in the pu

[GitHub] twill pull request #59: (TWILL-241) Added per runnable configuration and jvm...

2017-08-07 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/59#discussion_r131708495 --- Diff: twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java --- @@ -171,9 +168,27 @@ public String getKafkaZKConnect() { /

[jira] [Commented] (TWILL-241) Allow specifying reserved off-heap memory and extra JVM options per runnable

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116850#comment-16116850 ] ASF GitHub Bot commented on TWILL-241: -- Github user anew commented on a diff in the pu

[GitHub] twill pull request #59: (TWILL-241) Added per runnable configuration and jvm...

2017-08-07 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/59#discussion_r131707378 --- Diff: twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java --- @@ -171,9 +168,27 @@ public String getKafkaZKConnect() { /