[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351984#comment-16351984 ] ASF GitHub Bot commented on TWILL-254: -- Github user cbaenziger commented on the issue:

[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on the issue: https://github.com/apache/twill/pull/65 Thank you for the super fast code review @serranom! I think all comments have been addressed and the code should be complete now. Please let me know if you see anything else necessary. It is great

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351925#comment-16351925 ] ASF GitHub Bot commented on TWILL-254: -- Github user cbaenziger commented on a diff in the pull

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862926 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351924#comment-16351924 ] ASF GitHub Bot commented on TWILL-254: -- Github user cbaenziger commented on a diff in the pull

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862857 --- Diff: twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java --- @@ -71,6 +73,11 @@ public

[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on the issue: https://github.com/apache/twill/pull/65 I added a few omissions and corrected the parent `pom.xml` from my original submission. Now the new code is actually being used and I have updated the default target to Hadoop 2.6 and removed the

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351922#comment-16351922 ] ASF GitHub Bot commented on TWILL-254: -- Github user cbaenziger commented on a diff in the pull

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862673 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351800#comment-16351800 ] ASF GitHub Bot commented on TWILL-254: -- Github user serranom commented on a diff in the pull request:

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351797#comment-16351797 ] ASF GitHub Bot commented on TWILL-254: -- Github user serranom commented on a diff in the pull request:

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351798#comment-16351798 ] ASF GitHub Bot commented on TWILL-254: -- Github user serranom commented on a diff in the pull request:

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351799#comment-16351799 ] ASF GitHub Bot commented on TWILL-254: -- Github user serranom commented on a diff in the pull request:

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845875 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845855 --- Diff: pom.xml --- @@ -171,7 +171,7 @@ 4.11 3.2 1.5 -[2.0.2-alpha,2.3.0] +2.7.2

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845936 --- Diff: twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java --- @@ -71,6 +73,11 @@ public

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845929 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for