[jira] [Resolved] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim resolved TWILL-254. --- Resolution: Fixed Thanks for the patch. > Update to use ContainerId.fromString >

[jira] [Assigned] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim reassigned TWILL-254: - Assignee: Clay B. > Update to use ContainerId.fromString > >

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353178#comment-16353178 ] ASF GitHub Bot commented on TWILL-254: -- Github user asfgit closed the pull request at:

[jira] [Updated] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim updated TWILL-254: -- Fix Version/s: 0.13.0 > Update to use ContainerId.fromString > > >

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/65 ---

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353176#comment-16353176 ] ASF GitHub Bot commented on TWILL-254: -- Github user chtyim commented on the issue:

[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString

Github user chtyim commented on the issue: https://github.com/apache/twill/pull/65 Changes LGTM. ---

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353173#comment-16353173 ] ASF GitHub Bot commented on TWILL-254: -- Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166160088 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353027#comment-16353027 ] ASF GitHub Bot commented on TWILL-254: -- Github user cbaenziger commented on a diff in the pull

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166133525 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353022#comment-16353022 ] ASF GitHub Bot commented on TWILL-254: -- Github user cbaenziger commented on the issue:

[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString

Github user cbaenziger commented on the issue: https://github.com/apache/twill/pull/65 Hi @chtyim, thank you for the review. Could you please expand on what you see concerning in the `pom.xml`? For reference, I need to provide a 2.6 target as it is the first version to provide the

[GitHub] twill issue #65: (TWILL-254) Update to use ContainerId.fromString

Github user chtyim commented on the issue: https://github.com/apache/twill/pull/65 The change looks mostly ok to me, except for the change in the pom.xml profile. ---

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166078366 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[jira] [Commented] (TWILL-254) Update to use ContainerId.fromString

[ https://issues.apache.org/jira/browse/TWILL-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352347#comment-16352347 ] ASF GitHub Bot commented on TWILL-254: -- Github user serranom commented on a diff in the pull request:

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165965620 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for