[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/65 ---

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-05 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166160088 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-05 Thread cbaenziger
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166133525 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-05 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r166078366 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-05 Thread serranom
Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165965620 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread cbaenziger
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862926 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread cbaenziger
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862857 --- Diff: twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java --- @@ -71,6 +73,11 @@ public

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread cbaenziger
Github user cbaenziger commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165862673 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread serranom
Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845875 --- Diff: pom.xml --- @@ -680,9 +680,9 @@ -hadoop-2.5 +hadoop-2.6

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread serranom
Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845855 --- Diff: pom.xml --- @@ -171,7 +171,7 @@ 4.11 3.2 1.5 -[2.0.2-alpha,2.3.0] +2.7.2

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread serranom
Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845936 --- Diff: twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java --- @@ -71,6 +73,11 @@ public

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-04 Thread serranom
Github user serranom commented on a diff in the pull request: https://github.com/apache/twill/pull/65#discussion_r165845929 --- Diff: twill-yarn/src/main/hadoop22/org/apache/twill/internal/yarn/Hadoop22YarnAMClient.java --- @@ -26,7 +26,7 @@ /** * Wrapper class for

[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

2018-02-03 Thread cbaenziger
GitHub user cbaenziger opened a pull request: https://github.com/apache/twill/pull/65 (TWILL-254) Update to use ContainerId.fromString This moves away from the deprecated `ConverterUitls.toContainerId` and updates the build to use Hadoop 2.7.2 to avoid folks grabbing master and