[GitHub] twill pull request #3: (TWILL-188) Added methods to Location for manipulatio...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/3#discussion_r76164526 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java --- @@ -255,4 +288,53 @@ public int hashCode() { public String

[GitHub] twill pull request #3: (TWILL-188) Added methods to Location for manipulatio...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/3#discussion_r76164518 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java --- @@ -255,4 +288,53 @@ public int hashCode() { public String

[GitHub] twill pull request #3: (TWILL-188) Added methods to Location for manipulatio...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/3#discussion_r76164566 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/Location.java --- @@ -53,11 +54,42 @@ * Atomically creates a new, empty file named

[GitHub] twill pull request #3: (TWILL-188) Added methods to Location for manipulatio...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/3#discussion_r76164643 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/Location.java --- @@ -73,7 +105,12 @@ * Creates an {@link OutputStream} for this

[GitHub] twill pull request #3: (TWILL-188) Added methods to Location for manipulatio...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/3#discussion_r76164602 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/Location.java --- @@ -53,11 +54,42 @@ * Atomically creates a new, empty file named

[GitHub] twill pull request #3: (TWILL-188) Added methods to Location for manipulatio...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/3#discussion_r76164629 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/Location.java --- @@ -53,11 +54,42 @@ * Atomically creates a new, empty file named

[GitHub] twill issue #3: (TWILL-188) Added methods to Location for manipulation of pe...

Github user albertshau commented on the issue: https://github.com/apache/twill/pull/3 only minor comments about javadocs, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] twill pull request #9: (TWILL-173) Have EmbeddedKafkaServer restart multiple...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/9#discussion_r77081138 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/EmbeddedKafkaServer.java --- @@ -65,9 +72,19 @@ protected void startUp() throws Exception

[GitHub] twill pull request #9: (TWILL-173) Have EmbeddedKafkaServer restart multiple...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/9#discussion_r77083133 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/EmbeddedKafkaServer.java --- @@ -65,9 +72,19 @@ protected void startUp() throws Exception

[GitHub] twill issue #9: (TWILL-173) Have EmbeddedKafkaServer restart multiple times ...

Github user albertshau commented on the issue: https://github.com/apache/twill/pull/9 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/8#discussion_r78623437 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java --- @@ -17,8 +17,15 @@ */ package org.apache.twill.yarn

[GitHub] twill issue #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable

Github user albertshau commented on the issue: https://github.com/apache/twill/pull/8 one minor comment, otherwise lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r90149679 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r90151909 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -35,8 +35,10 @@ * Invoked when new messages is

[GitHub] twill pull request #16: [TWILL-199] Handle offset error and return next offs...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/16#discussion_r90152039 --- Diff: twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java --- @@ -35,8 +35,10 @@ * Invoked when new messages is

[GitHub] twill pull request #21: (TWILL-63) Speed up application launch time

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/21#discussion_r95050605 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java --- @@ -277,9 +281,16 @@ public TwillPreparer prepare(TwillApplication

[GitHub] twill pull request #21: (TWILL-63) Speed up application launch time

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/21#discussion_r95048004 --- Diff: twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java --- @@ -97,10 +76,10 @@ public ApplicationBundler(Iterable

[GitHub] twill pull request #21: (TWILL-63) Speed up application launch time

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/21#discussion_r95050388 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/LocationCacheCleaner.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/26#discussion_r97681685 --- Diff: twill-common/src/main/java/org/apache/twill/filesystem/Location.java --- @@ -207,6 +207,21 @@ boolean mkdirs() throws IOException

[GitHub] twill pull request #47: (TWILL-223) Make FileContextLocationFactory UGI awar...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/47#discussion_r108811273 --- Diff: twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocationFactory.java --- @@ -103,16 +138,32 @@ public Location create(URI uri

[GitHub] twill pull request #48: (TWILL-189) Allows secure store update with differen...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/48#discussion_r109225715 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java --- @@ -265,6 +254,44 @@ public void cancel

[GitHub] twill pull request #48: (TWILL-189) Allows secure store update with differen...

Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/48#discussion_r109223872 --- Diff: twill-api/src/main/java/org/apache/twill/api/security/SecureStoreRenewer.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] twill issue #48: (TWILL-189) Allows secure store update with different UGI

Github user albertshau commented on the issue: https://github.com/apache/twill/pull/48 just a couple comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes