Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/53#discussion_r109552373
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java ---
@@ -322,7 +314,46 @@ private boolean hasRun(YarnApplicationState
Github user yaojiefeng commented on the issue:
https://github.com/apache/twill/pull/49
I see. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yaojiefeng commented on the issue:
https://github.com/apache/twill/pull/49
Changes LGTM, may I ask where do we set the logback if it is overriden by
user?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user yaojiefeng opened a pull request:
https://github.com/apache/twill/pull/18
Fix reset log level for runnables started up later
There is a bug when we try to reset log levels for some runnables which are
started up later, e.g, restart or instance changes, after some
Github user yaojiefeng commented on the issue:
https://github.com/apache/twill/pull/14
Thanks! @hsaputra
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yaojiefeng commented on the issue:
https://github.com/apache/twill/pull/17
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r91845224
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,45 @@
* @return A {@link Future} that will be completed
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r90767592
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
---
@@ -51,29 +63,36 @@
private final ClassLoader
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r90767420
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,45 @@
* @return A {@link Future} that will be completed
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87877029
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,30 @@
* @return A {@link Future} that will be completed
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87254498
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/ServiceMain.java ---
@@ -264,6 +262,10 @@ protected String getLoggerLevel(Logger logger
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86290796
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/LogLevelChangeTestRun.java ---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86288660
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -475,6 +496,11 @@ private void sendMessage(final
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86288445
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -575,18 +601,74 @@ private boolean removeContainerInfo
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86282861
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,44 @@
* @return A {@link Future} that will be completed
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82886998
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/utils/LogLevelUtil.java ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82102988
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -137,7 +138,7 @@ public final synchronized
Github user yaojiefeng commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82036739
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -78,6 +78,15 @@ private Files
GitHub user yaojiefeng opened a pull request:
https://github.com/apache/twill/pull/13
TWILL-195 Add TwillRuntimeSpecification
JIRA: https://issues.apache.org/jira/browse/TWILL-195
Summary: This PR is a prerequisite of TWILL-138. Add
TwillRuntimeSpecification for twill
GitHub user yaojiefeng opened a pull request:
https://github.com/apache/twill/pull/12
TWILL-138 TWILL-195 Runtime log level change
JIRA: https://issues.apache.org/jira/browse/TWILL-138
https://issues.apache.org/jira/browse/TWILL-195
The first two commits are for TWILL
20 matches
Mail list logo
