[GitHub] [uima-uimaj] reckart commented on pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

reckart commented on pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-647185541 @mischor ok, now we have proper asserts This is an automated message from the Apache Git Service. To respond to

[GitHub] [uima-uimaj] reckart commented on pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

reckart commented on pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-647174982 Mind, the test is still not quite perfect. There should actually be some asserts actually checking that the expected JCas wrappers are being used instead of just implicitly

[GitHub] [uima-uimaj] reckart commented on pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

reckart commented on pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-647174823 Thanks for the check. I have updated the test. Now, one test fails in UIMAv2 (with `Annotation` where `Token` would be expected) and the other two fail in UIMAv3 (with

[jira] [Commented] (UIMA-6243) JCas returns Annotation when asked for a specific subtype

[ https://issues.apache.org/jira/browse/UIMA-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141557#comment-17141557 ] Richard Eckart de Castilho commented on UIMA-6243: -- [~schor] wrote: Running this gave

[GitHub] [uima-uimaj] mischor commented on a change in pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

mischor commented on a change in pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443239137 ## File path: uimaj-core/src/test/java/org/apache/uima/cas/test/JCasClassLoaderTest.java ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software

[GitHub] [uima-uimaj] reckart commented on a change in pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

reckart commented on a change in pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443231694 ## File path: uimaj-core/pom.xml ## @@ -78,6 +78,11 @@ assertj-core test +

[GitHub] [uima-uimaj] reckart commented on a change in pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

reckart commented on a change in pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443231498 ## File path: uimaj-core/src/test/java/org/apache/uima/cas/test/JCasClassLoaderTest.java ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software

[GitHub] [uima-uimaj] reckart commented on a change in pull request #46: [UIMA-6243] JCas returns Annotation when asked for a specific subtype

reckart commented on a change in pull request #46: URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443231498 ## File path: uimaj-core/src/test/java/org/apache/uima/cas/test/JCasClassLoaderTest.java ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (UIMA-6247) Ruta: not able to check label expression on null as implicit condition

[ https://issues.apache.org/jira/browse/UIMA-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141501#comment-17141501 ] Marshall Schor commented on UIMA-6247: -- Running this gave errors on all 3 test cases: Caused by: