Re: git pull requests and jira issue linkage?

2019-09-09 Thread Richard Eckart de Castilho
On 9. Sep 2019, at 23:12, Marshall Schor wrote: > > I just closed / commented on some older uimaj pull requests, and guess what: > the > Jira was updated with a link to the comment :-) Magic! :) Any idea what creates the link? (i.e. which convention must be followed so it is created)? --

Re: git pull requests and jira issue linkage?

2019-09-09 Thread Marshall Schor
I just closed / commented on some older uimaj pull requests, and guess what: the Jira was updated with a link to the comment :-) -Marshall On 9/9/2019 3:36 PM, Richard Eckart de Castilho wrote: > On 9. Sep 2019, at 21:24, Marshall Schor wrote: >> If there's a discussion on a pull request, is it

Re: git pull requests and jira issue linkage?

2019-09-09 Thread Richard Eckart de Castilho
On 9. Sep 2019, at 21:24, Marshall Schor wrote: > > If there's a discussion on a pull request, is it "linked" into the related > Jira > (assuming the pull request follows the naming conventions)? I don't know of any convention to link a PR to a Jira in such a way that the Jira is

git pull requests and jira issue linkage?

2019-09-09 Thread Marshall Schor
Hi, If there's a discussion on a pull request, is it "linked" into the related Jira (assuming the pull request follows the naming conventions)? If not, is the recommended practice to put the commentary in the Jira, perhaps with a pointer to it in the github pull request "review"? -Marshall