reckart opened a new pull request #70:
URL: https://github.com/apache/uima-uimaj/pull/70
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reckart opened a new pull request #71:
URL: https://github.com/apache/uima-uimaj/pull/71
- Adapted a WeakIdentityMap from Apache Lucene to store the per-classloader
JCas class info
This is an automated message from the
reckart opened a new pull request #126:
URL: https://github.com/apache/uima-uimafit/pull/126
- Re-enable builds on Windows nodes
- Adjust tools IDs
- Fix environment variables step to also run on Windows nodes
This
SergeAverbis commented on pull request #67:
URL: https://github.com/apache/uima-uimaj/pull/67#issuecomment-711831987
This correction solve the problem in my environment.
This is an automated message from the Apache Git
reckart merged pull request #127:
URL: https://github.com/apache/uima-uimafit/pull/127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart opened a new pull request #128:
URL: https://github.com/apache/uima-uimafit/pull/128
- Switched to xmlunit 2 or more specifically its xmlunit-assertj module
- Add missing dependency version
- Exclude Eclipse config file from rat
**JIRA Ticket:**
reckart merged pull request #128:
URL: https://github.com/apache/uima-uimafit/pull/128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart opened a new pull request #127:
URL: https://github.com/apache/uima-uimafit/pull/127
- Re-enable builds on Windows nodes
- Adjust tools IDs
- Fix environment variables step to also run on Windows nodes
This is
reckart merged pull request #126:
URL: https://github.com/apache/uima-uimafit/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart merged pull request #107:
URL: https://github.com/apache/uima-uimafit/pull/107
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart opened a new pull request #61:
URL: https://github.com/apache/uima-uimaj/pull/61
- Fixed edge case
- Added unit test
This is an automated message from the Apache Git Service.
To respond to the message, please
reckart opened a new pull request #122:
URL: https://github.com/apache/uima-uimafit/pull/122
- Added selectOverlapping
- Added unit tests
- Pull out check for annotation type into a helper method
- Added AnnotationPredicates helper class
**JIRA Ticket:**
reckart commented on pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62#issuecomment-706620518
@pkluegl care to review this one?
This is an automated message from the Apache Git Service.
To respond to the
reckart opened a new pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62
- Added utility class with predicates for overlap/containment/etc of
annotations
- Added convenience access to these methods to the AnnotationFS interface
- Added unit tests
reckart edited a comment on pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62#issuecomment-706620912
@pkluegl When looking at this on, the different cases in the unit tests
`assertPosition()` method are probably the most relevant ones - and maybe
whether the naming of
reckart commented on pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62#issuecomment-706620912
@pkluegl When looking at this on, the different cases in the unit tests
`assertPosition()` method are probably the most relevant ones - and maybe
whether the naming of the
reckart commented on pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66#issuecomment-708345963
@mjunsilo Is it feasible to have a unit test for this?
This is an automated message from the Apache Git Service.
mjunsilo edited a comment on pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66#issuecomment-708357086
I am still thinking about how a unit test could be done, but I am short on
time at the moment. A proper integrated test requires a solution where a v2
binary is loaded
mjunsilo edited a comment on pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66#issuecomment-708357086
I am still thinking about how a unit test could be done, but I am short on
time at the moment. A proper integrated test requires a solution where a v2
binary is loaded
mjunsilo opened a new pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66
Suggested fix for issue UIMA 6273. This is critical to applications that
have mixed loading of v3 and before v3 CAS'es in runtime environments such as
the CPE where the CAS objects are recycled with
mjunsilo commented on pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66#issuecomment-708357086
I am still thinking about how a unit test could be done, but I am short on
time at the moment. A proper integrated test requires a solution where a v2
binary is loaded from
pkluegl merged pull request #13:
URL: https://github.com/apache/uima-ruta/pull/13
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pkluegl merged pull request #15:
URL: https://github.com/apache/uima-ruta/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pkluegl merged pull request #14:
URL: https://github.com/apache/uima-ruta/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #54:
URL: https://github.com/apache/uima-uimaj/pull/54
- Added Jenkinsfile from master branch here as well
- Tell the rat to log the names of files with bad license headers to the
console since on ci-builds, we do not seem to have access to browse
reckart opened a new pull request #11:
URL: https://github.com/apache/uima-ruta/pull/11
- Added Jenkinsfile
- Tell the rat to log the names of files with bad license headers to the
console since on ci-builds, we do not seem to have access to browse workspaces
reckart opened a new pull request #12:
URL: https://github.com/apache/uima-ruta/pull/12
- Added Jenkinsfile
- Tell the rat to log the names of files with bad license headers to the
console since on ci-builds, we do not seem to have access to browse workspaces
reckart merged pull request #11:
URL: https://github.com/apache/uima-ruta/pull/11
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart merged pull request #10:
URL: https://github.com/apache/uima-ruta/pull/10
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart merged pull request #53:
URL: https://github.com/apache/uima-uimaj/pull/53
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart merged pull request #54:
URL: https://github.com/apache/uima-uimaj/pull/54
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #53:
URL: https://github.com/apache/uima-uimaj/pull/53
- Added Jenkinsfile
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pkluegl opened a new pull request #13:
URL: https://github.com/apache/uima-ruta/pull/13
- touch all annotations in list
- added test
This is an automated message from the Apache Git Service.
To respond to the message,
reckart merged pull request #12:
URL: https://github.com/apache/uima-ruta/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pkluegl opened a new pull request #14:
URL: https://github.com/apache/uima-ruta/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pkluegl opened a new pull request #15:
URL: https://github.com/apache/uima-ruta/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reckart commented on pull request #56:
URL: https://github.com/apache/uima-uimaj/pull/56#issuecomment-701649021
> Is there any implication of breakage for people still running older levels
of Eclipse?
Hard to tell - that is why I am asking for a review ;) Comparing the
Manifests
reckart merged pull request #57:
URL: https://github.com/apache/uima-uimaj/pull/57
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #58:
URL: https://github.com/apache/uima-uimaj/pull/58
- Update Java / Eclipse minimum version info in the documentation
This is an automated message from the Apache Git Service.
To respond
reckart merged pull request #56:
URL: https://github.com/apache/uima-uimaj/pull/56
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-701935359
@mischor looks good to me - unit tests are also all passing. I added another
unit test which uses a custom classpath instead of a custom classloader - also
works. So I'll merge
reckart opened a new pull request #57:
URL: https://github.com/apache/uima-uimaj/pull/57
- Add exclusions for the artifacts that are missing
This is an automated message from the Apache Git Service.
To respond to the
reckart merged pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart merged pull request #58:
URL: https://github.com/apache/uima-uimaj/pull/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #59:
URL: https://github.com/apache/uima-uimaj/pull/59
- Update Java / Eclipse minimum version info in the documentation
This is an automated message from the Apache Git Service.
To respond
pkluegl opened a new pull request #16:
URL: https://github.com/apache/uima-ruta/pull/16
…s in pipeline
- added test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
reckart opened a new pull request #60:
URL: https://github.com/apache/uima-uimaj/pull/60
- Fix the case where types are overwritten via a classloader passed to the
resource manager (UIMAv3-specific solution)
- Added corresponding unit tests (same ones we used for the UIMAv2 version
of
reckart merged pull request #59:
URL: https://github.com/apache/uima-uimaj/pull/59
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #56:
URL: https://github.com/apache/uima-uimaj/pull/56
- Add exclusions for the artifacts that are missing
This is an automated message from the Apache Git Service.
To respond to the
reckart commented on pull request #56:
URL: https://github.com/apache/uima-uimaj/pull/56#issuecomment-699635374
Folks, if nobody wants to comment/review this PR, then I'll simply merge it.
This is an automated message from
reckart commented on a change in pull request #9:
URL: https://github.com/apache/uima-ruta/pull/9#discussion_r432087654
##
File path:
ruta-core/src/main/java/org/apache/uima/ruta/cache/RutaPatternCache.java
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software
reckart merged pull request #119:
URL: https://github.com/apache/uima-uimafit/pull/119
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart opened a new pull request #120:
URL: https://github.com/apache/uima-uimafit/pull/120
- CAS validation support
- AssertJ module for uimaFIT
- JUnit-specific stuff for uimaFIT
**JIRA Ticket:** https://issues.apache.org/jira/browse/UIMA-6263
reckart opened a new pull request #119:
URL: https://github.com/apache/uima-uimafit/pull/119
- Allow failing or skipping checks by throwing an exception
- Pull out custom assert code into a super-class
- made Validator.Builder fluent
- allow validating using a custom validator
reckart opened a new pull request #121:
URL: https://github.com/apache/uima-uimafit/pull/121
- Exclude service locator file from rat check
- Align v2 and v3 top-level POM a bit more
- Upgrade AssertJ dependency
**JIRA Ticket:** https://issues.apache.org/jira/browse/UIMA-6263
reckart merged pull request #120:
URL: https://github.com/apache/uima-uimafit/pull/120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart merged pull request #121:
URL: https://github.com/apache/uima-uimafit/pull/121
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart opened a new pull request #76:
URL: https://github.com/apache/uima-uimaj/pull/76
- Use true offsets of the reference annotation to determine starting point
of the iterator
- Added unit tests for following and preceeding with and without skipping
reckart opened a new pull request #77:
URL: https://github.com/apache/uima-uimaj/pull/77
- Added extra condition that skips annotations which are at the same
location as the reference location when doing a "following" selection
- Added additional unit tests
reckart merged pull request #129:
URL: https://github.com/apache/uima-uimafit/pull/129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart merged pull request #130:
URL: https://github.com/apache/uima-uimafit/pull/130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
reckart merged pull request #78:
URL: https://github.com/apache/uima-uimaj/pull/78
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #130:
URL: https://github.com/apache/uima-uimafit/pull/130
- When selecting following annotations, skip over zero-width annotations
that are the the end position of the reference interval
- Added unit test checking behavior for zero-width annotations at
reckart opened a new pull request #78:
URL: https://github.com/apache/uima-uimaj/pull/78
- When selecting following annotations, skip over zero-width annotations
that are the the end position of the reference interval
- Added unit test checking behavior for zero-width annotations at
reckart opened a new pull request #129:
URL: https://github.com/apache/uima-uimafit/pull/129
- When selecting following annotations, skip over zero-width annotations
that are the the end position of the reference interval
- Added unit test checking behavior for zero-width annotations at
reckart merged pull request #77:
URL: https://github.com/apache/uima-uimaj/pull/77
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart merged pull request #76:
URL: https://github.com/apache/uima-uimaj/pull/76
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pkluegl opened a new pull request #20:
URL: https://github.com/apache/uima-ruta/pull/20
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pkluegl merged pull request #20:
URL: https://github.com/apache/uima-ruta/pull/20
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart opened a new pull request #114:
URL: https://github.com/apache/uima-uimafit/pull/114
- Adding a basic Jenkinsfile
**JIRA Ticket:** https://issues.apache.org/jira/browse/UIMA-6257
This is an automated
reckart opened a new pull request #49:
URL: https://github.com/apache/uima-uimaj/pull/49
Merge the branch on which UIMA Java SDK 3.1.1 was released to update the
version in the POMs on the master branch and to incorporate any changes that
were done as part of the UIMA Java SDK 3.1.1
reckart commented on pull request #49:
URL: https://github.com/apache/uima-uimaj/pull/49#issuecomment-646591703
@mischor Looks like we didn't merge the RC branch into master after the
3.1.1 release. I think we should do this. The master branch still lists as
being 3.1.1-SNAPSHOT instead
reckart commented on pull request #45:
URL: https://github.com/apache/uima-uimaj/pull/45#issuecomment-646519133
@mischor Hm, looks like the initial UIMA-6168 changes went into UIMAv3, so
probably this fix should also be merged to UIMAv3.
mischor commented on pull request #45:
URL: https://github.com/apache/uima-uimaj/pull/45#issuecomment-646656812
Confirming, this fix needs to go into v3.
This is an automated message from the Apache Git Service.
To respond
mischor closed pull request #47:
URL: https://github.com/apache/uima-uimaj/pull/47
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mischor commented on pull request #47:
URL: https://github.com/apache/uima-uimaj/pull/47#issuecomment-646652049
fix replaced with pull req 48
This is an automated message from the Apache Git Service.
To respond to the
mischor commented on pull request #48:
URL: https://github.com/apache/uima-uimaj/pull/48#issuecomment-646650121
augustoribeiro tested, works.
This is an automated message from the Apache Git Service.
To respond to the
mischor merged pull request #48:
URL: https://github.com/apache/uima-uimaj/pull/48
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mischor commented on pull request #49:
URL: https://github.com/apache/uima-uimaj/pull/49#issuecomment-646653387
Sorry to be a bit slow these days, due to other things... Let me think about
this a bit, please...
This is an
ackelcn opened a new pull request #50:
URL: https://github.com/apache/uima-uimaj/pull/50
https://issues.apache.org/jira/browse/UIMA-6248
I create this pull request, so the new comments are highlighted.
This is an
reckart commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-649834610
Btw. here is a list of the available commands:
https://plugins.jenkins.io/ghprb/ - not sure if your word order matched and
triggered a build
mischor commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-649838606
@reckart can you see if this works (in uima v2) for you?
This is an automated message from the Apache Git
mischor closed pull request #50:
URL: https://github.com/apache/uima-uimaj/pull/50
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mischor commented on pull request #50:
URL: https://github.com/apache/uima-uimaj/pull/50#issuecomment-649006227
Closing this pull request - it should not be merged. It is too big to
review, and there are multiple committers who prefer this not be committed.
mischor commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-649832217
Jenkins, please test this
This is an automated message from the Apache Git Service.
To respond to the message,
reckart commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-650370679
@mischor I'll try next week. The setup to reproduce this "in vivo" is not
something I deal with every day (involving Docker, OSGI and whatnot)... that's
why accompanied with a
mischor opened a new pull request #52:
URL: https://github.com/apache/uima-uimaj/pull/52
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mischor merged pull request #52:
URL: https://github.com/apache/uima-uimaj/pull/52
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
augustoribeiro opened a new pull request #47:
URL: https://github.com/apache/uima-uimaj/pull/47
…t_StrRef and Slot_HeapRef in CVD
mkNodes function was iterating the loop using the size of the arrayNodes but
arrayNodes size was always 0. Using the source array size as limiter to the
mischor merged pull request #45:
URL: https://github.com/apache/uima-uimaj/pull/45
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reckart commented on a change in pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443231498
##
File path:
uimaj-core/src/test/java/org/apache/uima/cas/test/JCasClassLoaderTest.java
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software
reckart commented on a change in pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443231498
##
File path:
uimaj-core/src/test/java/org/apache/uima/cas/test/JCasClassLoaderTest.java
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software
reckart commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-647174823
Thanks for the check. I have updated the test.
Now, one test fails in UIMAv2 (with `Annotation` where `Token` would be
expected) and the other two fail in UIMAv3 (with
mischor commented on a change in pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443239137
##
File path:
uimaj-core/src/test/java/org/apache/uima/cas/test/JCasClassLoaderTest.java
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software
reckart commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-647185541
@mischor ok, now we have proper asserts
This is an automated message from the Apache Git Service.
To respond to
reckart commented on a change in pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#discussion_r443231694
##
File path: uimaj-core/pom.xml
##
@@ -78,6 +78,11 @@
assertj-core
test
+
reckart commented on pull request #46:
URL: https://github.com/apache/uima-uimaj/pull/46#issuecomment-647174982
Mind, the test is still not quite perfect. There should actually be some
asserts actually checking that the expected JCas wrappers are being used
instead of just implicitly
mischor opened a new pull request #48:
URL: https://github.com/apache/uima-uimaj/pull/48
A general fix for this, explicitly pass in array length to makeNodes
This is an automated message from the Apache Git Service.
To
mischor edited a comment on pull request #48:
URL: https://github.com/apache/uima-uimaj/pull/48#issuecomment-646322165
@augustoribeiro - Can you please test / review this alternative fix, which
should fix this for all types? Thanks!
mischor commented on pull request #48:
URL: https://github.com/apache/uima-uimaj/pull/48#issuecomment-646322165
https://github.com/augustoribeiro - Can you please test / review this
alternative fix, which should fix this for all types? Thanks!
101 - 200 of 1296 matches
Mail list logo
