[jira] [Resolved] (VCL-1043) utils.pm::kill_child_processes generates warnings if ps line begins with a space
[
https://issues.apache.org/jira/browse/VCL-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Kurth resolved VCL-1043.
-
Resolution: Fixed
> utils.pm::kill_child_processes generates warnings if ps line begins with a
> space
>
>
> Key: VCL-1043
> URL: https://issues.apache.org/jira/browse/VCL-1043
> Project: VCL
> Issue Type: Bug
> Components: vcld (backend)
>Affects Versions: 2.4.2
>Reporter: Andy Kurth
>Assignee: Andy Kurth
> Fix For: 2.5
>
>
> I can't seem to reproduce this but saw an instance on another system where a
> line produced by the ps command began with a space. As a result, the
> following warning was displayed in vcld.log:
> {noformat}
> |9379|74|74|new|utils.pm:kill_child_processes|11713| WARNING
> |9379|74|74|new|utils.pm:kill_child_processes|11713| 2017-05-11
> 13:17:51|9379|74|74|new|utils.pm:kill_child_processes|11713|parent PID: 9379:
> output line does not contain a PID:
> |9379|74|74|new|utils.pm:kill_child_processes|11713| line: ' 9744 9379 sh -c
> ps -h --ppid 9379 -o pid,ppid,args | sort -r 2>&1'
> |9379|74|74|new|utils.pm:kill_child_processes|11713| ( 0) utils.pm,
> kill_child_processes (line: 11713)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-1) utils.pm,
> run_ssh_command (line: 4383)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-2) OS.pm, execute
> (line: 3163)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-3) Linux.pm,
> nfs_mount_share (line: 6131)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-4) Linux.pm,
> nfs_mount_share (line: 6198)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-5) OS.pm,
> mount_nfs_shares (line: 5104)
> {noformat}
> A simple modification to the regex in kill_child_processes will fix this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (VCL-1043) utils.pm::kill_child_processes generates warnings if ps line begins with a space
[
https://issues.apache.org/jira/browse/VCL-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008524#comment-16008524
]
ASF subversion and git services commented on VCL-1043:
--
Commit 1795003 from arku...@apache.org in branch 'vcl/trunk'
[ https://svn.apache.org/r1795003 ]
VCL-1043
Modified regex in utils.pm::kill_child_processes to not generate a warning if a
ps output line begins with a space. Also added a check to make sure it was
passed an argument.
> utils.pm::kill_child_processes generates warnings if ps line begins with a
> space
>
>
> Key: VCL-1043
> URL: https://issues.apache.org/jira/browse/VCL-1043
> Project: VCL
> Issue Type: Bug
> Components: vcld (backend)
>Affects Versions: 2.4.2
>Reporter: Andy Kurth
>Assignee: Andy Kurth
> Fix For: 2.5
>
>
> I can't seem to reproduce this but saw an instance on another system where a
> line produced by the ps command began with a space. As a result, the
> following warning was displayed in vcld.log:
> {noformat}
> |9379|74|74|new|utils.pm:kill_child_processes|11713| WARNING
> |9379|74|74|new|utils.pm:kill_child_processes|11713| 2017-05-11
> 13:17:51|9379|74|74|new|utils.pm:kill_child_processes|11713|parent PID: 9379:
> output line does not contain a PID:
> |9379|74|74|new|utils.pm:kill_child_processes|11713| line: ' 9744 9379 sh -c
> ps -h --ppid 9379 -o pid,ppid,args | sort -r 2>&1'
> |9379|74|74|new|utils.pm:kill_child_processes|11713| ( 0) utils.pm,
> kill_child_processes (line: 11713)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-1) utils.pm,
> run_ssh_command (line: 4383)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-2) OS.pm, execute
> (line: 3163)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-3) Linux.pm,
> nfs_mount_share (line: 6131)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-4) Linux.pm,
> nfs_mount_share (line: 6198)
> |9379|74|74|new|utils.pm:kill_child_processes|11713| (-5) OS.pm,
> mount_nfs_shares (line: 5104)
> {noformat}
> A simple modification to the regex in kill_child_processes will fix this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (VCL-1043) utils.pm::kill_child_processes generates warnings if ps line begins with a space
Andy Kurth created VCL-1043:
---
Summary: utils.pm::kill_child_processes generates warnings if ps
line begins with a space
Key: VCL-1043
URL: https://issues.apache.org/jira/browse/VCL-1043
Project: VCL
Issue Type: Bug
Components: vcld (backend)
Affects Versions: 2.4.2
Reporter: Andy Kurth
Assignee: Andy Kurth
Fix For: 2.5
I can't seem to reproduce this but saw an instance on another system where a
line produced by the ps command began with a space. As a result, the following
warning was displayed in vcld.log:
{noformat}
|9379|74|74|new|utils.pm:kill_child_processes|11713| WARNING
|9379|74|74|new|utils.pm:kill_child_processes|11713| 2017-05-11
13:17:51|9379|74|74|new|utils.pm:kill_child_processes|11713|parent PID: 9379:
output line does not contain a PID:
|9379|74|74|new|utils.pm:kill_child_processes|11713| line: ' 9744 9379 sh -c
ps -h --ppid 9379 -o pid,ppid,args | sort -r 2>&1'
|9379|74|74|new|utils.pm:kill_child_processes|11713| ( 0) utils.pm,
kill_child_processes (line: 11713)
|9379|74|74|new|utils.pm:kill_child_processes|11713| (-1) utils.pm,
run_ssh_command (line: 4383)
|9379|74|74|new|utils.pm:kill_child_processes|11713| (-2) OS.pm, execute (line:
3163)
|9379|74|74|new|utils.pm:kill_child_processes|11713| (-3) Linux.pm,
nfs_mount_share (line: 6131)
|9379|74|74|new|utils.pm:kill_child_processes|11713| (-4) Linux.pm,
nfs_mount_share (line: 6198)
|9379|74|74|new|utils.pm:kill_child_processes|11713| (-5) OS.pm,
mount_nfs_shares (line: 5104)
{noformat}
A simple modification to the regex in kill_child_processes will fix this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (VCL-919) Allow customization of notification messages sent to users
[
https://issues.apache.org/jira/browse/VCL-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008484#comment-16008484
]
ASF subversion and git services commented on VCL-919:
-
Commit 1795001 from arku...@apache.org in branch 'vcl/trunk'
[ https://svn.apache.org/r1795001 ]
VCL-919
Added dedicated utils.pm::database_update which returns the number of rows
affected, including 0. Separated this from database_execute due to the numerous
return type scenarios depending on the query type. Existing calls to
database_execute for INSERT statements are unchanged.
utils.pm::check_messages_need_validating is the only subroutine currently using
database_update;
Renamed utils.pm::message_needs_validating to check_messages_need_validating
and reworked it. It's now fully functional.
Changed the regex's used in DataStructure.pm::substitute_string_variables and
get_invalid_substitution_identifiers to detect additional invalid patterns such
as [], [ ], and [foo].
Added call to check_messages_need_validating in vcld.
> Allow customization of notification messages sent to users
> --
>
> Key: VCL-919
> URL: https://issues.apache.org/jira/browse/VCL-919
> Project: VCL
> Issue Type: New Feature
> Components: database, vcld (backend), web gui (frontend)
>Reporter: Andy Kurth
> Fix For: 2.5
>
>
> The backend code sends various messages to users. Examples:
> * Email when reservation is ready
> * Email when image capture is complete or delayed
> * Terminal notification when a Linux reservation is about to timeout
> All of the messages are hard-coded in the backend code. It would be an
> improvement to allow these messages to be customized without having to alter
> the source code.
> Proposed solution:
> A database table named *usermessage* would be added to the schema. It would,
> at a minimum, contain:
> * id
> * key
> * affiliationid
> * deliverymethod
> * subject
> * message
> The *id* field is not absolutely necessary but keeps with the structure of
> most other tables in the schema.
> The *key* field would be a unique identifier string which is more convenient
> to use than a simple integer. For example, _reservationready_ could
> correspond to the message sent to a user when the Connect button appears.
> The backend code could call something like {code}my ($subject, $message) =
> get_user_message('reservationready', $user_affiliation_id);{code}
> The *affiliationid* field allows messages to be customized for different sets
> of users. The messages currently hard coded would be added to the schema
> using the _global_ affiliation. Users would be sent these by default unless
> a message exists specific to their affiliation.
> The *deliverymethod* field would be used to allow email messages, IM
> messages, and other types of messages to use different text. There would be
> situations where you'd want to send the same message but some methods may
> have constraints. This could also facilitate a mobile text message feature
> in the future. The backend code could specify which type of message to
> retrieve:
> {code}my ($subject, $message) = get_user_message('reservationready',
> $user_affiliation_id, 'sms');{code}
> The backend code and database are fairly straightforward to implement. A web
> frontend feature would need to be added to allow system administrators to
> modify the messages.
> There needs to be a mechanism to specify variables in the subject and message
> fields so the backend can dynamically generate the message with the correct
> IP address, image name, etc. The syntax and vocabulary need to be determined
> so the backend and frontend are aligned.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (VCL-1006) Performance Improvements for 2.5
[ https://issues.apache.org/jira/browse/VCL-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008200#comment-16008200 ] ASF subversion and git services commented on VCL-1006: -- Commit 1794982 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1794982 ] VCL-1006 - performance improvements for 2.5 utils.php: modified encryptData and decryptData: changed 4th argument to openssl_[en|de]crypt from defined constant to 1 because defined constant doesn't exist in some versions of php > Performance Improvements for 2.5 > > > Key: VCL-1006 > URL: https://issues.apache.org/jira/browse/VCL-1006 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson >Assignee: Josh Thompson > Fix For: 2.5 > > > This issue is to track performance improvements to the web code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-277) Add support for images to join Active Directory domains
[ https://issues.apache.org/jira/browse/VCL-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008190#comment-16008190 ] ASF subversion and git services commented on VCL-277: - Commit 1794981 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1794981 ] VCL-277 - Add support for images to join Active Directory domains VCL-867 - Active Directory Authentication for Windows VM's modified code to display something in the password field when editing an AD Domain to prevent users from being confused thinking no password was set for the entry - the form is not actually filled with the real password addomain.php: -modified addEditDialogHTML: set password fields to be required -modified validateResourceData: only allow the submitted password field to be empty if editing an existing entry addomain.js: -modified addNewResource: removed calls to set required to true for password fields (always required now); added lines to set password values to empty string -modified inlineEditResourceCB: removed calls to set required to false for password fields (always required now); added lines to set password values to placeholder values -modified saveResource: if editing an AD Domain and password field values equal the placeholder values, set the password elements in the data array to empty strings > Add support for images to join Active Directory domains > --- > > Key: VCL-277 > URL: https://issues.apache.org/jira/browse/VCL-277 > Project: VCL > Issue Type: New Feature > Components: database, vcld (backend), web gui (frontend) >Affects Versions: 2.0 >Reporter: Andy Kurth > Fix For: 2.5 > > > There have been multiple requests for Active Directory integration for VCL > images. VCL image should be able to join an AD domain when they are loaded. > A web utility will need to be created to administer this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-867) Active Directory Authentication for Windows VM's
[ https://issues.apache.org/jira/browse/VCL-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008191#comment-16008191 ] ASF subversion and git services commented on VCL-867: - Commit 1794981 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1794981 ] VCL-277 - Add support for images to join Active Directory domains VCL-867 - Active Directory Authentication for Windows VM's modified code to display something in the password field when editing an AD Domain to prevent users from being confused thinking no password was set for the entry - the form is not actually filled with the real password addomain.php: -modified addEditDialogHTML: set password fields to be required -modified validateResourceData: only allow the submitted password field to be empty if editing an existing entry addomain.js: -modified addNewResource: removed calls to set required to true for password fields (always required now); added lines to set password values to empty string -modified inlineEditResourceCB: removed calls to set required to false for password fields (always required now); added lines to set password values to placeholder values -modified saveResource: if editing an AD Domain and password field values equal the placeholder values, set the password elements in the data array to empty strings > Active Directory Authentication for Windows VM's > > > Key: VCL-867 > URL: https://issues.apache.org/jira/browse/VCL-867 > Project: VCL > Issue Type: New Feature > Components: database, vcld (backend), web gui (frontend) >Reporter: Junaid Ali >Assignee: Andy Kurth > Labels: features > Fix For: 2.5 > > Attachments: managementnode.patch, vmadsauth.sql, web.patch > > > The current VCL application creates local user accounts for each reservation. > There is a need to provide active directory authentication so as to provide > access to domain resources like profile and network shares during the VCL > reservation. > This patch updates the VCL database by creating two additional tables: > activedirectorydomain -> used to store active directory related information > imageactivedirectorydomain -> used to store mapping of which images use which > active directory domain. > A new column is added to the reservation table to hold current active > directory information for that particular reservation. > The patch updates the VCL backed (vcld) to add functionality to make the > windows images part of the active directory domain. It also sets the > computer's hostname to be the same as defined in the database. This is done > to prevent creation of a lot of temporary computer objects within Active > Directory. The process of domain join add's two reboots (one for hostname > update and one for domain join). After each reboot the cygwin_rebase scripts > are run to reconfigure SSHD. > The patch also updates the VCL frontend to allow management of Active > directory domains within the system and also manage the association of VCL > images and active directory domains. There is an option to enable moving > computer objects to specific Active directory Organization Unit's for better > grouping and ability to apply custom policies to custom group of images on > the Active directory side. This option was working in Cygwin 1.5 but stopped > working in Cygwin 1.7 due to some path issues. I left this option in the > front-end while I look for resolution within Cygwin 1.7. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-1042) add max reservation times to user lookup information
[ https://issues.apache.org/jira/browse/VCL-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008170#comment-16008170 ] ASF subversion and git services commented on VCL-1042: -- Commit 1794980 from [~jfthomps] in branch 'vcl/trunk' [ https://svn.apache.org/r1794980 ] VCL-1042 - add max reservation times to user lookup information privileges.php: modified userLookup: added section to display Initial, Extend, and Total times for the user > add max reservation times to user lookup information > > > Key: VCL-1042 > URL: https://issues.apache.org/jira/browse/VCL-1042 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) >Reporter: Josh Thompson > Fix For: 2.5 > > > It would be helpful to show a user's max allowed reservation times on the > User Lookup page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (VCL-1042) add max reservation times to user lookup information
Josh Thompson created VCL-1042: -- Summary: add max reservation times to user lookup information Key: VCL-1042 URL: https://issues.apache.org/jira/browse/VCL-1042 Project: VCL Issue Type: Improvement Components: web gui (frontend) Reporter: Josh Thompson Fix For: 2.5 It would be helpful to show a user's max allowed reservation times on the User Lookup page. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (VCL-867) Active Directory Authentication for Windows VM's
[ https://issues.apache.org/jira/browse/VCL-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Thompson reopened VCL-867: --- need to handle password in addomain table better > Active Directory Authentication for Windows VM's > > > Key: VCL-867 > URL: https://issues.apache.org/jira/browse/VCL-867 > Project: VCL > Issue Type: New Feature > Components: database, vcld (backend), web gui (frontend) >Reporter: Junaid Ali >Assignee: Andy Kurth > Labels: features > Fix For: 2.5 > > Attachments: managementnode.patch, vmadsauth.sql, web.patch > > > The current VCL application creates local user accounts for each reservation. > There is a need to provide active directory authentication so as to provide > access to domain resources like profile and network shares during the VCL > reservation. > This patch updates the VCL database by creating two additional tables: > activedirectorydomain -> used to store active directory related information > imageactivedirectorydomain -> used to store mapping of which images use which > active directory domain. > A new column is added to the reservation table to hold current active > directory information for that particular reservation. > The patch updates the VCL backed (vcld) to add functionality to make the > windows images part of the active directory domain. It also sets the > computer's hostname to be the same as defined in the database. This is done > to prevent creation of a lot of temporary computer objects within Active > Directory. The process of domain join add's two reboots (one for hostname > update and one for domain join). After each reboot the cygwin_rebase scripts > are run to reconfigure SSHD. > The patch also updates the VCL frontend to allow management of Active > directory domains within the system and also manage the association of VCL > images and active directory domains. There is an option to enable moving > computer objects to specific Active directory Organization Unit's for better > grouping and ability to apply custom policies to custom group of images on > the Active directory side. This option was working in Cygwin 1.5 but stopped > working in Cygwin 1.7 due to some path issues. I left this option in the > front-end while I look for resolution within Cygwin 1.7. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (VCL-1039) create windows base image failed
[ https://issues.apache.org/jira/browse/VCL-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007916#comment-16007916 ] Joseph Fischetti commented on VCL-1039: --- It's generally not helpful to dump pages and pages of logs hoping for assistance. Furthermore, this really belongs in the user mailing list. That said, it looks like your management node is trying to capture an image of itself. At some point while adding computers, you specified a guest machine with 127.0.0.1. That's no good. What does your installation look like? Are all 3 vcl components on the same server? And what provisioning method are you using? > create windows base image failed > - > > Key: VCL-1039 > URL: https://issues.apache.org/jira/browse/VCL-1039 > Project: VCL > Issue Type: Project > Components: vcld (backend) >Affects Versions: 2.4.2 >Reporter: ariuntulga kikoo > Fix For: 2.4.2 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
