[tools] Errors running 2.0.x branch unit tests in trunk

2020-12-14 Thread Christopher Schultz
All, I realize that 2.0 is a little long in the tooth, but I haven't yet moved to 3.0 (I still need Struts support) and so I'm working with that for the time being. $ svn checkout http://svn.apache.org/repos/asf/velocity/tools/branches/2.0.x velocity-tools-2.0.x $ cd velocity-tools-2.0.x

Re: Limiting VelocityLayoutServlet buffer size

2020-12-14 Thread Christopher Schultz
Nathan, On 12/14/20 11:15, Nathan Bubna wrote: I'm pretty sure we don't have a setting like that. Yep, I just got into the code and was writing a patch for it: L265 protected void mergeTemplate(Template template, Context context, HttpServletResponse

Re: Limiting VelocityLayoutServlet buffer size

2020-12-14 Thread Nathan Bubna
I'm pretty sure we don't have a setting like that. On Mon, Dec 14, 2020 at 8:01 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > We recently suffered an OOME in production because we had a huge SQL > query return a log of data which, in turn, generated even more HTML >

Limiting VelocityLayoutServlet buffer size

2020-12-14 Thread Christopher Schultz
All, We recently suffered an OOME in production because we had a huge SQL query return a log of data which, in turn, generated even more HTML output for a particular screen. We got an OOME with ASTNode.render trying to call StringWriter.write (which calls StringBuffer's auto-re-sizing)