Ok, I will create another branch with code changes (not style)
I'll pushing during the day.
I have a question... this Class ExtendedProperties from
commons-collection isn't use generics and use object for return the
instance so... It's hard to work with this. Any plans for remove,
change or use
Ok... now more clear changes (a lot, but more clear)
https://github.com/pcollaog/velocity-engine/tree/feature/add-generics-remove-casts
Best Regards
On Fri, Jun 12, 2015 at 9:30 AM, Francisco Collao Gárate
pcoll...@gmail.com wrote:
Ok, I will create another branch with code changes (not style)
Hi Francisco,
Thank you for this work, it's appreciated. I did a quick pass over the
code, I don't know if you received those comments [1], and I see you did
even more work afterwards. Can you review those comments?
[1] https://github.com/apache/velocity-engine/pull/2
On 06/08/2015 11:06 AM,
Hi Francisco,
Good idea about the codestyle files, I usually like to:
- add configuration files for Eclipse / IDEA
- set up the checkstyle Maven plugin to enforce a common codestyle (and
a several other good code practices)
- set up a license checking maven plugin to enforce the presence of the
Hi:
1... thanks so much for the review of the changes.
2... sorry about the formatter that I use (eclipse + apache maven code
style). I will correct the classes when I'll work on them. It's a good
idea publish the eclipse formatter (xml) in the velocity wiki, It will
be more easy add the right
Hi:
I've been working on eliminate some warnings with jdk 1.5 and above,
removing some unnecesary cast when generics parameter are apply.
I published a branch on my fork on github if anybody want to help or test.
Here the link:
