Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-05 Thread Thomas Mortagne
On Tue, Mar 5, 2019 at 2:12 PM Claude Brisson wrote: > > Oh, you are referring to the recent commit #1854695, "[engine] Invalid > method calls should definitely be logged". > > Strict mode is not concerned here, its purpose is to throw exceptions > that will stop merging whenever an invalid

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-05 Thread Claude Brisson
Oh, you are referring to the recent commit #1854695, "[engine] Invalid method calls should definitely be logged". Strict mode is not concerned here, its purpose is to throw exceptions that will stop merging whenever an invalid reference or method is encountered. Without strict mode, we were

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-04 Thread Thomas Mortagne
Actually it's very clear why it's done like this sorry. What is really not clear and not really documented in the migration notes is why did this became a problem ? I can think of several use cases where not existing may be called and then a fallback done depending on the version of XWiki Le

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-04 Thread Thomas Mortagne
I did not double checked but I don't remember this to be the case in my previous quick tests with Velocity 2.0: I get [WARN] Object 'java.lang.String' does not contain method tyty() at mytemplate[line 1, column 36] warnings despite the fact that I did not modified "runtime.references.strict"

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-03 Thread Claude Brisson
On 03/03/2019 21:52, Claude Brisson wrote: Is this list complete? http://velocity.apache.org/engine/2.0/configuration.html Apart from 2.1 novelties, I'm quite sure, yes. All new ones are visible in http://velocity.apache.org/engine/devel/configuration.html It looks like this one is an

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-03 Thread Claude Brisson
On 03/03/2019 20:09, Michael Osipov wrote: I have noticed that too actually. I always wondered about this quirk: resource.loader = file,classpath,etc. file.resource.loader.path = ... instead of resource.loaders = file,classpath resource.loader.file.path = More standard, I agree.

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-03 Thread Michael Osipov
Am 2019-03-03 um 19:29 schrieb Claude Brisson: Thanks for the diligent feedback. Going through the notes makes make stumble upon this: Added a new 'parser.allows.dash.in.identifiers' boolean property (false per default) to (dis)allow '-' in reference identifiers . Fixes VELOCITY-542. I

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-03 Thread Claude Brisson
Thanks for the diligent feedback. Going through the notes makes make stumble upon this: Added a new 'parser.allows.dash.in.identifiers' boolean property (false per default) to (dis)allow '-' in reference identifiers . Fixes VELOCITY-542. I see a few issues here: * The property name is

Re: [ANNOUNCE] Velocity Engine 2.1 test build available

2019-03-03 Thread Michael Osipov
Am 2019-03-03 um 16:17 schrieb Claude Brisson: The test build of Velocity Engine 2.1 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity Engine 2.1 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will