[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Marnix van Bochove (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12570997#action_12570997 ] Marnix van Bochove commented on VELOCITY-537: - I found a solution to this

Re: Call a velocity macro

2008-02-21 Thread Christopher Schultz
Nathan, Nathan Bubna wrote: I'm pretty sure #local is still just in Geir's whiteboard section. No one has ever gotten it promoted out of there. I've never been opposed to it, but i've also never been interested in putting the work needed into it (tests, docs, etc). I have to admit that when

[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Christopher Schultz (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571059#action_12571059 ] Christopher Schultz commented on VELOCITY-537: -- Marnix, I'm no expert in

[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Marnix van Bochove (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571109#action_12571109 ] Marnix van Bochove commented on VELOCITY-537: - Christopher, I think the

Re: Call a velocity macro

2008-02-21 Thread Nathan Bubna
On Thu, Feb 21, 2008 at 6:36 AM, Christopher Schultz [EMAIL PROTECTED] wrote: Nathan, Nathan Bubna wrote: I'm pretty sure #local is still just in Geir's whiteboard section. No one has ever gotten it promoted out of there. I've never been opposed to it, but i've also never been

Re: Call a velocity macro

2008-02-21 Thread Geir Magnusson Jr.
Wait - that's not true You certainly can do scoped velocimacros... geir On Feb 21, 2008, at 12:57 PM, Nathan Bubna wrote: On Thu, Feb 21, 2008 at 6:36 AM, Christopher Schultz [EMAIL PROTECTED] wrote: Nathan, Nathan Bubna wrote: I'm pretty sure #local is still just in Geir's whiteboard

Re: Call a velocity macro

2008-02-21 Thread Nathan Bubna
Yeah, sorry. I forget about that, since i've been avoiding macros for some time and never actually bothered with this property: velocimacro.context.localscope = true On Thu, Feb 21, 2008 at 9:59 AM, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: Wait - that's not true You certainly can do

[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571145#action_12571145 ] Nathan Bubna commented on VELOCITY-537: --- NodeUtils.tokenLiteral() is not a

[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571170#action_12571170 ] Nathan Bubna commented on VELOCITY-537: --- A unit test would be great! Multi-line

[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Marnix van Bochove (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571167#action_12571167 ] Marnix van Bochove commented on VELOCITY-537: - I used this template to

Re: Call a velocity macro

2008-02-21 Thread Christopher Schultz
Geir and Nathan, Nathan Bubna wrote: Yeah, sorry. I forget about that, since i've been avoiding macros for some time and never actually bothered with this property: velocimacro.context.localscope = true I think that has further implications that what I was suggesting, which is a scope that

[jira] Updated: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Marnix van Bochove (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marnix van Bochove updated VELOCITY-537: Attachment: velocity-537.zip I created a unit test. Extract the attached zip

[jira] Commented: (VELOCITY-537) Multi-line comments causing ParseException in macros in Velocity engine 1.5

2008-02-21 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571230#action_12571230 ] Nathan Bubna commented on VELOCITY-537: --- Ah, so this is really a test for

[jira] Commented: (VELOCITY-580) Multi line comments simply don't work inside a macro

2008-02-21 Thread Nathan Bubna (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12571231#action_12571231 ] Nathan Bubna commented on VELOCITY-580: --- Marnix van Bochove posted a nice