[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805736#comment-17805736
]
Michael Osipov commented on VELOCITY-970:
-
[~cbrisson], I think we can live without it. It's
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805711#comment-17805711
]
Thomas Mortagne commented on VELOCITY-970:
--
OK, I actually did not know the shade plugin was
tmortagne commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1887573776
OK, this time I saw it I think :)
I'm not 100% sure my modification of maven-bundle-plugin is right, as I'm
not used to it.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805706#comment-17805706
]
Claude Brisson commented on VELOCITY-970:
-
That's not strange, that's an effect of the shading:
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805700#comment-17805700
]
Thomas Mortagne commented on VELOCITY-970:
--
bq. we should include it as a direct dependency
tmortagne commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1887307090
Hi @michael-o, thanks for taking a look.
I'm sorry, I don't see what you mean. The only reference left to commons-io
is [the
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805605#comment-17805605
]
Thomas Mortagne commented on VELOCITY-970:
--
Proposal pull request on
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805605#comment-17805605
]
Thomas Mortagne edited comment on VELOCITY-970 at 1/11/24 2:04 PM:
---
tmortagne opened a new pull request, #37:
URL: https://github.com/apache/velocity-engine/pull/37
Jira issue: https://issues.apache.org/jira/browse/VELOCITY-970
The idea is to remove commons-io from the velocity-engine-core JAR since
there does not seem to be a clear reason to do that
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mortagne updated VELOCITY-970:
-
Description:
commons-io is embedded in velocity-engine-core, which is OK from Java
[
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mortagne updated VELOCITY-970:
-
Description:
commons-io is embedded in velocity-engine-core, which is OK from Java
Thomas Mortagne created VELOCITY-970:
Summary: velocity-engine-core contains commons-io Maven descriptor
Key: VELOCITY-970
URL: https://issues.apache.org/jira/browse/VELOCITY-970
Project: Velocity
12 matches
Mail list logo
