[jira] [Commented] (VELTOOLS-200) Current Velocity Tools View use deprecated Velocity properties

2024-02-03 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/VELTOOLS-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813987#comment-17813987
 ] 

Michael Osipov commented on VELTOOLS-200:
-

I will happily accept PRs and merge them.

> Current Velocity Tools View use deprecated Velocity properties 
> ---
>
> Key: VELTOOLS-200
> URL: https://issues.apache.org/jira/browse/VELTOOLS-200
> Project: Velocity Tools
>  Issue Type: Bug
>  Components: VelocityView
>Affects Versions: 3.1
>Reporter: Gernot Hueller
>Priority: Minor
>
> when using current Velocity with current Velocity Tools View , I get the 
> following error messages in the log:
> {{org.apache.velocity.deprecation - configuration key 'resource.loader' has 
> been deprecated in favor of 'resource.loaders'}}
> {{org.apache.velocity.deprecation - configuration key 
> 'webapp.resource.loader.class' has been deprecated in favor of 
> 'resource.loader.webapp.class'}}
> {{org.apache.velocity.deprecation - configuration key 
> 'string.resource.loader.class' has been deprecated in favor of 
> 'resource.loader.string.class'}}
> {{org.apache.velocity.deprecation - configuration key 
> 'runtime.introspector.uberspect' has been deprecated in favor of 
> 'introspector.uberspect.class'}}
>  
> OK so maybe the old property names are used to be compatible to old Velocity 
> Engine versions, but the default is that we use current versions - so a 
> "compatibility mode" should be made smarter than just continuing to use 
> deprecated properties.
> my gradle includes:
> {{earlib group: 'org.apache.velocity', name: 'velocity-engine-core', version: 
> '2.3'}}
> {{earlib group: 'org.apache.velocity.tools', name: 'velocity-tools-view', 
> version: '3.1'}}
>  
> This has also been mentioned in a recent stackoverflow thread
> https://stackoverflow.com/questions/73026164/velocity-warnings-about-deprecated-keys-that-i-dont-even-use



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[PR] [VELOCITY-951] DataSourceResourceLoader: property datasource_url wrong [velocity-engine]

2024-02-03 Thread via GitHub


michael-o opened a new pull request, #41:
URL: https://github.com/apache/velocity-engine/pull/41

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Assigned] (VELOCITY-951) DataSourceResourceLoader: property datasource_url wrong

2024-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/VELOCITY-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned VELOCITY-951:
---

Assignee: Michael Osipov

> DataSourceResourceLoader: property datasource_url wrong
> ---
>
> Key: VELOCITY-951
> URL: https://issues.apache.org/jira/browse/VELOCITY-951
> Project: Velocity
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: 2.3
>Reporter: Andreas Sachs
>Assignee: Michael Osipov
>Priority: Minor
>
> According to the javadoc it's
>  resource.loader.ds.{*}resource.{*}datasource_url = 
> java:comp/env/jdbc/Velocity  
>  resource.loader.ds.resource.table = tb_velocity_template
>  
> But in the implementation "resource" is missing (only for datasource_url):
> dataSourceName = StringUtils.trim(configuration.getString("datasource_url"));
> tableName = StringUtils.trim(configuration.getString("resource.table"));
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Updated] (VELOCITY-951) DataSourceResourceLoader: property datasource_url wrong

2024-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/VELOCITY-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated VELOCITY-951:

Fix Version/s: 2.4

> DataSourceResourceLoader: property datasource_url wrong
> ---
>
> Key: VELOCITY-951
> URL: https://issues.apache.org/jira/browse/VELOCITY-951
> Project: Velocity
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: 2.3
>Reporter: Andreas Sachs
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 2.4
>
>
> According to the javadoc it's
>  resource.loader.ds.{*}resource.{*}datasource_url = 
> java:comp/env/jdbc/Velocity  
>  resource.loader.ds.resource.table = tb_velocity_template
>  
> But in the implementation "resource" is missing (only for datasource_url):
> dataSourceName = StringUtils.trim(configuration.getString("datasource_url"));
> tableName = StringUtils.trim(configuration.getString("resource.table"));
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Closed] (VELOCITY-941) 1.7.x backport for SecureUberspector should block methods on ClassLoader and subclasses

2024-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/VELOCITY-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed VELOCITY-941.
---
Fix Version/s: (was: 1.7.x)
 Assignee: (was: William Glass-Husain)
   Resolution: Won't Fix

I am boldy saying that no one of us will touch 1.x ever again.

> 1.7.x backport for SecureUberspector should block methods on ClassLoader and 
> subclasses
> ---
>
> Key: VELOCITY-941
> URL: https://issues.apache.org/jira/browse/VELOCITY-941
> Project: Velocity
>  Issue Type: Improvement
>Reporter: Cesar Hernandez
>Priority: Major
>
> This is a backport for [https://github.com/apache/velocity-engine/tree/1.7.x] 
> branch from the patch merged into master via: 
> https://issues.apache.org/jira/browse/VELOCITY-931
>  
> PR available:
> [https://github.com/apache/velocity-engine/pull/21]
>  
> The 1.7.x branch need also 
> [https://github.com/apache/velocity-engine/pull/22] to be able to compile, 
> test and build via ant.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Closed] (VELOCITY-950) Skipping empty lines

2024-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/VELOCITY-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed VELOCITY-950.
---
Resolution: Information Provided

As [~ch...@christopherschultz.net] noted, this is not a bug and a solution has 
been provided.

> Skipping empty lines
> 
>
> Key: VELOCITY-950
> URL: https://issues.apache.org/jira/browse/VELOCITY-950
> Project: Velocity
>  Issue Type: Wish
>  Components: Engine
>Reporter: Ivan Galkin
>Priority: Major
>
> I need to convert text from Word to PDF using "if" (or others) construction 
> of Velocity. I need to get rid of empty lines.
> Example:
> In Word it looks like: 
> «#if(xxx == "true)»1«#end»
> «#if(yyy == "true)»1«#end»
> «#if(zzz == "true)»1«#end»
> If yyy == false, xxx and zzz are true in PDF we will get:
> 1
>  
> 1
> But I need get it without an empty line somehow:
> 1
> 1
> Is it possible to do it with such functionality?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]

2024-02-03 Thread via GitHub


michael-o commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1925446221

   Superseded by #40.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[PR] [VELOCITY-972] Remove Commons IO [velocity-engine]

2024-02-03 Thread via GitHub


michael-o opened a new pull request, #40:
URL: https://github.com/apache/velocity-engine/pull/40

   Needs #39 first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Created] (VELOCITY-972) Remove Commons IO

2024-02-03 Thread Michael Osipov (Jira)
Michael Osipov created VELOCITY-972:
---

 Summary: Remove Commons IO
 Key: VELOCITY-972
 URL: https://issues.apache.org/jira/browse/VELOCITY-972
 Project: Velocity
  Issue Type: Task
  Components: Build, Engine
Affects Versions: 2.3
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.4


There are only a few spots where Commons IO is used. These can be removed for 
the two reasons:

* Replace with NIO2 methods
* Take input as-is since behavior has never been part of the contract (Javadoc)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Updated] (VELOCITY-970) velocity-engine-core contains commons-io Maven descriptor

2024-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/VELOCITY-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated VELOCITY-970:

Fix Version/s: 2.4

> velocity-engine-core contains commons-io Maven descriptor
> -
>
> Key: VELOCITY-970
> URL: https://issues.apache.org/jira/browse/VELOCITY-970
> Project: Velocity
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: 2.3
>Reporter: Thomas Mortagne
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.4
>
>
> commons-io is embedded in velocity-engine-core, which is OK from Java point 
> of view since its package is renamed (not causing any dependency problems).
> The problem is that it contains the commons-io Maven descriptors at the 
> standard location (/META-INF/maven/commons-io/commons-io/), which is a 
> problem when you analyze JAR files to find what's in it because it ends up 
> being identified as a JAR exposing commons-io (which is not the case since 
> it's weaved).
> Honestly, it feels very strange to embed commons-io in the first place given 
> that commons-lang for example is a transitive dependency, so I feel like the 
> simplest would just be to remove all the plumbing to embed and weave 
> commons-io and simply keep it as a regular transitive dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]

2024-02-03 Thread via GitHub


michael-o closed pull request #37: VELOCITY-970: velocity-engine-core contains 
commons-io Maven descriptor
URL: https://github.com/apache/velocity-engine/pull/37


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[PR] [VELOCITY-971] Upgrade to Parent 6 [velocity-engine]

2024-02-03 Thread via GitHub


michael-o opened a new pull request, #39:
URL: https://github.com/apache/velocity-engine/pull/39

   Can be merged as soon as parent 6 is on Maven Central.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



Re: [PR] VELOCITY-970: velocity-engine-core contains commons-io Maven descriptor [velocity-engine]

2024-02-03 Thread via GitHub


michael-o commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1925425736

   Closing this because the Commons IO dependency will be removed after #39 has 
been merged. Thank you for your effort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Created] (VELOCITY-971) Upgrade to Parent 6

2024-02-03 Thread Michael Osipov (Jira)
Michael Osipov created VELOCITY-971:
---

 Summary: Upgrade to Parent 6
 Key: VELOCITY-971
 URL: https://issues.apache.org/jira/browse/VELOCITY-971
 Project: Velocity
  Issue Type: Improvement
  Components: Build
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.4


Parent 6 gives us the ability to clean up a lot of duplicate stuff in our POMs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[VOTE] Release Velocity Master version 6

2024-02-03 Thread Michael Osipov

Hi,

Changelog:
* Upgrade to Apache Parent 31
* Explicitly require Maven 3.2.5+ at build time

Staging repo:
https://repository.apache.org/content/repositories/orgapachevelocity-1040/
https://repository.apache.org/content/repositories/orgapachevelocity-1040/org/apache/velocity/velocity-master/6/velocity-master-6-source-release.zip

Source release checksum(s):
velocity-master-6-source-release.zip
sha512: 
d95b652d327b9efc17f8ef0959f15c71a1fcef79c2497d1ea5713a466d1e7035a9e4132ea48f2db8f692672c831ba8430c1ba1164aa5e0faeb24b8645bcc2bcf


Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Closed] (VELOCITY-940) bodyContent in nested macros called without @ should be unset

2024-02-03 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/VELOCITY-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed VELOCITY-940.
---

> bodyContent in nested macros called without @ should be unset
> -
>
> Key: VELOCITY-940
> URL: https://issues.apache.org/jira/browse/VELOCITY-940
> Project: Velocity
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: 1.7.x, 2.3
>Reporter: Willow Nice
>Assignee: Claude Brisson
>Priority: Minor
> Fix For: 2.4
>
>
> Hi! First ever maybe bug report (pls be gentle).
>  
> {{#macro(test $label)Something $!label $!bodyContent#\{end}}}
> {{#@test('First')}}{{#test('Second')}}{{#end}}
>  
> ends up a recurring mess because $bodyContent seems to be still defined when 
> calling the inner macro without a block. I propose (perleeze) that it should 
> always be unset when calling a macro without a block. It's fine if you always 
> call with @ and supply an empty block, or unset it manually before the second 
> call
> p.s.
> #@\{test} or #\{@test} doesn't work either
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



Community over Code EU 2024 Travel Assistance Applications now open!

2024-02-03 Thread Gavin McDonald
Hello to all users, contributors and Committers!

The Travel Assistance Committee (TAC) are pleased to announce that
travel assistance applications for Community over Code EU 2024 are now
open!

We will be supporting Community over Code EU, Bratislava, Slovakia,
June 3th - 5th, 2024.

TAC exists to help those that would like to attend Community over Code
events, but are unable to do so for financial reasons. For more info
on this years applications and qualifying criteria, please visit the
TAC website at < https://tac.apache.org/ >. Applications are already
open on https://tac-apply.apache.org/, so don't delay!

The Apache Travel Assistance Committee will only be accepting
applications from those people that are able to attend the full event.

Important: Applications close on Friday, March 1st, 2024.

Applicants have until the the closing date above to submit their
applications (which should contain as much supporting material as
required to efficiently and accurately process their request), this
will enable TAC to announce successful applications shortly
afterwards.

As usual, TAC expects to deal with a range of applications from a
diverse range of backgrounds; therefore, we encourage (as always)
anyone thinking about sending in an application to do so ASAP.

For those that will need a Visa to enter the Country - we advise you apply
now so that you have enough time in case of interview delays. So do not
wait until you know if you have been accepted or not.

We look forward to greeting many of you in Bratislava, Slovakia in June,
2024!

Kind Regards,

Gavin

(On behalf of the Travel Assistance Committee)