[GitHub] [velocity-engine] arkanovicz merged pull request #15: don't leak classes via Stop.STOP_ALL stack trace

2020-05-29 Thread GitBox


arkanovicz merged pull request #15:
URL: https://github.com/apache/velocity-engine/pull/15


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] arkanovicz commented on pull request #15: don't leak classes via Stop.STOP_ALL stack trace

2020-05-29 Thread GitBox


arkanovicz commented on pull request #15:
URL: https://github.com/apache/velocity-engine/pull/15#issuecomment-635961250


   Thanks for the MR. Merged in master.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] donnerpeter opened a new pull request #15: don't leak classes via Stop.STOP_ALL stack trace

2020-05-26 Thread GitBox


donnerpeter opened a new pull request #15:
URL: https://github.com/apache/velocity-engine/pull/15


   this prevented garbage-collecting classloaders that accidentally happened to 
be in the stack trace when Stop class was first accessed
   
   This prevents plugin unloading in IntelliJ: 
https://youtrack.jetbrains.com/issue/IDEA-240449



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] nbubna commented on pull request #16: Velocity 931 update secure classlist

2020-08-05 Thread GitBox


nbubna commented on pull request #16:
URL: https://github.com/apache/velocity-engine/pull/16#issuecomment-669670311


   Looks good to me.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] wglasshusain opened a new pull request #16: Velocity 931 update secure classlist

2020-08-05 Thread GitBox


wglasshusain opened a new pull request #16:
URL: https://github.com/apache/velocity-engine/pull/16


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] nbubna commented on pull request #17: Provide a flag to ignore exception when template generator encounters…

2020-08-25 Thread GitBox


nbubna commented on pull request #17:
URL: https://github.com/apache/velocity-engine/pull/17#issuecomment-680137890


   I see the flag, but it does not appear to be used to actually do anything.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] yaverhussain commented on pull request #17: Provide a flag to ignore exception when template generator encounters…

2020-08-26 Thread GitBox


yaverhussain commented on pull request #17:
URL: https://github.com/apache/velocity-engine/pull/17#issuecomment-681198639


   Sorry, added 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] yaverhussain removed a comment on pull request #17: Provide a flag to ignore exception when template generator encounters…

2020-08-26 Thread GitBox


yaverhussain removed a comment on pull request #17:
URL: https://github.com/apache/velocity-engine/pull/17#issuecomment-681198639


   Sorry, added 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] yaverhussain opened a new pull request #17: Provide a flag to ignore exception when template generator encounters…

2020-08-24 Thread GitBox


yaverhussain opened a new pull request #17:
URL: https://github.com/apache/velocity-engine/pull/17


   … null to render in StrictMode. This is particularly useful in our upcoming 
change where in we want to turn StrictMode on but fear we might encounter a lot 
of such errors in prod.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[GitHub] [velocity-engine] yaverhussain commented on pull request #17: Provide a flag to ignore exception when template generator encounters…

2020-09-01 Thread GitBox


yaverhussain commented on pull request #17:
URL: https://github.com/apache/velocity-engine/pull/17#issuecomment-684767428


   > I see the flag, but it does not appear to be used to actually do anything.
   
   can see bit now?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org