[jira] [Commented] (VELOCITY-894) Maven central JARs don't contains debug information

2018-06-03 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/VELOCITY-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499360#comment-16499360
 ] 

Michael Osipov commented on VELOCITY-894:
-

bq. Since it's meaningful to set to true the  flag, anyhow, you won't 
always get a proper step by step debugging even with debug symbols.

It's good that you raised this. {{}} is really pure non-sense because 
 Plexus Compiler translates to {{-O}} and there is no such option with 
{{javac}}. See also: https://stackoverflow.com/q/20928320/696632

Do you mind to open an issue with MCOMPILER? I will deprecate it with the next 
version.

bq. What really looks like pure nonsense to me is that there isn't any related 
notice in http://www.apache.org/dev/publishing-maven-artifacts.html or 
elsewhere, if it looks so vital.

What do you expect to see? The ASF recommending to compile with debug symbols? 
This is the default for {{javac}}. The guide is only about deployment and not 
semantics of the binary artifact.

[~tmortagne], I am really certain that no one will really build the binaries 
for a given artifact just because of debug information. This is such hassle 
within an entire toolchain with a lot of dependencies.

I think, we need to make the use as easy as possible.

> Maven central JARs don't contains debug information
> ---
>
> Key: VELOCITY-894
> URL: https://issues.apache.org/jira/browse/VELOCITY-894
> Project: Velocity
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0
>Reporter: Thomas Mortagne
>Priority: Major
>
> As far as I can see the JAR published on velocity-engine-core-2.0.java 
> published on Maven central has been built without the debug information. 
> Makes is quite a pain to understand what happen exactly when you have 
> something to debug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELOCITY-894) Maven central JARs don't contains debug information

2018-06-02 Thread Thomas Mortagne (JIRA)


[ 
https://issues.apache.org/jira/browse/VELOCITY-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499131#comment-16499131
 ] 

Thomas Mortagne commented on VELOCITY-894:
--

"vital" is a bit strong as well as "pure nonsense" :) It's indeed the first 
time I encounter a JAR dependency without the debug symbol (and XWiki have 
quite a few dependencies :)) so I was very surprised.

I think the logic is more the opposite, I really doubt this optimization bring 
much value in practice and having the debug symbol make debugging a lot easier.

bq. someone willing to have debug information can still build binaries with it

Yes I could checkout the tag, modify the pom and hope that all will build fine 
with my version of Maven and that I will get the exact same thing but with 
debug symbol but I would really prefer not to ;)

> Maven central JARs don't contains debug information
> ---
>
> Key: VELOCITY-894
> URL: https://issues.apache.org/jira/browse/VELOCITY-894
> Project: Velocity
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0
>Reporter: Thomas Mortagne
>Priority: Major
>
> As far as I can see the JAR published on velocity-engine-core-2.0.java 
> published on Maven central has been built without the debug information. 
> Makes is quite a pain to understand what happen exactly when you have 
> something to debug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELOCITY-894) Maven central JARs don't contains debug information

2018-06-01 Thread Claude Brisson (JIRA)


[ 
https://issues.apache.org/jira/browse/VELOCITY-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498461#comment-16498461
 ] 

Claude Brisson commented on VELOCITY-894:
-

I'm sorry if I didn't respect the standard practice here. It seemed natural to 
me to optimize the size of binaries, and someone willing to have debug 
information can still build binaries with it. Since it's meaningful to set to 
true the  flag, anyhow, you won't always get a proper step by step 
debugging even with debug symbols.

But again, if the standard practice is to always keep the debugging symbols, 
then we shall ensure that the debug symbols are present for the next release. 
There's enough feedback for a new release, should I or someone else find the 
time to work on it.

What really looks like pure nonsense to me is that there isn't any related 
notice in [http://www.apache.org/dev/publishing-maven-artifacts.html] or 
elsewhere, if it looks so vital.

 

> Maven central JARs don't contains debug information
> ---
>
> Key: VELOCITY-894
> URL: https://issues.apache.org/jira/browse/VELOCITY-894
> Project: Velocity
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0
>Reporter: Thomas Mortagne
>Priority: Major
>
> As far as I can see the JAR published on velocity-engine-core-2.0.java 
> published on Maven central has been built without the debug information. 
> Makes is quite a pain to understand when happen exactly when you have 
> something to debug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



[jira] [Commented] (VELOCITY-894) Maven central JARs don't contains debug information

2018-06-01 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/VELOCITY-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498363#comment-16498363
 ] 

Michael Osipov commented on VELOCITY-894:
-

Confirmed: https://github.com/apache/velocity-engine/blob/trunk/pom.xml#L86

That's pure nonsense. 

> Maven central JARs don't contains debug information
> ---
>
> Key: VELOCITY-894
> URL: https://issues.apache.org/jira/browse/VELOCITY-894
> Project: Velocity
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0
>Reporter: Thomas Mortagne
>Priority: Major
>
> As far as I can see the JAR published on velocity-engine-core-2.0.java 
> published on Maven central has been built without the debug information. 
> Makes is quite a pain to understand when happen exactly when you have 
> something to debug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org