[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12613199#action_12613199
]
Will Glass-Husain commented on VELOCITY-223:
Hi,
Thanks for all
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12613201#action_12613201
]
Will Glass-Husain commented on VELOCITY-223:
Dear Lei,
I cannot apply your
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493509
]
Lei Gu commented on VELOCITY-223:
-
Hi Chris or Will,
Please remove synchronized key word from
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489376
]
Alexey Panchenko commented on VELOCITY-223:
---
Synchronization
stringImagePool.get(image) should be
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489392
]
Christopher Schultz commented on VELOCITY-223:
--
Since Velocity already depends on
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489416
]
Will Glass-Husain commented on VELOCITY-223:
that makes sense to me. the memory issue is a good
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489435
]
Nathan Bubna commented on VELOCITY-223:
---
Oh, and to finish out my conversation with Lei, he acknowledged
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489434
]
Nathan Bubna commented on VELOCITY-223:
---
Lei has tested and confirmed memory savings, and i see no reason to
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489437
]
Nathan Bubna commented on VELOCITY-223:
---
So, all told. I think if we drop the static Map for a ReferenceMap
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486042
]
Will Glass-Husain commented on VELOCITY-223:
Thanks, Lei!
Also, see:
Hi Nathan,
a) In the original code, a new copy of string image is constructed and
returned as part of the token, which is part of a node. When we cache
templates, these nodes stay in memory forever or until the template itself
is booted from the cache. We improved this by checking against the
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475913
]
Ryan Smith commented on VELOCITY-223:
-
We have a web site where we use velocity to generate our HTML pages.
12 matches
Mail list logo