[GitHub] incubator-weex pull request #208: [html5] fix flow plugin in build config.

Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-weex pull request #207: + [ios] boxshadow shadowcolor change to co...

GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/207 + [ios] boxshadow shadowcolor change to color + [ios] boxshadow shadowcolor change to color You can merge this pull request into a Git repository by running: $ git pull

Re: Q; How to deal with Invalid Pull Requests on GitHub?

one workaround that I use is to do a dummy-commit with a "closes" comment, not nice, but works. Dominik On Mar 31, 2017 10:20, "Niclas Hedhman" wrote: > Hi, > Some pull requests are invalid for one reason or the other, and the > original creator is "missing" or don't want

[GitHub] incubator-weex pull request #205: * [site] Modify the copyright of weex webs...

GitHub user DoranYun opened a pull request: https://github.com/apache/incubator-weex/pull/205 * [site] Modify the copyright of weex website. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DoranYun/incubator-weex

[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view

Github user sospartan commented on the issue: https://github.com/apache/incubator-weex/pull/172 Agreed. Let's discuss yoga upgrading in dev@ On Fri, Mar 31, 2017 at 4:38 PM, 隐小风 wrote: > Maybe we should open a new thread in mailing

[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view

Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/172 Maybe we should open a new thread in mailing list to discuss about layout upgrading. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Q; How to deal with Invalid Pull Requests on GitHub?

Hi, We use: git commit --allow-empty -m "Closes #123: invalid/whatever" This adds small noise in the Git history but works! Otherwise one have to contact Infra team to help. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Mar 31, 2017 at 10:19 AM, Niclas

Q; How to deal with Invalid Pull Requests on GitHub?

Hi, Some pull requests are invalid for one reason or the other, and the original creator is "missing" or don't want to remove it, how should we get it taken away? Thanks -- Niclas Hedhman, Software Developer http://polygene.apache.org - New Energy for Java

Re: Manually close invalid pull request

I'll ask infra@ what is expected... On Fri, Mar 31, 2017 at 4:12 PM, sospartan wrote: > Hi， > After move to incubator repo, we don't have the permission to manually > close PRs. > But there are some invalid issues we can not process. > Like

Manually close invalid pull request

Hi， After move to incubator repo, we don't have the permission to manually close PRs. But there are some invalid issues we can not process. Like https://github.com/apache/incubator-weex/pull/156 and https://github.com/apache/incubator-weex/pull/141. They created PR, based on 'master' and from

[GitHub] incubator-weex pull request #203: add link from customer view to actual dom.

Github user zshshr commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/203#discussion_r109107974 --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/view/IRenderStatus.java --- @@ -211,4 +211,6 @@ public interface IRenderStatus {

[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view

Github user misakuo commented on the issue: https://github.com/apache/incubator-weex/pull/172 ok, you can close this pr after csslayout updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-weex pull request #203: add link from customer view to actual dom.

GitHub user wispy316 opened a pull request: https://github.com/apache/incubator-weex/pull/203 add link from customer view to actual dom. Android customer view has no link to the actual dom. so there is no way to access from the View to virtual dom ( we can call

[GitHub] incubator-weex issue #202: [html5] dev web test

Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/202 Warnings :warning: These new JS files do not have Flow enabled:

[GitHub] incubator-weex pull request #202: [html5] dev web test

GitHub user MrRaindrop opened a pull request: https://github.com/apache/incubator-weex/pull/202 [html5] dev web test * refactor test cases for vue-render. * rebuild test case with rollup. * fix coverage report. You can merge this pull request into a Git repository by

[GitHub] incubator-weex issue #200: *[ios] fix 0.12ci

Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/200 4 Errors :no_entry_sign: