[GitHub] [incubator-weex-playground] YorkShen merged pull request #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
YorkShen merged pull request #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[ANNOUNCEMENT] Weex 0.26.0 Released

2019-07-11 Thread 王乾元
Hi, community. Weex 0.26.0 is released now, one can download source or convenience binary through the link in our website [1]. [1] https://weex.apache.org/download/download.html#latest-release Best regards.

[GitHub] [incubator-weex-playground] janpio commented on a change in pull request #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
janpio commented on a change in pull request #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#discussion_r302649793 ## File path: .gitignore ## @@ -0,0 +1,2 @@ +# CocoaPods +ios/Pods/ Review comment: You probably want tha

[GitHub] [incubator-weex-playground] wrmswindmill commented on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill commented on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510570450 thanks for your advice,and I have added all the missing commit history now.

[GitHub] [incubator-weex-playground] YorkShen edited a comment on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
YorkShen edited a comment on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510473587 The code looks like good, but there is a problem: **All the git commit history is missing**. Using `git subtree split` in https:

[GitHub] [incubator-weex-playground] YorkShen commented on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
YorkShen commented on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510473587 The code looks like good, but there is a problem: **All the git commit history is missing**. Using `git subtree split` in https://githu

[GitHub] [incubator-weex-playground] janpio commented on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
janpio commented on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510467329 Much better, thanks! 🚀 This is an automated message from the Apache Git Service.

[GitHub] [incubator-weex-playground] wrmswindmill commented on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill commented on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510463853 In this case, we don’t need include `Pods` directory, I will update the `.gitignore` and remove the `Pods` directory.

[GitHub] [incubator-weex-playground] wrmswindmill opened a new pull request #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill opened a new pull request #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-weex-playground] wrmswindmill commented on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill commented on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510463766 > Should the `Pods` directory be included in the codebase? This is

[GitHub] [incubator-weex-playground] wrmswindmill closed pull request #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill closed pull request #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-weex-playground] wrmswindmill removed a comment on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill removed a comment on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510463766 > Should the `Pods` directory be included in the codebase?

[GitHub] [incubator-weex-playground] janpio commented on issue #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
janpio commented on issue #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3#issuecomment-510461271 Should the `Pods` directory be included in the codebase? This is an automated mes

[GitHub] [incubator-weex-playground] wrmswindmill opened a new pull request #3: [iOS]Upload iOS playground

2019-07-11 Thread GitBox
wrmswindmill opened a new pull request #3: [iOS]Upload iOS playground URL: https://github.com/apache/incubator-weex-playground/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please

Re: [GitHub] [incubator-weex-playground] katherine95s opened a new pull request #2: [Android]add flag to configure weex_sdk source

2019-07-11 Thread York Shen
Of course, I have just created a JIRA issue[1] to INFRA for this problem. [1] https://issues.apache.org/jira/browse/INFRA-18735 Best Regards, York Shen 申远 > 在 2019年7月11日,19:46,Jan Piotrowski 写道: > > These emails should probably not go to th

Re: [GitHub] [incubator-weex-playground] katherine95s opened a new pull request #2: [Android]add flag to configure weex_sdk source

2019-07-11 Thread Jan Piotrowski
These emails should probably not go to this email address, but comm...@weex.incubator.apache.org or similar. Was probably not configured when creating the playground repository, and the default is the dev list if I remember correctly. Not sure if this can be done in self service or an INFRA issue

[GitHub] [incubator-weex-playground] YorkShen merged pull request #2: [Android]add flag to configure weex_sdk source

2019-07-11 Thread GitBox
YorkShen merged pull request #2: [Android]add flag to configure weex_sdk source URL: https://github.com/apache/incubator-weex-playground/pull/2 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-weex-playground] katherine95s opened a new pull request #2: [Android]add flag to configure weex_sdk source

2019-07-11 Thread GitBox
katherine95s opened a new pull request #2: [Android]add flag to configure weex_sdk source URL: https://github.com/apache/incubator-weex-playground/pull/2 This is an automated message from the Apache Git Service. To respond t

Re: [DISCUSS][LICENSE] Include downloaded dependencies in LICENSE file for Playground?

2019-07-11 Thread Jan Piotrowski
Awesome :) OT: Someone should ask INFRA to enable issues on the playground repo. J Am Do., 11. Juli 2019 um 10:36 Uhr schrieb York Shen : > > FYI: It seems like Katherine does a great job for Playground [1] in Android > side. After deleting corresponding code in weex_sdk, we will finished the j

Re: [DISCUSS][LICENSE] Include downloaded dependencies in LICENSE file for Playground?

2019-07-11 Thread York Shen
FYI: It seems like Katherine does a great job for Playground [1] in Android side. After deleting corresponding code in weex_sdk, we will finished the job of Android part for good. [1] https://github.com/apache/incubator-weex-playground/pull/1

Re: [DISCUSS][LICENSE] Include downloaded dependencies in LICENSE file for Playground?

2019-07-11 Thread York Shen
Thanks, I will change it to Copyright 2019 Apache Incubator-Weex Best Regards, York Shen 申远 > 在 2019年7月11日,16:09,Jan Piotrowski 写道: > > You should adapt "Copyright [] [name of copyright owner]", but otherwise > +1 > > Am Do., 11. Juli 2019 um 04:33 Uhr schrieb 申远 : >> >> After

Re: [DISCUSS][LICENSE] Include downloaded dependencies in LICENSE file for Playground?

2019-07-11 Thread Jan Piotrowski
You should adapt "Copyright [] [name of copyright owner]", but otherwise +1 Am Do., 11. Juli 2019 um 04:33 Uhr schrieb 申远 : > > After some research, I don't find any source code file containing > third-party work in weex playground, only separately downloaded > dependencies in its build.gradle