[jira] [Commented] (WEEX-560) [Android] fix null point of apm (ConcurrentHashMap)
[
https://issues.apache.org/jira/browse/WEEX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577822#comment-16577822
]
ASF GitHub Bot commented on WEEX-560:
-
YorkShen closed pull request #1422: [WEEX-560][Android] fix null point of apm
&& report initJSFM fail info
URL: https://github.com/apache/incubator-weex/pull/1422
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index feb843b6ff..b52fe1fda1 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -102,6 +102,7 @@
public static final String METHOD_NOTIFY_TRIM_MEMORY = "notifyTrimMemory";
public static final String METHOD_NOTIFY_SERIALIZE_CODE_CACHE =
"notifySerializeCodeCache";
+ public static final String METHOD_CREATE_INSTANCE_CONTEXT =
"createInstanceContext";
public static final String KEY_METHOD = "method";
public static final String KEY_ARGS = "args";
@@ -1628,8 +1629,12 @@ private void invokeInitFramework(Message msg) {
}
}
+ public static long sInitFrameWorkTimeOrigin;
+ public static StringBuilder sInitFrameWorkMsg = new StringBuilder();
+
private void initFramework(String framework) {
if (WXSDKEngine.isSoInitialized() && !isJSFrameworkInit()) {
+ sInitFrameWorkTimeOrigin = System.currentTimeMillis();
if (TextUtils.isEmpty(framework)) {
// if (WXEnvironment.isApkDebugable()) {
WXLogUtils.d("weex JS framework from assets");
@@ -1639,9 +1644,11 @@ private void initFramework(String framework) {
} else {
framework = WXFileUtils.loadAsset("weex-main-jsfm.js",
WXEnvironment.getApplication());
}
+sInitFrameWorkMsg.append("| weex JS framework from assets,
isSandBoxContext: ").append(isSandBoxContext);
}
if (TextUtils.isEmpty(framework)) {
setJSFrameworkInit(false);
+sInitFrameWorkMsg.append("| framework isEmpty ");
WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
"initFramework", "framework is empty!! ", null);
return;
@@ -1666,6 +1673,7 @@ private void initFramework(String framework) {
} catch (Exception e) {
e.printStackTrace();
}
+sInitFrameWorkMsg.append(" | pieSupport:").append(pieSupport);
WXLogUtils.d("[WXBridgeManager] initFrameworkEnv crashFile:" +
crashFile + " pieSupport:" + pieSupport);
// extends initFramework
if (mWXBridge.initFrameworkEnv(framework, assembleDefaultOptions(),
crashFile, pieSupport) == INIT_FRAMEWORK_OK) {
@@ -1683,39 +1691,20 @@ private void initFramework(String framework) {
WXEnvironment.JsFrameworkInit = true;
registerDomModule();
trackComponentAndModulesTime();
- String reinitInfo = "";
- if (reInitCount > 1) {
-reinitInfo = "reinit Framework:";
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_JS_FRAMEWORK_REINIT_SUCCESS,
-//"initFramework", reinitInfo + "success", null);
- } else {
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_JS_FRAMEWORK_INIT_SUCCESS,
-//"initFramework", reinitInfo + "success", null);
- }
} else {
+ sInitFrameWorkMsg.append(" | ExecuteJavaScript fail,
reInitCount").append(reInitCount);
if (reInitCount > 1) {
WXLogUtils.e("[WXBridgeManager] invokeReInitFramework
ExecuteJavaScript fail");
-String err = "[WXBridgeManager] invokeReInitFramework
ExecuteJavaScript fail reinit FrameWork";
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
-//"initFramework", "reInitCount = " + reInitCount + err,
null);
} else {
WXLogUtils.e("[WXBridgeManager] invokeInitFramework
ExecuteJavaScript fail");
-String err = "[WXBridgeManager] invokeInitFramework
ExecuteJavaScript fail";
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
-//"initFramework", err, null);
}
}
} catch (Throwable e) {
+sInitFrameWorkMsg.append(" | invokeInitFramework exception
").append(e.toString());
if (reInitCount > 1) {
WXLogUtils.e("[WXBridgeManager] invokeInitFramework ", e);
- String err = "[WXBridgeManager] invokeInitFramework reinit
[GitHub] YorkShen closed pull request #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info
YorkShen closed pull request #1422: [WEEX-560][Android] fix null point of apm
&& report initJSFM fail info
URL: https://github.com/apache/incubator-weex/pull/1422
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index feb843b6ff..b52fe1fda1 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -102,6 +102,7 @@
public static final String METHOD_NOTIFY_TRIM_MEMORY = "notifyTrimMemory";
public static final String METHOD_NOTIFY_SERIALIZE_CODE_CACHE =
"notifySerializeCodeCache";
+ public static final String METHOD_CREATE_INSTANCE_CONTEXT =
"createInstanceContext";
public static final String KEY_METHOD = "method";
public static final String KEY_ARGS = "args";
@@ -1628,8 +1629,12 @@ private void invokeInitFramework(Message msg) {
}
}
+ public static long sInitFrameWorkTimeOrigin;
+ public static StringBuilder sInitFrameWorkMsg = new StringBuilder();
+
private void initFramework(String framework) {
if (WXSDKEngine.isSoInitialized() && !isJSFrameworkInit()) {
+ sInitFrameWorkTimeOrigin = System.currentTimeMillis();
if (TextUtils.isEmpty(framework)) {
// if (WXEnvironment.isApkDebugable()) {
WXLogUtils.d("weex JS framework from assets");
@@ -1639,9 +1644,11 @@ private void initFramework(String framework) {
} else {
framework = WXFileUtils.loadAsset("weex-main-jsfm.js",
WXEnvironment.getApplication());
}
+sInitFrameWorkMsg.append("| weex JS framework from assets,
isSandBoxContext: ").append(isSandBoxContext);
}
if (TextUtils.isEmpty(framework)) {
setJSFrameworkInit(false);
+sInitFrameWorkMsg.append("| framework isEmpty ");
WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
"initFramework", "framework is empty!! ", null);
return;
@@ -1666,6 +1673,7 @@ private void initFramework(String framework) {
} catch (Exception e) {
e.printStackTrace();
}
+sInitFrameWorkMsg.append(" | pieSupport:").append(pieSupport);
WXLogUtils.d("[WXBridgeManager] initFrameworkEnv crashFile:" +
crashFile + " pieSupport:" + pieSupport);
// extends initFramework
if (mWXBridge.initFrameworkEnv(framework, assembleDefaultOptions(),
crashFile, pieSupport) == INIT_FRAMEWORK_OK) {
@@ -1683,39 +1691,20 @@ private void initFramework(String framework) {
WXEnvironment.JsFrameworkInit = true;
registerDomModule();
trackComponentAndModulesTime();
- String reinitInfo = "";
- if (reInitCount > 1) {
-reinitInfo = "reinit Framework:";
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_JS_FRAMEWORK_REINIT_SUCCESS,
-//"initFramework", reinitInfo + "success", null);
- } else {
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_JS_FRAMEWORK_INIT_SUCCESS,
-//"initFramework", reinitInfo + "success", null);
- }
} else {
+ sInitFrameWorkMsg.append(" | ExecuteJavaScript fail,
reInitCount").append(reInitCount);
if (reInitCount > 1) {
WXLogUtils.e("[WXBridgeManager] invokeReInitFramework
ExecuteJavaScript fail");
-String err = "[WXBridgeManager] invokeReInitFramework
ExecuteJavaScript fail reinit FrameWork";
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
-//"initFramework", "reInitCount = " + reInitCount + err,
null);
} else {
WXLogUtils.e("[WXBridgeManager] invokeInitFramework
ExecuteJavaScript fail");
-String err = "[WXBridgeManager] invokeInitFramework
ExecuteJavaScript fail";
-//WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
-//"initFramework", err, null);
}
}
} catch (Throwable e) {
+sInitFrameWorkMsg.append(" | invokeInitFramework exception
").append(e.toString());
if (reInitCount > 1) {
WXLogUtils.e("[WXBridgeManager] invokeInitFramework ", e);
- String err = "[WXBridgeManager] invokeInitFramework reinit FrameWork
exception!#" + e.toString();
-// WXExceptionUtils.commitCriticalExceptionRT(null,
WXErrorCode.WX_ERR_JS_FRAMEWORK,
-// "initFramework", "reInitCount ==" + reInitCount + err,
null);
}
[GitHub] YorkShen closed pull request #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler
YorkShen closed pull request #1421: * [Android] Fix invalid column count of
list/vlist/waterfall/recycler
URL: https://github.com/apache/incubator-weex/pull/1421
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
b/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
index 51b97718aa..b57c8ddf3d 100644
--- a/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
+++ b/android/sdk/src/main/java/com/taobao/weex/common/WXErrorCode.java
@@ -237,6 +237,7 @@
WX_RENDER_ERR_CONTAINER_TYPE("-9611", "WX_RENDER_ERR_CONTAINER_TYPE",
ErrorType.JS_ERROR,ErrorGroup.JS),
WX_RENDER_ERR_TRANSITION("-9616", "WX_RENDER_ERR_TRANSITION",
ErrorType.JS_ERROR, ErrorGroup.JS),
WX_RENDER_ERR_INSTANCE_ID_NULL("-9618", "WX_RENDER_ERR_INSTANCE_ID_NULL",
ErrorType.NATIVE_ERROR, ErrorGroup.NATIVE),
+ WX_RENDER_ERR_LIST_INVALID_COLUMN_COUNT("-9619",
"WX_RENDER_ERR_LIST_INVALID_COLUMNJ_CONUNT", ErrorType.JS_ERROR, ErrorGroup.JS),
/**
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
index 26c0bc4b4a..fba7adc200 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
@@ -18,20 +18,15 @@
*/
package com.taobao.weex.ui.component.list;
-import java.lang.reflect.Array;
-import java.lang.reflect.InvocationTargetException;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Map;
-
-import com.alibaba.fastjson.JSON;
-
import android.content.Context;
+import android.support.v4.util.ArrayMap;
import android.support.v7.widget.PagerSnapHelper;
import android.text.TextUtils;
+import com.alibaba.fastjson.JSON;
import com.taobao.weex.WXSDKInstance;
import com.taobao.weex.annotation.Component;
import com.taobao.weex.common.Constants;
+import com.taobao.weex.common.WXErrorCode;
import com.taobao.weex.common.WXThread;
import com.taobao.weex.ui.ComponentCreator;
import com.taobao.weex.ui.action.BasicComponentData;
@@ -45,8 +40,13 @@
import com.taobao.weex.ui.view.listview.WXRecyclerView;
import com.taobao.weex.ui.view.listview.adapter.ListBaseViewHolder;
import com.taobao.weex.ui.view.refresh.wrapper.BounceRecyclerView;
+import com.taobao.weex.utils.WXExceptionUtils;
import com.taobao.weex.utils.WXLogUtils;
import com.taobao.weex.utils.WXUtils;
+import java.lang.reflect.InvocationTargetException;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
/**
* Unlike other components, there is immutable bi-directional association
between View and
@@ -162,6 +162,15 @@ public void run() {
private void updateRecyclerAttr() {
mColumnCount =
WXUtils.parseInt(getAttrs().get(Constants.Name.COLUMN_COUNT));
+if (mColumnCount <= 0) {
+ WXExceptionUtils.commitCriticalExceptionRT(getInstanceId(),
+ WXErrorCode.WX_RENDER_ERR_LIST_INVALID_COLUMN_COUNT, "columnCount",
+ String.format(Locale.ENGLISH,
+ "You are trying to set the list/recycler/vlist/waterfall's
column to %d, which is illeal. The column count should be a positive integer",
+ mColumnCount),
+ new ArrayMap());
+ mColumnCount = Constants.Value.COLUMN_COUNT_NORMAL;
+}
mColumnGap = WXUtils.parseFloat(getAttrs().get(Constants.Name.COLUMN_GAP));
mColumnWidth =
WXUtils.parseFloat(getAttrs().get(Constants.Name.COLUMN_WIDTH));
mPaddingLeft =
WXUtils.parseFloat(getAttrs().get(Constants.Name.PADDING_LEFT));
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java
index d6ed4157e2..a6530577e9 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java
@@ -18,6 +18,8 @@
*/
package com.taobao.weex.ui.component.list.template;
+import static com.taobao.weex.common.Constants.Name.LOADMOREOFFSET;
+
import android.annotation.TargetApi;
import android.content.Context;
import android.graphics.Point;
@@ -37,18 +39,17 @@
import android.view.ViewTreeObserver;
import android.widget.FrameLayout;
import android.widget.LinearLayout;
-
import com.alibaba.fastjson.JSONArray;
import com.alibaba.fastjson.JSONObject;
import com.taobao.weex.WXEnvironment;
import com.taobao.weex.WXSDKInstance;
-import com.taobao.weex.WXSDKManager;
import com.taobao.weex.annotation.Component;
[GitHub] weex-bot commented on issue #1423: [WEEX-561][iOS] performance : fix dic value is nil
weex-bot commented on issue #1423: [WEEX-561][iOS] performance : fix dic value is nil URL: https://github.com/apache/incubator-weex/pull/1423#issuecomment-412405628 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-561) [iOS]performance , fix dic value is nil
[ https://issues.apache.org/jira/browse/WEEX-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577819#comment-16577819 ] ASF GitHub Bot commented on WEEX-561: - weex-bot commented on issue #1423: [WEEX-561][iOS] performance : fix dic value is nil URL: https://github.com/apache/incubator-weex/pull/1423#issuecomment-412405628 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS]performance , fix dic value is nil > --- > > Key: WEEX-561 > URL: https://issues.apache.org/jira/browse/WEEX-561 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] lucky-chen opened a new pull request #1423: [WEEX-561][iOS] performance : fix dic value is nil
lucky-chen opened a new pull request #1423: [WEEX-561][iOS] performance : fix dic value is nil URL: https://github.com/apache/incubator-weex/pull/1423 bug fix - NSDictionary value can't be nil This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-561) [iOS]performance , fix dic value is nil
peihan created WEEX-561: --- Summary: [iOS]performance , fix dic value is nil Key: WEEX-561 URL: https://issues.apache.org/jira/browse/WEEX-561 Project: Weex Issue Type: Bug Components: iOS Reporter: peihan Assignee: XuYouyang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-560) [Android] fix null point of apm (ConcurrentHashMap)
[ https://issues.apache.org/jira/browse/WEEX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577811#comment-16577811 ] ASF GitHub Bot commented on WEEX-560: - weex-bot edited a comment on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422#issuecomment-412404600 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Android] fix null point of apm (ConcurrentHashMap) > --- > > Key: WEEX-560 > URL: https://issues.apache.org/jira/browse/WEEX-560 > Project: Weex > Issue Type: Bug > Components: Android >Reporter: peihan >Assignee: YorkShen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info
weex-bot edited a comment on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422#issuecomment-412404600 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-560) [Android] fix null point of apm (ConcurrentHashMap)
[ https://issues.apache.org/jira/browse/WEEX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577810#comment-16577810 ] ASF GitHub Bot commented on WEEX-560: - weex-bot edited a comment on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422#issuecomment-412404600 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Android] fix null point of apm (ConcurrentHashMap) > --- > > Key: WEEX-560 > URL: https://issues.apache.org/jira/browse/WEEX-560 > Project: Weex > Issue Type: Bug > Components: Android >Reporter: peihan >Assignee: YorkShen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-560) [Android] fix null point of apm (ConcurrentHashMap)
[ https://issues.apache.org/jira/browse/WEEX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577809#comment-16577809 ] ASF GitHub Bot commented on WEEX-560: - weex-bot commented on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422#issuecomment-412404600 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Android] fix null point of apm (ConcurrentHashMap) > --- > > Key: WEEX-560 > URL: https://issues.apache.org/jira/browse/WEEX-560 > Project: Weex > Issue Type: Bug > Components: Android >Reporter: peihan >Assignee: YorkShen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info
weex-bot edited a comment on issue #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422#issuecomment-412404600 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-560) [Android] fix null point of apm (ConcurrentHashMap)
[ https://issues.apache.org/jira/browse/WEEX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577808#comment-16577808 ] ASF GitHub Bot commented on WEEX-560: - lucky-chen opened a new pull request #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422 1. bug fix ,in multiThread case ,HashMap.get may cause null point when resize 2. add extInfo of jsFrame init failed (initTime and extMsg) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Android] fix null point of apm (ConcurrentHashMap) > --- > > Key: WEEX-560 > URL: https://issues.apache.org/jira/browse/WEEX-560 > Project: Weex > Issue Type: Bug > Components: Android >Reporter: peihan >Assignee: YorkShen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] lucky-chen opened a new pull request #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info
lucky-chen opened a new pull request #1422: [WEEX-560][Android] fix null point of apm && report initJSFM fail info URL: https://github.com/apache/incubator-weex/pull/1422 1. bug fix ,in multiThread case ,HashMap.get may cause null point when resize 2. add extInfo of jsFrame init failed (initTime and extMsg) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-560) [Android] fix null point of apm (ConcurrentHashMap)
peihan created WEEX-560: --- Summary: [Android] fix null point of apm (ConcurrentHashMap) Key: WEEX-560 URL: https://issues.apache.org/jira/browse/WEEX-560 Project: Weex Issue Type: Bug Components: Android Reporter: peihan Assignee: YorkShen -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler
weex-bot edited a comment on issue #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler URL: https://github.com/apache/incubator-weex/pull/1421#issuecomment-412401323 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler
weex-bot edited a comment on issue #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler URL: https://github.com/apache/incubator-weex/pull/1421#issuecomment-412401323 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] YorkShen opened a new pull request #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler
YorkShen opened a new pull request #1421: * [Android] Fix invalid column count of list/vlist/waterfall/recycler URL: https://github.com/apache/incubator-weex/pull/1421 Due to some JS reason, list/vlist/waterfall/recycler's column count may be zero, which is illegal. This commit will change the 0 column count to 1 in order to avoid **Divided by 0 Exception** . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1417: [jsfm] Upgrade js framework to v0.27.5
weex-bot edited a comment on issue #1417: [jsfm] Upgrade js framework to v0.27.5 URL: https://github.com/apache/incubator-weex/pull/1417#issuecomment-412001163 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1417: [jsfm] Upgrade js framework to v0.27.5
weex-bot edited a comment on issue #1417: [jsfm] Upgrade js framework to v0.27.5 URL: https://github.com/apache/incubator-weex/pull/1417#issuecomment-412001163 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1417: [jsfm] Upgrade js framework to v0.27.5
weex-bot edited a comment on issue #1417: [jsfm] Upgrade js framework to v0.27.5 URL: https://github.com/apache/incubator-weex/pull/1417#issuecomment-412001163 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-559) Resend handleAppear for lazily created scrollview
[
https://issues.apache.org/jira/browse/WEEX-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577792#comment-16577792
]
ASF GitHub Bot commented on WEEX-559:
-
cxfeng1 closed pull request #1420: [WEEX-559][iOS]Fix issue that handleAppear
should be resent for lazil…
URL: https://github.com/apache/incubator-weex/pull/1420
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
b/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
index 54a6fa0745..0735ac2f27 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
+++ b/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
@@ -264,6 +264,8 @@ typedef id (^WXDataBindingBlock)(NSDictionary *data, BOOL
*needUpdate);
- (void)_detachSlotEvent:(NSDictionary *)data;
+- (void)_buildViewHierarchyLazily;
+
@end
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
index 4a876db8fc..33f9439062 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
@@ -229,8 +229,6 @@ - (void)viewDidLoad
- (void)layoutDidFinish
{
-
-
if ([self isViewLoaded]) {
[self setContentSize:_contentSize];
[self adjustSticky];
@@ -240,6 +238,12 @@ - (void)layoutDidFinish
[_loadingComponent resizeFrame];
}
+- (void)_buildViewHierarchyLazily
+{
+[super _buildViewHierarchyLazily];
+[self handleAppear];
+}
+
- (void)viewWillUnload
{
((UIScrollView *)_view).delegate = nil;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resend handleAppear for lazily created scrollview
> -
>
> Key: WEEX-559
> URL: https://issues.apache.org/jira/browse/WEEX-559
> Project: Weex
> Issue Type: Bug
> Components: iOS
>Affects Versions: 0.19
>Reporter: Wang Qianyuan
>Assignee: XuYouyang
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] cxfeng1 closed pull request #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil…
cxfeng1 closed pull request #1420: [WEEX-559][iOS]Fix issue that handleAppear
should be resent for lazil…
URL: https://github.com/apache/incubator-weex/pull/1420
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
b/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
index 54a6fa0745..0735ac2f27 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
+++ b/ios/sdk/WeexSDK/Sources/Component/WXComponent_internal.h
@@ -264,6 +264,8 @@ typedef id (^WXDataBindingBlock)(NSDictionary *data, BOOL
*needUpdate);
- (void)_detachSlotEvent:(NSDictionary *)data;
+- (void)_buildViewHierarchyLazily;
+
@end
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
index 4a876db8fc..33f9439062 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
+++ b/ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.mm
@@ -229,8 +229,6 @@ - (void)viewDidLoad
- (void)layoutDidFinish
{
-
-
if ([self isViewLoaded]) {
[self setContentSize:_contentSize];
[self adjustSticky];
@@ -240,6 +238,12 @@ - (void)layoutDidFinish
[_loadingComponent resizeFrame];
}
+- (void)_buildViewHierarchyLazily
+{
+[super _buildViewHierarchyLazily];
+[self handleAppear];
+}
+
- (void)viewWillUnload
{
((UIScrollView *)_view).delegate = nil;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot commented on issue #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil…
weex-bot commented on issue #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil… URL: https://github.com/apache/incubator-weex/pull/1420#issuecomment-412399460 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-559) Resend handleAppear for lazily created scrollview
[ https://issues.apache.org/jira/browse/WEEX-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577791#comment-16577791 ] ASF GitHub Bot commented on WEEX-559: - weex-bot edited a comment on issue #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil… URL: https://github.com/apache/incubator-weex/pull/1420#issuecomment-412399460 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resend handleAppear for lazily created scrollview > - > > Key: WEEX-559 > URL: https://issues.apache.org/jira/browse/WEEX-559 > Project: Weex > Issue Type: Bug > Components: iOS >Affects Versions: 0.19 >Reporter: Wang Qianyuan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-559) Resend handleAppear for lazily created scrollview
[ https://issues.apache.org/jira/browse/WEEX-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577790#comment-16577790 ] ASF GitHub Bot commented on WEEX-559: - weex-bot commented on issue #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil… URL: https://github.com/apache/incubator-weex/pull/1420#issuecomment-412399460 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resend handleAppear for lazily created scrollview > - > > Key: WEEX-559 > URL: https://issues.apache.org/jira/browse/WEEX-559 > Project: Weex > Issue Type: Bug > Components: iOS >Affects Versions: 0.19 >Reporter: Wang Qianyuan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil…
weex-bot edited a comment on issue #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil… URL: https://github.com/apache/incubator-weex/pull/1420#issuecomment-412399460 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-559) Resend handleAppear for lazily created scrollview
[ https://issues.apache.org/jira/browse/WEEX-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577789#comment-16577789 ] ASF GitHub Bot commented on WEEX-559: - wqyfavor opened a new pull request #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil… URL: https://github.com/apache/incubator-weex/pull/1420 …y created scrollview. First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resend handleAppear for lazily created scrollview > - > > Key: WEEX-559 > URL: https://issues.apache.org/jira/browse/WEEX-559 > Project: Weex > Issue Type: Bug > Components: iOS >Affects Versions: 0.19 >Reporter: Wang Qianyuan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] wqyfavor opened a new pull request #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil…
wqyfavor opened a new pull request #1420: [WEEX-559][iOS]Fix issue that handleAppear should be resent for lazil… URL: https://github.com/apache/incubator-weex/pull/1420 …y created scrollview. First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-559) Resend handleAppear for lazily created scrollview
Wang Qianyuan created WEEX-559: -- Summary: Resend handleAppear for lazily created scrollview Key: WEEX-559 URL: https://issues.apache.org/jira/browse/WEEX-559 Project: Weex Issue Type: Bug Components: iOS Affects Versions: 0.19 Reporter: Wang Qianyuan Assignee: XuYouyang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-weex-site pull request #184: Update loading.md
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex-site/pull/184 ---
[jira] [Commented] (WEEX-558) 使用自定义字体时android端存在语法兼容性问题
[
https://issues.apache.org/jira/browse/WEEX-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577611#comment-16577611
]
ASF GitHub Bot commented on WEEX-558:
-
weex-bot commented on issue #1419: [WEEX-558][Android] Font file url compatible
with ' and "
URL: https://github.com/apache/incubator-weex/pull/1419#issuecomment-412348505
Warnings
:warning:
No Changelog changes!
Messages
:book:
danger test finished.
Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 使用自定义字体时android端存在语法兼容性问题
> -
>
> Key: WEEX-558
> URL: https://issues.apache.org/jira/browse/WEEX-558
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.18, 0.19
>Reporter: billy
>Assignee: YorkShen
>Priority: Major
> Attachments: fontFamily未生效.jpeg
>
>
> 按照[官方文档|http://weex.apache.org/cn/references/modules/dom.html#addrule-type-contentobject-v0-12-0]，使用自定义fontFace可通过domModule.addRule来实现，示例如下：
> {code:java}
> domModule.addRule('fontFace', {
> 'fontFamily': "iconfont2",
> 'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
> })
> {code}
> 文档中给出的示例中，src对应的字体文件路径字符串的定义是由{color:#FF}外部双引号{color}和{color:#FF}内部单引号{color}构成
> 但这种写法会被提示字符串要使用单引号，但{color:#FF}改成外部单引号内部双引号后，在android端字体未生效{color}
> 复现页面： [http://dotwe.org/vue/eb11eb2ce81d936c8978439df027c66b]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-558) 使用自定义字体时android端存在语法兼容性问题
[
https://issues.apache.org/jira/browse/WEEX-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577612#comment-16577612
]
ASF GitHub Bot commented on WEEX-558:
-
weex-bot edited a comment on issue #1419: [WEEX-558][Android] Font file url
compatible with ' and "
URL: https://github.com/apache/incubator-weex/pull/1419#issuecomment-412348505
Messages
:book:
has no jsfm file changed.
:book:
jsfm test finished.
Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 使用自定义字体时android端存在语法兼容性问题
> -
>
> Key: WEEX-558
> URL: https://issues.apache.org/jira/browse/WEEX-558
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.18, 0.19
>Reporter: billy
>Assignee: YorkShen
>Priority: Major
> Attachments: fontFamily未生效.jpeg
>
>
> 按照[官方文档|http://weex.apache.org/cn/references/modules/dom.html#addrule-type-contentobject-v0-12-0]，使用自定义fontFace可通过domModule.addRule来实现，示例如下：
> {code:java}
> domModule.addRule('fontFace', {
> 'fontFamily': "iconfont2",
> 'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
> })
> {code}
> 文档中给出的示例中，src对应的字体文件路径字符串的定义是由{color:#FF}外部双引号{color}和{color:#FF}内部单引号{color}构成
> 但这种写法会被提示字符串要使用单引号，但{color:#FF}改成外部单引号内部双引号后，在android端字体未生效{color}
> 复现页面： [http://dotwe.org/vue/eb11eb2ce81d936c8978439df027c66b]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1419: [WEEX-558][Android] Font file url compatible with ' and "
weex-bot edited a comment on issue #1419: [WEEX-558][Android] Font file url compatible with ' and " URL: https://github.com/apache/incubator-weex/pull/1419#issuecomment-412348505 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-558) 使用自定义字体时android端存在语法兼容性问题
[
https://issues.apache.org/jira/browse/WEEX-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577610#comment-16577610
]
ASF GitHub Bot commented on WEEX-558:
-
luckybilly opened a new pull request #1419: [WEEX-558][Android] Font file url
compatible with ' and "
URL: https://github.com/apache/incubator-weex/pull/1419
issue: https://issues.apache.org/jira/browse/WEEX-558
use costumer fontFace like this:
```
const domModule = weex.requireModule('dom')
domModule.addRule('fontFace', {
'fontFamily': "iconfont2",
'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
})
```
double quotes is outside for font file url, it will make an error with lint.
when set as this, the font face does not work with android:
```
'src': 'url("http://at.alicdn.com/t/font_1469606063_76593.ttf;)'
```
it cause by
[FontDO](https://github.com/apache/incubator-weex/blob/master/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java#76)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 使用自定义字体时android端存在语法兼容性问题
> -
>
> Key: WEEX-558
> URL: https://issues.apache.org/jira/browse/WEEX-558
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.18, 0.19
>Reporter: billy
>Assignee: YorkShen
>Priority: Major
> Attachments: fontFamily未生效.jpeg
>
>
> 按照[官方文档|http://weex.apache.org/cn/references/modules/dom.html#addrule-type-contentobject-v0-12-0]，使用自定义fontFace可通过domModule.addRule来实现，示例如下：
> {code:java}
> domModule.addRule('fontFace', {
> 'fontFamily': "iconfont2",
> 'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
> })
> {code}
> 文档中给出的示例中，src对应的字体文件路径字符串的定义是由{color:#FF}外部双引号{color}和{color:#FF}内部单引号{color}构成
> 但这种写法会被提示字符串要使用单引号，但{color:#FF}改成外部单引号内部双引号后，在android端字体未生效{color}
> 复现页面： [http://dotwe.org/vue/eb11eb2ce81d936c8978439df027c66b]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] weex-bot commented on issue #1419: [WEEX-558][Android] Font file url compatible with ' and "
weex-bot commented on issue #1419: [WEEX-558][Android] Font file url compatible with ' and " URL: https://github.com/apache/incubator-weex/pull/1419#issuecomment-412348505 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luckybilly opened a new pull request #1419: [WEEX-558][Android] Font file url compatible with ' and "
luckybilly opened a new pull request #1419: [WEEX-558][Android] Font file url
compatible with ' and "
URL: https://github.com/apache/incubator-weex/pull/1419
issue: https://issues.apache.org/jira/browse/WEEX-558
use costumer fontFace like this:
```
const domModule = weex.requireModule('dom')
domModule.addRule('fontFace', {
'fontFamily': "iconfont2",
'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
})
```
double quotes is outside for font file url, it will make an error with lint.
when set as this, the font face does not work with android:
```
'src': 'url("http://at.alicdn.com/t/font_1469606063_76593.ttf;)'
```
it cause by
[FontDO](https://github.com/apache/incubator-weex/blob/master/android/sdk/src/main/java/com/taobao/weex/utils/FontDO.java#76)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (WEEX-558) 使用自定义字体时android端存在语法兼容性问题
[
https://issues.apache.org/jira/browse/WEEX-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
billy updated WEEX-558:
---
Attachment: fontFamily未生效.jpeg
> 使用自定义字体时android端存在语法兼容性问题
> -
>
> Key: WEEX-558
> URL: https://issues.apache.org/jira/browse/WEEX-558
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.18, 0.19
>Reporter: billy
>Assignee: YorkShen
>Priority: Major
> Attachments: fontFamily未生效.jpeg
>
>
> 按照[官方文档|http://weex.apache.org/cn/references/modules/dom.html#addrule-type-contentobject-v0-12-0]，使用自定义fontFace可通过domModule.addRule来实现，示例如下：
> {code:java}
> domModule.addRule('fontFace', {
> 'fontFamily': "iconfont2",
> 'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
> })
> {code}
> 文档中给出的示例中，src对应的字体文件路径字符串的定义是由{color:#FF}外部双引号{color}和{color:#FF}内部单引号{color}构成
> 但这种写法会被提示字符串要使用单引号，但{color:#FF}改成外部单引号内部双引号后，在android端字体未生效{color}
> 复现页面： [http://dotwe.org/vue/eb11eb2ce81d936c8978439df027c66b]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (WEEX-558) 使用自定义字体时android端存在语法兼容性问题
billy created WEEX-558:
--
Summary: 使用自定义字体时android端存在语法兼容性问题
Key: WEEX-558
URL: https://issues.apache.org/jira/browse/WEEX-558
Project: Weex
Issue Type: Bug
Components: Android
Affects Versions: 0.19, 0.18
Reporter: billy
Assignee: YorkShen
按照[官方文档|http://weex.apache.org/cn/references/modules/dom.html#addrule-type-contentobject-v0-12-0]，使用自定义fontFace可通过domModule.addRule来实现，示例如下：
{code:java}
domModule.addRule('fontFace', {
'fontFamily': "iconfont2",
'src': "url('http://at.alicdn.com/t/font_1469606063_76593.ttf')"
})
{code}
文档中给出的示例中，src对应的字体文件路径字符串的定义是由{color:#FF}外部双引号{color}和{color:#FF}内部单引号{color}构成
但这种写法会被提示字符串要使用单引号，但{color:#FF}改成外部单引号内部双引号后，在android端字体未生效{color}
复现页面： [http://dotwe.org/vue/eb11eb2ce81d936c8978439df027c66b]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
