Re: About the framework type annotation

2017-12-11 Thread Hanks Zhang
I think we could take three steps to get the framework type of a js bundle. 1. Parse the URL params, use a special key to specify the framework type. This will skip the string parsing and save time. 2. Parse the "use weex:vue" or "use weex:rax" in the code string. 3. Parse the // { "Framework":

Re: About the framework type annotation

2017-12-11 Thread Adam Feng
Is there any way to avoid string parsing, for example, get framework type from returning value while executing the bundle? Thanks. Adam Feng On 11 Dec 2017, 4:12 PM +0800, Hanks Zhang , wrote: > The "framework type annotation" is a special syntax written in js bundle to >

Re: About the framework type annotation

2017-12-11 Thread Jonathan Dong
It looks good to me. // { “framework”: “Vue/Rax” } looks tricky, and we cannot add license disclaimer before it. One question, how do we handle the backward compatibility issue? On 11 Dec 2017, at 4:12 PM, Hanks Zhang > wrote:

About the framework type annotation

2017-12-11 Thread Hanks Zhang
The "framework type annotation" is a special syntax written in js bundle to indicate which framework it is using, such as Vue and Rax. Refer to its document [1] the annotation looks like: // { "framework": "Vue" } or // { "framework": "Rax" } It's comment with special format actually,