Re: More flexible Panel, Fragment, etc.

2011-01-13 Thread Daniel Soneira
Since the release vote for 1.5 RC1 has started I guess that means this feature will unfortunately not make it into 1.5? Regards, Daniel Soneira On 10.01.2011 02:09, Igor Vaynberg wrote: i really like this. lets commit it. a couple of notes below:

Re: More flexible Panel, Fragment, etc.

2011-01-13 Thread Martijn Dashorst
On Thu, Jan 13, 2011 at 11:42 AM, Daniel Soneira daniel.sone...@joyn-it.at wrote: Since the release vote for 1.5 RC1 has started I guess that means this feature will unfortunately not make it into 1.5? According to

Re: [vote] release wicket-1.5-rc1

2011-01-13 Thread Craig Tataryn
+1 (non binding) - looks good On 2011-01-13, at 1:20 AM, Igor Vaynberg wrote: this vote is to release wicket 1.5-rc1. the trunk has been stable for a while without any major bugs found. the api has also stabilized nicely. it is time for rc1. branch:

Re: More flexible Panel, Fragment, etc.

2011-01-13 Thread Juergen Donnerstag
An initial version went into rc1 though we are still discussing minor changes. The API might change slighty. -Juergen On Thu, Jan 13, 2011 at 11:49 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Thu, Jan 13, 2011 at 11:42 AM, Daniel Soneira daniel.sone...@joyn-it.at wrote: Since

Re: More flexible Panel, Fragment, etc.

2011-01-13 Thread Daniel Soneira
I'm pleased to see this feature included. 1.5 will rock! Cheers, Daniel On 13.01.2011 19:13, Juergen Donnerstag wrote: An initial version went into rc1 though we are still discussing minor changes. The API might change slighty. -Juergen On Thu, Jan 13, 2011 at 11:49 AM, Martijn Dashorst

Re: [vote] release wicket-1.5-rc1

2011-01-13 Thread Major Péter
Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330 sounds more serious to me. Best regards, Peter 2011-01-13 08:20 keltezéssel, Igor Vaynberg írta: this vote is to

Re: [vote] release wicket-1.5-rc1

2011-01-13 Thread Juergen Donnerstag
could we please add testcases if applicable. thanks. Juergen 2011/1/13 Major Péter majorpe...@sch.bme.hu: Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330

Re: Display component feedback message once: safety net renders them always before

2011-01-13 Thread Jeremy Thomerson
On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog,

Re: Display component feedback message once: safety net renders them always before

2011-01-13 Thread Clint Checketts
I'd like to see it in core! On Thu, Jan 13, 2011 at 2:19 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a

Re: [vote] release wicket-1.5-rc1

2011-01-13 Thread Igor Vaynberg
here is a binding -1 to close this officially. -igor 2011/1/13 Major Péter majorpe...@sch.bme.hu: Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330 sounds more

Re: Display component feedback message once: safety net renders them always before

2011-01-13 Thread Igor Vaynberg
if you put two of them on a page do you get an infinite loop? :) -igor On Thu, Jan 13, 2011 at 12:19 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my

Re: [vote] release wicket-1.5-rc1

2011-01-13 Thread James Carman
Releases can't be vetoed but it is good to see a binding -1 vote. Just call the vote cancelled because there was a problem identified On Jan 13, 2011 9:26 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: here is a binding -1 to close this officially. -igor 2011/1/13 Major Péter

Re: Display component feedback message once: safety net renders them always before

2011-01-13 Thread James Carman
It's like crossing the streams on Ghostbusters. Just don't do it. :) On Jan 13, 2011 9:27 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: if you put two of them on a page do you get an infinite loop? :) -igor On Thu, Jan 13, 2011 at 12:19 PM, Jeremy Thomerson jer...@wickettraining.com

Re: Display component feedback message once: safety net renders them always before

2011-01-13 Thread Jeremy Thomerson
Nah - it could throw an IFoundMyTwinException - except the leading I might make someone think that it was an interface! On Thu, Jan 13, 2011 at 8:26 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: if you put two of them on a page do you get an infinite loop? :) -igor On Thu, Jan 13, 2011 at

Re: Display component feedback message once: safety net rendersthem always before

2011-01-13 Thread mbosteels . dns
+1 for adding to core (non-binding) --Original Message-- From: Jeremy Thomerson To: Wicket Development ReplyTo: dev@wicket.apache.org Subject: Re: Display component feedback message once: safety net rendersthem always before Sent: Jan 13, 2011 21:19 On Tue, Jan 4, 2011 at 10:13 AM,