Hi Sven,
The component tree rebuilding adds CPU time :-|
I guess most of the applications would still prefer the current approach
with the manual construction of the tree in Java land.
Even worse - the rebuilding is needed few times:
- once before calling Page#onInitialize() so all enqueued
http://blog.jetbrains.com/idea/2014/01/intellij-idea-13-importing-code-formatter-settings-from-eclipse/
Martin Grigorov
Wicket Training and Consulting
On Wed, Jan 29, 2014 at 10:42 AM, Sven Meier s...@meiers.net wrote:
I've just recreated EclipseCodeFormat.xml from our old Eclipse's settings
public class PropertyColumnT, S extends AbstractColumnT, S implements
IExportableColumnT, S, Object
{
...
/**
* Factory method for generating a model that will generated the displayed
value. Typically the
* model is a property model using the {@link #propertyExpression}
specified in the
It looks like an error.
On Fri, Jan 31, 2014 at 1:44 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
public class PropertyColumnT, S extends AbstractColumnT, S implements
IExportableColumnT, S, Object
{
...
/**
* Factory method for generating a model that will generated the
Hi,
What others think about https://issues.apache.org/jira/browse/WICKET-5459 ?
Should Wicket use return this pattern where makes sense instead of 'void'
return type ?
One problem that I see is with:
MyPage.doSomething() will/may return some base type of MyPage.
I remember some trink for Java to
I personally like chaining in Wicket
On Fri, Jan 31, 2014 at 9:08 PM, Martin Grigorov mgrigo...@apache.orgwrote:
Hi,
What others think about https://issues.apache.org/jira/browse/WICKET-5459?
Should Wicket use return this pattern where makes sense instead of 'void'
return type ?
One
I like chaining for instances. I don't see much use for chaining in static
methods.
On Fri, Jan 31, 2014 at 3:12 PM, Maxim Solodovnik solomax...@gmail.comwrote:
I personally like chaining in Wicket
On Fri, Jan 31, 2014 at 9:08 PM, Martin Grigorov mgrigo...@apache.org
wrote:
Hi,
What
I don't think it makes sense here:
In all of Wicket's code there's a single place only, where two metaData
entries are set consecutively.
Sven
On 01/31/2014 03:08 PM, Martin Grigorov wrote:
Hi,
What others think about https://issues.apache.org/jira/browse/WICKET-5459 ?
Should Wicket use
I ask generally, not just about #setMetaData().
For example:
someComponent.add(behavior).add(child).setVisible(false).setEnabled(false).setMetaData(..)
...
And not just about Component class but everywhere where it makes sense.
Martin Grigorov
Wicket Training and Consulting
On Fri, Jan 31, 2014
Java should natively chain all void instance methods...
**
Martin
2014-01-31 Sven Meier s...@meiers.net
I don't think it makes sense here:
In all of Wicket's code there's a single place only, where two metaData
entries are set consecutively.
Sven
On 01/31/2014 03:08 PM, Martin Grigorov
Which would be perfectly fine if the JVM told you which specific method
invocation on a source code line with chained methods threw an exception.
While you can sometimes figure it out, you can't always, and an answer of
if it happens again, we'll know how to fix it just doesn't fly in certain
On Fri, Jan 31, 2014 at 4:15 PM, Nick Pratt nbpr...@gmail.com wrote:
Which would be perfectly fine if the JVM told you which specific method
invocation on a source code line with chained methods threw an exception.
While you can sometimes figure it out, you can't always, and an answer of
if
It looks like this is not very aptly named according to the JavaDoc...
According to the JavaDoc AjaxAttributes#isPreventDefault() should:
return true if the default event handler should be invoked, false
otherwise.
However, the name prevent default implies the other way around!
So instead
+1 to keep the old API deprecated for one release if possible (as in this
case)
recently I thought that it'd be better to keep MountMapper and Co.
deprecated in 7.x. Wicket doesn't use them but some app may ...
Martin Grigorov
Wicket Training and Consulting
On Fri, Jan 31, 2014 at 4:26 PM,
Making 'void' methods return 'this' doesn't prevent you to write each call
in a new line. But gives others the choice to call it inline.
It could be a problem if Wicket's internal code used chaining extensively,
but I find it very convenient to chain calls, specially when building the
component
Just to be clear - I'm not arguing against the concept of method chaining
because of some stylistic / personal preference point, but from a practical
production diagnostic point, when you need to be able to definitively fix
the problem once, and once only. Pushing a temporary release out with
Is my assessment that the semantics of isPreventDefault() and
isAllowDefault() can be explained as:
public boolean isPreventDefault() {
return !isAllowDefault();
}
?
Martijn
On Fri, Jan 31, 2014 at 4:32 PM, Martin Grigorov mgrigo...@apache.orgwrote:
+1 to keep the old API deprecated for
Yes.
I'd write it the other way around though.
I.e. the member variable will be 'preventDefault' as now:
public boolean isPreventDefault() {
return preventDefault;
}
@Deprecated
public boolean isAllowDefault() {
return !preventDefault;
}
Martin Grigorov
Wicket Training and Consulting
+1
-igor
On Thu, Jan 30, 2014 at 5:00 AM, Martin Grigorov mgrigo...@apache.orgwrote:
This vote is to release Apache Wicket 1.4.22
Git repo
http://git-wip-us.apache.org/repos/asf/wicket.git
Branch name
build/wicket-1.4.22
Archived and signed Git repo
Hi,
I' facing a very weird problem with Wicket 6.13.0. Some stateless forms
has stopped to submit their value when we upgraded our app to this
version. I tracked down the commit that is responsable for this problem
and is the one related to the issue in the object. If I modify the Page
class
+1
+1
-igor
On Thu, Jan 30, 2014 at 5:00 AM, Martin Grigorov mgrigo...@apache.orgwrote:
This vote is to release Apache Wicket 1.4.22
Git repo
http://git-wip-us.apache.org/repos/asf/wicket.git
Branch name
build/wicket-1.4.22
Archived and signed Git repo
21 matches
Mail list logo
