RE: Decommission of wicket-datetime

2015-02-06 Thread Burton, Tom F (DOR)
Decommissioning is probably a good thing. I know I sometimes get confused between extensions/dateTime as to which one I'm using. But IIRC extensions uses java.util.date and datetime uses joda. How are you going to rectify that part of the merge? Thanks, Tom Burton -Original

[GitHub] wicket pull request: WICKET-5828 PageProvider not serializable

2015-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] wicket pull request: WICKET-5828 PageProvider not serializable

2015-02-06 Thread martin-g
Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/89#issuecomment-73305327 Thank you, Tobias! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] wicket pull request: WICKET-5828 PageProvider not serializable

2015-02-06 Thread klopfdreh
GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/89 WICKET-5828 PageProvider not serializable You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket WICKET-5828 Alternatively you can

Re: Decommission of wicket-datetime

2015-02-06 Thread Maxim Solodovnik
I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move

Re: Decommission of wicket-datetime

2015-02-06 Thread Martin Grigorov
Please be more detailed when you have to say something. Which classes ? Why do you want to keep them around ? Such minor useful things. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 6, 2015 at 1:45 PM, Maxim Solodovnik solomax...@gmail.com

Re: Decommission of wicket-datetime

2015-02-06 Thread Andrea Del Bene
I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM,

Re: Decommission of wicket-datetime

2015-02-06 Thread Andrea Del Bene
Yes of course :) ... and move the remaining YUI packages to wicketstuff-yui ? Sven On 06.02.2015 16:22, Andrea Del Bene wrote: I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove:

Re: Decommission of wicket-datetime

2015-02-06 Thread Sven Meier
... and move the remaining YUI packages to wicketstuff-yui ? Sven On 06.02.2015 16:22, Andrea Del Bene wrote: I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove:

Re: Decommission of wicket-datetime

2015-02-06 Thread Andrea Del Bene
Those who are not inside org.apache.wicket.extensions.yui :-). Five classes: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java

Re: Decommission of wicket-datetime

2015-02-06 Thread Maxim Solodovnik
I agree Additionally wicket-jquery-ui extends DateTextField to provide date picker On Fri, Feb 6, 2015 at 6:56 PM, Andrea Del Bene an.delb...@gmail.com wrote: Those who are not inside org.apache.wicket.extensions.yui :-). Five classes: /wicket-datetime/src/main/java/org/apache/wicket/

Re: Decommission of wicket-datetime

2015-02-06 Thread Sven Meier
Hi Andrea, IMHO the components belong into wicket-extensions. Note that we already have a DateTextField there. Regards Sven On 06.02.2015 13:56, Andrea Del Bene wrote: Those who are not inside org.apache.wicket.extensions.yui :-). Five classes:

Re: Decommission of wicket-datetime

2015-02-06 Thread Sebastien
Hi devs, Actually Wicket jQuery UI's DatePicker extends org.apache.wicket. *extensions*.markup.html.form.DateTextField By the way, Wicket Utils already have org.apache.wicket.*util*.convert.converter.DateConverter. I did not check the differences.. DateLabel PatternDateConverter are probably

Re: Decommission of wicket-datetime

2015-02-06 Thread Andrea Del Bene
I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java Move to wicket-utils: /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java