Correct! :-)
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Feb 23, 2015 at 12:36 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
On Sun, Feb 22, 2015 at 9:27 PM, Martin Grigorov mgrigo...@apache.org
wrote:
Martijn,
quick quiz: do you
GitHub user duesenklipper opened a pull request:
https://github.com/apache/wicket/pull/99
WICKET-5749 add AuthorizeResource to auth-roles so Resources can be prot...
WICKET-5749 add AuthorizeResource to auth-roles so Resources can be
protected too.
Also cleaned up and
On Sun, Feb 22, 2015 at 9:27 PM, Martin Grigorov mgrigo...@apache.org wrote:
Martijn,
quick quiz: do you know/remember what IClusterable was created for ? :-)
Yup: for Terracotta integration to make it easier to identify objects
that should be clustered.
Martijn
On Sun, Feb 22, 2015 at
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r25233381
--- Diff:
wicket-auth-roles/src/test/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategyTest.java
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/99#issuecomment-75711898
LGTM!
Just small nitpicks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r25233416
--- Diff:
wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategy.java
---
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r2520
--- Diff:
wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategy.java
---
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r2522
--- Diff:
wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AuthorizeResource.java
---
@@ -0,0 +1,42 @@
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/99#discussion_r25233348
--- Diff:
wicket-auth-roles/src/test/java/org/apache/wicket/authroles/authorization/strategies/role/annotations/AnnotationsRoleAuthorizationStrategyTest.java
