Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Tobias Soloschenko
Then +1 to drop it. :-) kind regards Tobias Am 20.04.2015 um 13:31 schrieb Martin Grigorov mgrigo...@apache.org: Hi, On Mon, Apr 20, 2015 at 12:42 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi, Ok this solution sounds good to me: * Flag for info / error *

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Martin Grigorov
On Mon, Apr 20, 2015 at 2:45 PM, Nick Pratt nbpr...@gmail.com wrote: One of the most helpful features of the debug window is the red flashing indication when there's an error detected by Wicket. For newer Wicket Good point! This is a good reason to have wicket-ajax-debug-jquery.js around. Or

[discuss] Ability to not submitting a nested form

2015-04-20 Thread Sebastien
Hi devs, I have a recurrent use case where I need to prevent a nested form to be processed/validated/submitted. There is already some conditions that could achieve this (Form#isEnabledInHierarchy or #isVisibleInHierarchy), but it does not suit well in case of a component/widget which is

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Martin Grigorov
Hi, On Mon, Apr 20, 2015 at 12:42 PM, Tobias Soloschenko tobiassolosche...@googlemail.com wrote: Hi, Ok this solution sounds good to me: * Flag for info / error * Log into console * Ajax Response via Network Tab in Browsers Thanks for your explanations! :-) One little question: what

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Martijn Dashorst
On Mon, Apr 20, 2015 at 2:06 PM, Martin Grigorov mgrigo...@apache.org wrote: developers, this is invaluable since they dont know to constantly look at the server console. It would be great if that could be expanded to included indications of other server side errors ( such as serialization

Re: [discuss] Ability to not submitting a nested form

2015-04-20 Thread Sebastien
Is there any reason why the #wantSubmitOnXyz() methods should be public and not protected? I prefer to be protected too, but as #wantSubmitOnNestedFormSubmit was public, I aligned on that. On Mon, Apr 20, 2015 at 2:53 PM, Martin Grigorov mgrigo...@apache.org wrote: Hi, Looks OK to me.

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Martin Grigorov
Hi, I suggest to drop the debug window with Wicket 8.x. So you all will have some time to get used with the console until then :-) Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Apr 20, 2015 at 2:07 PM, Sebastien seb...@gmail.com wrote: Same answer as

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Nick Pratt
One of the most helpful features of the debug window is the red flashing indication when there's an error detected by Wicket. For newer Wicket developers, this is invaluable since they dont know to constantly look at the server console. It would be great if that could be expanded to included

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Sven Meier
I'm still using the debug window, but the browser's console should do fine too. Sven On 20.04.2015 09:05, Martin Grigorov wrote: Hi Tobias, The debug api of wicket-ajax-jquery.js is: Wicket.Log.(info|error). If the debug window is enabled then both methods log in the debug window and in the

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Sebastien
Same answer as Sven, I will switch to browser's console to see if it's convenient as well.. On Mon, Apr 20, 2015 at 12:59 PM, Sven Meier s...@meiers.net wrote: I'm still using the debug window, but the browser's console should do fine too. Sven On 20.04.2015 09:05, Martin Grigorov wrote:

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Martin Grigorov
Hi Tobias, The debug api of wicket-ajax-jquery.js is: Wicket.Log.(info|error). If the debug window is enabled then both methods log in the debug window and in the JS window.console. If the debug window is disabled then only Wicket.Log.error is enabled and logs in the JS window.console. IMO we

Re: Wicket Ajax debug window usefulness?

2015-04-20 Thread Tobias Soloschenko
Hi, Ok this solution sounds good to me: * Flag for info / error * Log into console * Ajax Response via Network Tab in Browsers Thanks for your explanations! :-) One little question: what about IE6? There is no console object available - do you mind to drop the support for that browser in

Re: [discuss] Ability to not submitting a nested form

2015-04-20 Thread Sebastien
Hi, By doing the Unit Test, I realized that a *middle* form having #wantSubmitOnParentFormSubmit false did not prevent an *inner* form from being submitted (*outer* is being submitted in this case) The problem is in #delegateSubmit which uses a visitPostOrder (inner to outer), so we cannot stop

Re: [discuss] Ability to not submitting a nested form

2015-04-20 Thread Carl-Eric Menzel
I added it, yes. I don't see any public references to it, and I can't think of any uses for it either. Protected should be fine, as far as I can tell. It was probably just an oversight to make it public in the first place. Carl-Eric On Mon, 20 Apr 2015 15:53:23 +0300 Martin Grigorov