Add IFallback marker interface to AjaxFallback* components

2015-05-06 Thread Martijn Dashorst
The WicketTester has a click method that doesn't detect all AJAX capable links (e.g. the Ajax links in the AjaxPagingNavigator are not testable). When trying to fix this by adding support for IAjaxLink, I noticed that we also don't support AjaxFallbackButton, and probably a lot more components.

Re: Add IFallback marker interface to AjaxFallback* components

2015-05-06 Thread Tobias Soloschenko
I would prefer the interface because Wicket 6 / 7 users should also see that components are not supported. kind regards Tobias Am 06.05.2015 um 11:03 schrieb Martijn Dashorst martijn.dasho...@gmail.com: The WicketTester has a click method that doesn't detect all AJAX capable links (e.g.

Re: Add IFallback marker interface to AjaxFallback* components

2015-05-06 Thread Martin Grigorov
On May 6, 2015 3:10 PM, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Wed, May 6, 2015 at 1:35 PM, Martin Grigorov mgrigo...@apache.org wrote: +1 to introduce IFallback I don't understand how Optional could help for this use case Change the onClick signature (perhaps only for

Re: wicket git commit: Added WicketTester support for IAjaxLink

2015-05-06 Thread Martin Grigorov
Hi, On Wed, May 6, 2015 at 12:25 PM, dasho...@apache.org wrote: Repository: wicket Updated Branches: refs/heads/wicket-6.x e4c1d939f - 0199bfab7 Added WicketTester support for IAjaxLink WicketTester didn't click direct IAjaxLink implementations using an Ajax request but a normal

Re: Add IFallback marker interface to AjaxFallback* components

2015-05-06 Thread Martijn Dashorst
On Wed, May 6, 2015 at 1:35 PM, Martin Grigorov mgrigo...@apache.org wrote: +1 to introduce IFallback I don't understand how Optional could help for this use case Change the onClick signature (perhaps only for Ajax fallback components): public void onClick(OptionalAjaxRequestTarget target) {

Re: Migration to 7 report

2015-05-06 Thread Guillaume Smet
On Mon, May 4, 2015 at 9:26 PM, Martin Grigorov mgrigo...@apache.org wrote: What's wrong with 'instanceof'+casting? Nothing, except it's more verbose. I'll go do that. I was wondering if it might be worth it to add a way to define the error keys with a setter of PatternValidator. We usually

Re: Add IFallback marker interface to AjaxFallback* components

2015-05-06 Thread Martin Grigorov
+1 to introduce IFallback I don't understand how Optional could help for this use case On Wed, May 6, 2015 at 12:03 PM, Martijn Dashorst martijn.dasho...@gmail.com wrote: The WicketTester has a click method that doesn't detect all AJAX capable links (e.g. the Ajax links in the

[wicketstuff] Can't we get rid of the distinction between JDK-versions on the folder level?

2015-05-06 Thread Joachim Rohde
Hi, As I already mentioned the other day I was porting some changes from master branch to the wicket-6.x branch (http://apache-wicket.1842946.n4.nabble.com/wicketstuff-Need-help-with-cherry-picking-td4670615.html) and had some trouble doing so, since Git was not able to cherry-pick my changes