Re: buildbot failure in ASF Buildbot on wicket-master

2015-06-24 Thread Martin Grigorov
It seems I've forgot to press the Release button for wicket-webjars:0.5.2 last night. It is hurrying from Sonatype to Maven Central now. Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Jun 24, 2015 at 11:38 AM,

WICKET-5904 followup aka issues with enclosures with M6

2015-06-24 Thread Guillaume Smet
Hi, We deployed our first applications using 7.0.0-M6 in production yesterday and we started to see the following 2 exceptions in our logs: == java.lang.IllegalArgumentException: Argument 'markup' may not be null. at

Re: Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread Martin Grigorov
Yes, the problems came with the work for component queueing. I guess at some point someone will be able to reproduce the problem in a quickstart and we will be able to debug and fix it. Until then use the better solution (EnclosureContainer). Martin Grigorov Freelancer. Available for hire!

[GitHub] wicket pull request: IoC: Optionally use objensis for proxy creati...

2015-06-24 Thread selckin
Github user selckin commented on a diff in the pull request: https://github.com/apache/wicket/pull/114#discussion_r33139451 --- Diff: wicket-guice/src/main/java/org/apache/wicket/guice/GuiceFieldValueFactory.java --- @@ -64,15 +68,34 @@ public Object getFieldValue(final Field

Re: WICKET-5904 followup aka issues with enclosures with M6

2015-06-24 Thread Guillaume Smet
Nothing really fancy except for a transparent markup at the top of the page and a wicket:enclosure. I can't reproduce it, I just see the problem in the logs. I'm starting to wonder if there is a concurrency issue somewhere (same question I asked in my other post). On Wed, Jun 24, 2015 at 1:12

[GitHub] wicket pull request: IoC: Optionally use objensis for proxy creati...

2015-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread Martin Grigorov
EnclosureContainer FTW! P.S. I know the above is not very useful but I'm preaching against (Inline)Enclosure for few years now :-) Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Jun 24, 2015 at 12:48 PM, Guillaume Smet

Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread Guillaume Smet
Hi, In production, yesterday, I had a very disturbing bug with an enclosure (the wicket:enclosure tag): the content of the enclosure was displayed even if the child was not visible (and the child was indeed not visible in the page). I switched to using an EnclosureContainer and redeployed the

Re: WICKET-5904 followup aka issues with enclosures with M6

2015-06-24 Thread andrea del bene
No bell rung yet :-). Could you provide some more details about page's components hierarchy? On 24/06/2015 11:26, Guillaume Smet wrote: Hi, We deployed our first applications using 7.0.0-M6 in production yesterday and we started to see the following 2 exceptions in our logs:

Re: Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread Guillaume Smet
I think I have reproduced it locally but it's intermittent and really weird. I can't get a way to reproduce it each time. Is there a shared state between pages regarding the enclosures or the component queueing (I mean for a given page class but different page parameters)? On Wed, Jun 24, 2015

[GitHub] wicket pull request: IoC: Optionally use objensis for proxy creati...

2015-06-24 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/114#discussion_r33138716 --- Diff: wicket-guice/src/main/java/org/apache/wicket/guice/GuiceFieldValueFactory.java --- @@ -64,15 +68,34 @@ public Object getFieldValue(final Field

[GitHub] wicket pull request: IoC: Optionally use objensis for proxy creati...

2015-06-24 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/114#discussion_r33141370 --- Diff: wicket-guice/src/main/java/org/apache/wicket/guice/GuiceFieldValueFactory.java --- @@ -64,15 +68,34 @@ public Object getFieldValue(final Field

Re: Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread Guillaume Smet
On Wed, Jun 24, 2015 at 11:57 AM, Martin Grigorov mgrigo...@apache.org wrote: EnclosureContainer FTW! P.S. I know the above is not very useful but I'm preaching against (Inline)Enclosure for few years now :-) Yeah, we only use it for very simple cases and we use EnclosureContainer for

Re: Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread Martin Grigorov
org.apache.wicket.markup.parser.filter.EnclosureHandler this is the shared state It is both a IMarkupFilter (an application singleton) and IComponentResolver (resolves components for wicket:enclosure) Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting

Re: Weird enclosure bug with 7.0.0-M6

2015-06-24 Thread andrea del bene
Great! Could you share the code to investigate it? Thank you. On 24/06/2015 14:39, Guillaume Smet wrote: I think I have reproduced it locally but it's intermittent and really weird. I can't get a way to reproduce it each time. Is there a shared state between pages regarding the enclosures or

[GitHub] wicket pull request: WICKET-5926 - Arquillian Java EE 6 Support wi...

2015-06-24 Thread martin-g
Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/129#issuecomment-114870115 It seems your branch is too far from current master. I have problems to merge it locally. Could you please rebase it and probably squash your commits into one?

[GitHub] wicket pull request: WICKET-5935: Guice IoC: cache proxies fail ...

2015-06-24 Thread selckin
GitHub user selckin opened a pull request: https://github.com/apache/wicket/pull/130 WICKET-5935: Guice IoC: cache proxies fail fast - cache proxies in the same way the spring ioc caches them - If a bean has no binding the exception is now throw on construction instead

[GitHub] wicket pull request: WICKET-5926 - Arquillian Java EE 6 Support wi...

2015-06-24 Thread felipecalmeida
Github user felipecalmeida commented on the pull request: https://github.com/apache/wicket/pull/129#issuecomment-114936935 Sure! I don't know how to do and I'm learning right now. My first time doing a rebase. Just a minute or two. --- If your project is set up for it, you can

[GitHub] wicket pull request: WICKET-5926 - Arquillian Java EE 6 Support wi...

2015-06-24 Thread felipecalmeida
Github user felipecalmeida commented on the pull request: https://github.com/apache/wicket/pull/129#issuecomment-114941925 I think I did as expected. I hope. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your