Re: [DISCUSSION] WICKET-6544 mobile browser detection

2018-04-03 Thread Martin Grigorov
+1 for 2) from me Martin Grigorov Wicket Training and Consulting Looking for a remote position with Wicket ? Contact me! https://twitter.com/mtgrigorov On Tue, Apr 3, 2018 at 5:34 PM, Maxim Solodovnik wrote: > It seems the discussion is spread between this thread and the

[DISCUSSION] Wicket 8 Release

2018-04-03 Thread Maxim Solodovnik
Hello All, I believe it is time to release :) Do we have any blockers? Some non-technical blockers should be already resolved :))) -- WBR Maxim aka solomax

Re: [DISCUSSION] WICKET-6544 mobile browser detection

2018-04-03 Thread Maxim Solodovnik
It seems the discussion is spread between this thread and the JIRA https://issues.apache.org/jira/browse/WICKET-6544?focusedCommentId=16423835=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16423835 As far as I can see we don't have consensus if this feature should 1)

[GitHub] wicket pull request #274: [WICKET-6546] HTML comments are removed from inlin...

2018-04-03 Thread solomax
GitHub user solomax opened a pull request: https://github.com/apache/wicket/pull/274 [WICKET-6546] HTML comments are removed from inline CSS You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/wicket

[GitHub] wicket pull request #273: WICKET-6321 Support Integrity and Crossorigin attr...

2018-04-03 Thread svenmeier
Github user svenmeier commented on a diff in the pull request: https://github.com/apache/wicket/pull/273#discussion_r178753738 --- Diff: wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptHeaderItem.java --- @@ -201,7 +202,13 @@ public static

[GitHub] wicket pull request #273: WICKET-6321 Support Integrity and Crossorigin attr...

2018-04-03 Thread svenmeier
Github user svenmeier commented on a diff in the pull request: https://github.com/apache/wicket/pull/273#discussion_r178752934 --- Diff: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java --- @@ -151,6 +152,30 @@ public static void

[GitHub] wicket issue #273: WICKET-6321 Support Integrity and Crossorigin attributes

2018-04-03 Thread svenmeier
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/273 @klopfdreh indeed, now is the time to reconsider the former decision :+1: ---