[GitHub] [wicket-site] dashorst commented on pull request #13: Adding a new Udemy course link to /learn page

2022-12-07 Thread GitBox
dashorst commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1340678225 Not a lawyer nor a non-profit status specialist, but linking to any and all training on Wicket is for the greater good IMO. 路 -- This is an automated message from the Apache Git

[GitHub] [wicket-site] bitstorm commented on pull request #13: Adding a new Udemy course link to /learn page

2022-11-10 Thread GitBox
bitstorm commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1310464665 @dashorst I like the idea! Do you think is against any ASF rule (I know it might be a one million dollars question :-) )? -- This is an automated message from the Apache Git Service.

[GitHub] [wicket-site] dashorst commented on pull request #13: Adding a new Udemy course link to /learn page

2022-11-10 Thread GitBox
dashorst commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1309945477 I think that we could promote both courses through the Apache Wicket twitter account, or provide a link to the trainings page on our web site with an announcement "Two new Wicket 9.x

[GitHub] [wicket-site] martin-g commented on pull request #13: Adding a new Udemy course link to /learn page

2022-11-09 Thread GitBox
martin-g commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1309295316 @bitstorm My answer was about the advertisement on Twitter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [wicket-site] bitstorm commented on pull request #13: Adding a new Udemy course link to /learn page

2022-11-09 Thread GitBox
bitstorm commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1308853093 > I don't think this would be appropriate for a paid course. Sorry! Actually, we were already listing 'Apache Wicket Kompakt', which is a paid course on Udemy as well. I don't think

[GitHub] [wicket-site] martin-g commented on pull request #13: Adding a new Udemy course link to /learn page

2022-11-09 Thread GitBox
martin-g commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1308833231 I don't think this would be appropriate for a paid course. Sorry! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [wicket-site] dmarko484 commented on pull request #13: Adding a new Udemy course link to /learn page

2022-11-09 Thread GitBox
dmarko484 commented on PR #13: URL: https://github.com/apache/wicket-site/pull/13#issuecomment-1308819577 Would be even possible to advertise a link on Apache Wicket twitter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [wicket-site] bitstorm merged pull request #13: Adding a new Udemy course link to /learn page

2022-11-09 Thread GitBox
bitstorm merged PR #13: URL: https://github.com/apache/wicket-site/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [wicket-site] dmarko484 opened a new pull request, #13: Adding a new Udemy course link to /learn page

2022-11-09 Thread GitBox
dmarko484 opened a new pull request, #13: URL: https://github.com/apache/wicket-site/pull/13 I have released a new Udemy course in english language named "Starting with Apache Wicket 9.x". I found an 'Online courses' section on your web site so please consider adding this link to existing

[GitHub] [wicket] rkurucz9 commented on pull request #471: WICKET-6888 ToggleableDataTable

2021-05-31 Thread GitBox
rkurucz9 commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-851608871 > I've taken a second look and actually your solution is very good. You clearly have understood how to work with components :). > > My major grieve is how the collection of

[GitHub] [wicket] svenmeier commented on pull request #471: WICKET-6888 ToggleableDataTable

2021-05-31 Thread GitBox
svenmeier commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-851249933 I've taken a second look and actually your solution is very good. You clearly have understood how to work with components :). My major grieve is how the collection of

[GitHub] [wicket] reiern70 commented on pull request #471: WICKET-6888 ToggleableDataTable

2021-05-29 Thread GitBox
reiern70 commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-850792867 > I've build a lot of these components over the years for different projects, and each had to be different according to the needs of the current project. > > There are a

[GitHub] [wicket] rkurucz9 commented on pull request #471: WICKET-6888 ToggleableDataTable

2021-05-29 Thread GitBox
rkurucz9 commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-850789089 It's all right from my side. I agree with your concept and arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] svenmeier commented on pull request #471: WICKET-6888 ToggleableDataTable

2021-05-29 Thread GitBox
svenmeier commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-850787702 I've build a lot of these components over the years for different projects, and each had to be different according to the needs of the current project. There are a whole

[GitHub] [wicket] rkurucz9 commented on a change in pull request #471: WICKET-6888 ToggleableDataTable

2021-05-29 Thread GitBox
rkurucz9 commented on a change in pull request #471: URL: https://github.com/apache/wicket/pull/471#discussion_r641899457 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/repeater/repeater.css ## @@ -72,3 +72,16 @@ col.yellow { col.brown {

[GitHub] [wicket] rkurucz9 commented on a change in pull request #471: WICKET-6888 ToggleableDataTable

2021-05-28 Thread GitBox
rkurucz9 commented on a change in pull request #471: URL: https://github.com/apache/wicket/pull/471#discussion_r641527364 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/toggle/ToggleColumn.java ## @@ -0,0 +1,91 @@

[GitHub] [wicket] martin-g commented on a change in pull request #471: WICKET-6888 ToggleableDataTable

2021-05-28 Thread GitBox
martin-g commented on a change in pull request #471: URL: https://github.com/apache/wicket/pull/471#discussion_r641483864 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/toggle/ToggleColumn.java ## @@ -0,0 +1,91 @@

[GitHub] [wicket] rkurucz9 commented on a change in pull request #471: WICKET-6888 ToggleableDataTable

2021-05-28 Thread GitBox
rkurucz9 commented on a change in pull request #471: URL: https://github.com/apache/wicket/pull/471#discussion_r641475471 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/toggle/ToggleColumn.java ## @@ -0,0 +1,91 @@

[GitHub] [wicket] martin-g commented on a change in pull request #471: WICKET-6888 ToggleableDataTable

2021-05-28 Thread GitBox
martin-g commented on a change in pull request #471: URL: https://github.com/apache/wicket/pull/471#discussion_r641454216 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/toggle/ToggleColumn.java ## @@ -0,0 +1,91 @@

[GitHub] [wicket] rkurucz9 opened a new pull request #471: WICKET-6888 ToggleableDataTable

2021-05-28 Thread GitBox
rkurucz9 opened a new pull request #471: URL: https://github.com/apache/wicket/pull/471 I would like to add a ToggleableDataTable to the codebase. Each row of it has an expansion content. If I have to fix my code, please share it with me. -- This is an automated message from the

[GitHub] [wicket] rkurucz9 commented on pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-23 Thread GitBox
rkurucz9 commented on pull request #470: URL: https://github.com/apache/wicket/pull/470#issuecomment-846513879 You're welcome. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [wicket] svenmeier commented on pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-22 Thread GitBox
svenmeier commented on pull request #470: URL: https://github.com/apache/wicket/pull/470#issuecomment-846465863 Many thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [wicket] rkurucz9 commented on pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-22 Thread GitBox
rkurucz9 commented on pull request #470: URL: https://github.com/apache/wicket/pull/470#issuecomment-846465125 My feature request was merged into the apache:wicket codebase. You can see it in the https://issues.apache.org/jira/browse/WICKET-6886 issue. -- This is an automated message

[GitHub] [wicket] rkurucz9 closed pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-22 Thread GitBox
rkurucz9 closed pull request #470: URL: https://github.com/apache/wicket/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [wicket] rkurucz9 commented on pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-22 Thread GitBox
rkurucz9 commented on pull request #470: URL: https://github.com/apache/wicket/pull/470#issuecomment-846451885 Please close my pull request, if you approved or rejected it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [wicket] rkurucz9 closed pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-22 Thread GitBox
rkurucz9 closed pull request #470: URL: https://github.com/apache/wicket/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [wicket] rkurucz9 opened a new pull request #470: WICKET-6886 LambdaChoiceRenderer with unit tests

2021-05-21 Thread GitBox
rkurucz9 opened a new pull request #470: URL: https://github.com/apache/wicket/pull/470 I would like to add a LambdaChoiceRenderer that is based on SerializableFunction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [wicket] martin-g commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
martin-g commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636072965 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/WebSocketPushUpdateProgressDemoPage.java ## @@ -0,0 +1,30 @@ +/* + *

[GitHub] [wicket] martin-g commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
martin-g commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636072596 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java ## @@ -50,6 +50,7 @@ public void init()

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636070852 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636070323 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/progress/ProgressUpdater.java ## @@ -0,0 +1,155 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636068987 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/WebSocketPushUpdateProgressDemoPage.java ## @@ -0,0 +1,30 @@ +/* + *

[GitHub] [wicket] reiern70 commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
reiern70 commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636068374 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java ## @@ -50,6 +50,7 @@ public void init()

[GitHub] [wicket] martin-g commented on a change in pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
martin-g commented on a change in pull request #469: URL: https://github.com/apache/wicket/pull/469#discussion_r636011467 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/HomePage.html ## @@ -29,6 +29,7 @@

[GitHub] [wicket] reiern70 opened a new pull request #469: create demo page showing how to use push in order to update a compone…

2021-05-20 Thread GitBox
reiern70 opened a new pull request #469: URL: https://github.com/apache/wicket/pull/469 create demo page showing how to use push in order to update a component via web-sockets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [wicket] martin-g commented on pull request #468: [WICKET-6885] Add scope = col to Columnheaders

2021-05-04 Thread GitBox
martin-g commented on pull request #468: URL: https://github.com/apache/wicket/pull/468#issuecomment-831998145 Thank you, @renoth ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [wicket] martin-g merged pull request #468: Add scope = col to Columnheaders

2021-05-04 Thread GitBox
martin-g merged pull request #468: URL: https://github.com/apache/wicket/pull/468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [wicket] renoth commented on pull request #468: Add scope = col to Columnheaders

2021-05-04 Thread GitBox
renoth commented on pull request #468: URL: https://github.com/apache/wicket/pull/468#issuecomment-831979032 Done https://issues.apache.org/jira/browse/WICKET-6885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [wicket] renoth opened a new pull request #468: Add scope = col to Columnheaders

2021-04-26 Thread GitBox
renoth opened a new pull request #468: URL: https://github.com/apache/wicket/pull/468 For accessibility purposes it is necessary to include a scope=col attribute in th column header elements, see https://www.w3schools.com/tags/att_th_scope.asp -- This is an automated message from

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612216948 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612213482 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 merged pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 merged pull request #467: URL: https://github.com/apache/wicket/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-818522077 @svenmeier and @martin-g Many thanks for reviews. Rebased and squashed commits. Merging now. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612205551 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.java ## @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612204956 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.java ## @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612204146 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612196582 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612196391 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612194043 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.java ## @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-13 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r612185917 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611791702 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -21,12 +21,21 @@ import java.util.List;

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817962998 > > **Note:** A just thought that a possible addition in case of multiple file uploads is a component with a table displaying all the selected files. WDYT? > > I don't

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611785063 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611783871 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817954505 @martin-g Many thanks for review and feedback. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611617845 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611606297 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/FileUploadPage$MultipleFileUploadsSamplePanel.html ## @@ -0,0 +1,37 @@

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611606118 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/EffectsPage.html ## @@ -1,5 +1,14 @@ http://wicket.apache.org;> +

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611600218 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.js ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611443395 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611442808 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611442833 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611441866 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611436687 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611435810 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611435382 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611431050 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611418517 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/EffectsPage.html ## @@ -1,5 +1,14 @@ http://wicket.apache.org;> +

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611417326 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/OnFilesSelectedBehavior.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r611363797 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -21,12 +21,21 @@ import java.util.List;

[GitHub] [wicket] martin-g commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-12 Thread GitBox
martin-g commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817529651 > **Note:** A just thought that a possible addition in case of multiple file uploads is a component with a table displaying all the selected files. WDYT? I don't think we

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-11 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817473232 rebased on top oof latest master + squashed commits. Waiting for ok to merge )or do more changes if asked) -- This is an automated message from the Apache Git Service. To

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-10 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817106343 once reviewed and approved I will rebase on top of master and squash commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-10 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817105914 My IDE suggest me to use let instead of var ![image](https://user-images.githubusercontent.com/462655/114264905-b0424800-99bb-11eb-98cf-1bf26afc2829.png) I was using

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-10 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-817105190 > @svenmeier and @martin-g > > Thanks for your comments: > > > IMHO OnFileSelectedBehavior deserves to be a top-level class. > > My rationale was the

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-816784650 The new section on examples looks like ![image](https://user-images.githubusercontent.com/462655/114208181-35c9e780-992b-11eb-8ca1-0a033f89b4ea.png) -- This is an

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-816784007 @svenmeier and @martin-g Thanks for your feedback and useful comments. I have reworked PR taking into account your comments. Can you please review again? --

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r610424557 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +59,146 @@ { private static

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r610423763 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +59,146 @@ { private static

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r610422618 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +59,146 @@ { private static

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-816488695 > IMHO OnFileSelectedBehavior deserves to be a top-level class. Maybe with its own JS resource, since the script to collect dynamicExtraParameters is getting very long now. >

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-816444615 **Note:** A just thought that a possible addition in case of multiple file uploads is a component with a table displaying all the selected files. WDYT? -- This is an

[GitHub] [wicket] reiern70 commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-09 Thread GitBox
reiern70 commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-816443335 @svenmeier and @martin-g Thanks for your comments: > IMHO OnFileSelectedBehavior deserves to be a top-level class. My rationale was the following: this class

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-08 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r610330790 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +59,146 @@ { private static

[GitHub] [wicket] svenmeier commented on pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-08 Thread GitBox
svenmeier commented on pull request #467: URL: https://github.com/apache/wicket/pull/467#issuecomment-816178510 IMHO OnFileSelectedBehavior deserves to be a top-level class. Maybe with its own JS resource, since the script to collect dynamicExtraParameters is getting very long now.

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-08 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r609988047 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +57,74 @@ { private static

[GitHub] [wicket] reiern70 commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-08 Thread GitBox
reiern70 commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r609600306 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +57,74 @@ { private static

[GitHub] [wicket] martin-g commented on a change in pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-08 Thread GitBox
martin-g commented on a change in pull request #467: URL: https://github.com/apache/wicket/pull/467#discussion_r609576034 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +57,74 @@ { private static

[GitHub] [wicket] reiern70 commented on pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on pull request #466: URL: https://github.com/apache/wicket/pull/466#issuecomment-815659097 Closing because I have created a new PR/branch with corrections and proper issue number -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [wicket] reiern70 closed pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 closed pull request #466: URL: https://github.com/apache/wicket/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [wicket] reiern70 commented on a change in pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on a change in pull request #466: URL: https://github.com/apache/wicket/pull/466#discussion_r609562898 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +56,73 @@ { private static

[GitHub] [wicket] reiern70 commented on a change in pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on a change in pull request #466: URL: https://github.com/apache/wicket/pull/466#discussion_r609562730 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +56,73 @@ { private static

[GitHub] [wicket] reiern70 commented on pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on pull request #466: URL: https://github.com/apache/wicket/pull/466#issuecomment-815658008 > Visit https://gitbox.apache.org/setup/ Many thanks! Now it seems to be working for me. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] reiern70 commented on pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on pull request #466: URL: https://github.com/apache/wicket/pull/466#issuecomment-815657559 > I think this could be extended to support `multiple` attribute of `` Yes. I will probably do that in another PR. -- This is an automated message from the Apache Git

[GitHub] [wicket] reiern70 opened a new pull request #467: [WICKET-6876] add an AJAX behavior to transfer client side file infor…

2021-04-08 Thread GitBox
reiern70 opened a new pull request #467: URL: https://github.com/apache/wicket/pull/467 [WICKET-6876] add an AJAX behavior to transfer client side file information to server side (when a file is selected for upload at client side). -- This is an automated message from the Apache Git

[GitHub] [wicket] martin-g commented on pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
martin-g commented on pull request #466: URL: https://github.com/apache/wicket/pull/466#issuecomment-815556388 Visit https://gitbox.apache.org/setup/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [wicket] reiern70 commented on pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on pull request #466: URL: https://github.com/apache/wicket/pull/466#issuecomment-81523 it seems I need to be added as member to apache in github so that I can commit directly to wicket instead of my fork. Can I do that directly or do I need to request that from

[GitHub] [wicket] reiern70 commented on a change in pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
reiern70 commented on a change in pull request #466: URL: https://github.com/apache/wicket/pull/466#discussion_r609425400 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +56,73 @@ { private static

[GitHub] [wicket] martin-g commented on a change in pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-08 Thread GitBox
martin-g commented on a change in pull request #466: URL: https://github.com/apache/wicket/pull/466#discussion_r609382572 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java ## @@ -47,6 +56,73 @@ { private static

[GitHub] [wicket] reiern70 commented on pull request #466: add an AJAX behavior to transfer client side file information to ser…

2021-04-07 Thread GitBox
reiern70 commented on pull request #466: URL: https://github.com/apache/wicket/pull/466#issuecomment-815427532 > Nice, I like it. Thanks. I will create an ISSUE for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   3   4   5   6   7   8   9   10   >