Hi Emond and Martijn,
Thanks for your great work. This is really tricky time-consuming
stuff, and I am glad that you follow this up all the way. I am not a
Wicket framework specialist and don't have as much inside knowledge as
I would like, so please excuse my ignorance in some cases.
On Wed, 21
Hi,
On Wed, Aug 21, 2013 at 10:10 PM, Emond Papegaaij emond.papega...@gmail.com
wrote:
Martijn and I discussed some more about this, and we've came to the
conclusion that we probably should not try to fix this in Wicket 6. The
cause of this issue (and several others) is a mismatch between
On Thursday 22 August 2013 10:43:57 Martin Grigorov wrote:
On Wed, Aug 21, 2013 at 10:10 PM, Emond Papegaaij
emond.papega...@gmail.com
wrote:
For Wicket 7, we might want to take a look at the PageParameters and
mounts
because they hold several caveats. The most important is that the
On Thu, Aug 22, 2013 at 11:08 AM, Emond Papegaaij
emond.papega...@topicus.nl wrote:
On Thursday 22 August 2013 10:43:57 Martin Grigorov wrote:
On Wed, Aug 21, 2013 at 10:10 PM, Emond Papegaaij
emond.papega...@gmail.com
wrote:
For Wicket 7, we might want to take a look at the
Hi,
On Thu, 22 Aug 2013 11:21:41 +0300, you wrote:
On Thu, Aug 22, 2013 at 11:08 AM, Emond Papegaaij
emond.papega...@topicus.nl wrote:
snip
The mismatch is in the fact that the PageParameters object is stored with
the page while it resembles the parameters the page was created with. If
a page
Am 22.08.13 11:25, schrieb Bernard:
Hi,
On Thu, 22 Aug 2013 11:21:41 +0300, you wrote:
On Thu, Aug 22, 2013 at 11:08 AM, Emond Papegaaij
emond.papega...@topicus.nl wrote:
snip
The mismatch is in the fact that the PageParameters object is stored with
the page while it resembles the
Hi,
I think that WebResponseExceptionsTest#expirePage must fail
because clicking the link should re-create the page because
TestExpirePage is bookmarkable.
I have made different changes to Wicket which I am not so sure about
but I am ready to share, and in order to get this test to pass, I had
Martijn and I discussed some more about this, and we've came to the
conclusion that we probably should not try to fix this in Wicket 6. The
cause of this issue (and several others) is a mismatch between Page,
PageParameters and statefulness that cannot be fixed without breaking the
API in several
On Monday 19 August 2013 17:32:45 Martin Grigorov wrote:
Hi Emond,
I think this change is OK.
Maybe we can improve it a bit by using
Application.get().getPageSettings().
getRecreateMountedPagesAfterExpiry() in the checks above ?
With the new check as you can see the produced urls contain
so what happens to the pages that are both bookmarkable and not?
public class EditCustomerPage {
public EditCustomerPage(PageParameters params) {
this(getEntity(params, customer));
}
public EditCustomerPage(IModelCustomer customer) {
...
}
}
what url will i get now when i say
Well, there is no urlFor method that takes a page, but if you use urlFor with
a RenderPageRequestHandler, the resulting url will be the same as this
method is not affected. Only the methods for RequestListenerInterface urls
are changed. For those, the url will be the bookmarkable version (with
Thanks very much Emond for the good work!
I found some behavior confusing at first but I agree with Emond -
correctness provides the best result for PageExpiredException recovery
and keeps the framework clean.
After Emond has improved PageExpiredException recovery, there is still
one other area
Hi Emond,
On Mon, Aug 19, 2013 at 12:10 PM, papega...@apache.org wrote:
WICKET-4997: render bookmarkable urls for bookmarkable pages (not
stateless)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e99bf147
Tree:
13 matches
Mail list logo
