Github user Fogetti closed the pull request at:
https://github.com/apache/wicket/pull/113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Fogetti commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-93148957
Thank you Martin! I tried it and your version is also working perfectly!
Thank you for the cooperation.
---
If your project is set up for it, you can reply to this
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-90512131
Hi @Fogetti ,
Do you want me to improve the PR myself and merge it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Fogetti commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r27885190
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
---
@@ -155,6 +168,57 @@
Github user Fogetti commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r27885257
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/message/AbortedMessage.java
---
@@ -0,0 +1,56
Github user Fogetti commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-90594677
Hi Martin!
Sorry for the late reply. I made the improvements. Would you be so kind to
take a look at the new set of changed files?
I made the changes
Github user Fogetti commented on the pull request:
https://github.com/apache/wicket/pull/113#issuecomment-84998527
Thank you for the comments Martin! I am a little busy in the beginning of
this week but I will make those changes and open a new pull request.
Also I was
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/112#issuecomment-83941519
I'm afraid the PR cannot be used.
Your formatting style caused complete rewrite of the touched files and the
meaningful changes are lost in the noise
---
If your
Github user Fogetti commented on the pull request:
https://github.com/apache/wicket/pull/112#issuecomment-83943161
No problem! I will reapply them without formatting then! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user Fogetti closed the pull request at:
https://github.com/apache/wicket/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Fogetti opened a pull request:
https://github.com/apache/wicket/pull/113
Cross-Site Websocket Hijacking Protection
This pull request is to replace my previous attempt:
https://github.com/apache/wicket/pull/112
Now I rebased my changes in my feature branch to
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26884179
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/event/WebSocketAbortedPayload.java
---
@@
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26884227
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/message/AbortedMessage.java
---
@@ -0,0
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26883895
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
---
@@ -155,6 +168,57 @@
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26884059
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketConnectionOriginFilter.java
---
@@
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/113#discussion_r26883969
--- Diff:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java
---
@@ -84,6
GitHub user Fogetti opened a pull request:
https://github.com/apache/wicket/pull/111
Cross-Site Websocket Hijacking Protection
This pull request is to replace my previous attempt:
https://github.com/apache/wicket/pull/110
Now I rebased my changes in my feature branch to
Github user Fogetti closed the pull request at:
https://github.com/apache/wicket/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Fogetti opened a pull request:
https://github.com/apache/wicket/pull/112
Cross-Site Websocket Hijacking Protection
This pull request is to replace my previous attempt:
https://github.com/apache/wicket/pull/110
Now I rebased my changes in my feature branch to
19 matches
Mail list logo
