Github user tkruse commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-71870777
I have no idea what you are talking about ("karma"?), but I can close
anyway if you say it has been merged.
---
If your project is set up for it, you can reply to this ema
Github user tkruse closed the pull request at:
https://github.com/apache/wicket/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-71863495
I believe this PR has been merged.
We don't have the karma to close it.
@tkruse Please close it. Thanks!
---
If your project is set up for it, you can reply to th
Github user tkruse commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-56439551
added commit fixing the test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user tkruse commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-56439282
Sorry, too tired. The error was intentional to show the previously
confusing message. To merge the change to the test needs to be reverted, or
fixed:
List subB
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-56439132
The tests fail with:
Caused by: java.lang.IllegalStateException: Could not resolve Bean Property
from component: [TextField [Component id = input21]]. (H
Github user tkruse commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-56438920
Also the actual fix might be overly complicated, just printing getModel()
might be enough additional information for developers to understand why a
property could not be re
Github user tkruse commented on the pull request:
https://github.com/apache/wicket/pull/77#issuecomment-56437784
Or the first commit can be dropped, not sure whether it covers something of
importance, it is just an example.
---
If your project is set up for it, you can reply to this
GitHub user tkruse opened a pull request:
https://github.com/apache/wicket/pull/77
Wicket 5692: Better error message when property cannot be resolved
See https://issues.apache.org/jira/browse/WICKET-5692
commits can be squashed one review passed.
You can merge this pull req