Github user Jezza closed the pull request at:
https://github.com/apache/wicket/pull/268
---
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r174700276
--- Diff:
wicket-util/src/main/java/org/apache/wicket/util/collections/ArrayListStack.java
---
@@ -1,139 +0,0 @@
-/*
--- End diff --
I'd p
Github user Jezza commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172126310
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -226,9 +227,9 @@ private DequeueTagAction canDequeueTag(ComponentTag
open)
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172125436
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -226,9 +227,9 @@ private DequeueTagAction canDequeueTag(ComponentTag
open
Github user Jezza commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172123895
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -226,9 +227,9 @@ private DequeueTagAction canDequeueTag(ComponentTag
open)
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172101026
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -286,9 +287,8 @@ public MarkupContainer popContainer()
*/
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172101091
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/parser/TagStack.java ---
@@ -166,12 +167,13 @@ public ComponentTag getNotClosedTag()
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172100972
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -226,9 +227,9 @@ private DequeueTagAction canDequeueTag(ComponentTag
open
GitHub user Jezza opened a pull request:
https://github.com/apache/wicket/pull/268
Remove ArrayListStack in favour of ArrayDeque
I found it as I was working on #223, thought I might as well take a break
from it, and fix this small thing.
You can merge this pull request into a Git r
