Hi,
actually we can just change it to IModel?, since RefreshingView does
not do anything with its model: there's no getter either and in Wicket
no subclass uses its model.
Regards
Sven
On 22.02.2015 13:43, Tobias Soloschenko wrote:
Hi,
since the RefreshingView is iterating over each
Having Iterable there makes sense only if it is used by Wicket as Tobias
suggested.
If we are going to introduce it then we have to make it clear how exactly
the items from the passed Iterable are merged with the manually added ones.
Martin Grigorov
Wicket Training and Consulting
+1 for me to revert the change as Marting suggested. At the moment there
is no reason to put such a constraint on model.
Having Iterable there makes sense only if it is used by Wicket as Tobias
suggested.
If we are going to introduce it then we have to make it clear how exactly
the items from
Hi,
then I would suggest that the RefreshingView is going to make use of its
model if no items has been added - what do you think?
On the other hand - if someone uses the internal model to put in some
additional information which are going to be retrieved in populateItem
then it would brake
Hi,
since the RefreshingView is iterating over each element and Iterable is
more flexible, I would prefer the new option. As far as I can see this
would change the signature but not let the users change their code,
because Collection also implements the Interface Iterable. The new
signature
Wicket 6.x:
https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L81
Wicket 7.x:
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L82
Since no
I'm working through our internal framework upgrading Wicket to 7. This
is one place I think the Wicket API can improve further:
Currently the constructor of RefreshingView is defined as:
public RefreshingView(String id, IModel? extends Collection?
extends T model)
Probably the model can be
On Sun, Feb 22, 2015 at 2:22 PM, Martin Grigorov mgrigo...@apache.org wrote:
Wicket 6.x:
https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/markup/repeater/RefreshingView.java#L81
Wicket 7.x:
Hi all,
apparently the change of RefreshingView slipped through with my changes
for WICKET-5350.
I reverted the constructor argument to IModel?.
Have fun
Sven
On 22.02.2015 14:47, Andrea Del Bene wrote:
+1 for me to revert the change as Marting suggested. At the moment
there is no reason
