Nice job Sven! I will try to review your changes ASAP. Thnak you.
On Sat, Jul 7, 2018 at 10:11 PM, Sven Meier (JIRA) <j...@apache.org> wrote: > > [ https://issues.apache.org/jira/browse/WICKET-6563?page= > com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Sven Meier updated WICKET-6563: > ------------------------------- > Description: > IPageManager, IPageStore and IDataStore are riddled with complicated and > error-prone code aiming to do one simple thing: keeping pages around. > > There are multiple problems with the current implementation: > * PageStoreManger does too much > ** it handles request and session storage > ** it contains workarounds for DiskDataStore, when the sessionId changes > * IPageStore/AbstractPageStore > ** has no access to IPageManagerContext > ** juggles with byte[], serialization and conversion > * IDataStore introduces an unncecessary third layer into the API > > Additional or specialized stores are difficult to implement. > > We should rework that. > > was: > IPageManager, IPageStore and IDataStore are riddled with complicated and > error-prone code aiming to do one simple thing: keeping pages around. > > We should rework that. > > > > Rework page and data storage > > ---------------------------- > > > > Key: WICKET-6563 > > URL: https://issues.apache.org/jira/browse/WICKET-6563 > > Project: Wicket > > Issue Type: Improvement > > Components: wicket > > Affects Versions: 9.0.0 > > Reporter: Sven Meier > > Assignee: Sven Meier > > Priority: Minor > > > > IPageManager, IPageStore and IDataStore are riddled with complicated and > error-prone code aiming to do one simple thing: keeping pages around. > > There are multiple problems with the current implementation: > > * PageStoreManger does too much > > ** it handles request and session storage > > ** it contains workarounds for DiskDataStore, when the sessionId changes > > * IPageStore/AbstractPageStore > > ** has no access to IPageManagerContext > > ** juggles with byte[], serialization and conversion > > * IDataStore introduces an unncecessary third layer into the API > > Additional or specialized stores are difficult to implement. > > We should rework that. > > > > -- > This message was sent by Atlassian JIRA > (v7.6.3#76005) > -- Andrea Del Bene. Apache Wicket committer.
