Re: CssUrlReplacer improvement - base64 content

2015-02-21 Thread Tobias Soloschenko
Hi, I added two pull request to add this functionality to the CssUrlReplacer in Wicket 6.x / 7.x: https://github.com/apache/wicket/pull/97 https://github.com/apache/wicket/pull/96 kind regards Tobias Am 16.02.15 um 15:31 schrieb Martin Grigorov: I like the idea! Martin Grigorov Wicket Tra

Re: CssUrlReplacer improvement - base64 content

2015-02-16 Thread Tobias Soloschenko
Okeee :-) - I'm going to make a pull request the "day after tomorrow" :-D kind regards Tobias Am 16.02.15 um 15:31 schrieb Martin Grigorov: I like the idea! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Feb 16, 2015 at 1:52 PM, Tobias Soloschenko < tob

Re: CssUrlReplacer improvement - base64 content

2015-02-16 Thread Martin Grigorov
I like the idea! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Feb 16, 2015 at 1:52 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > And its done - here is the while loop inside the CssUrlReplacer - I'm > going to open a pull request aft

Re: CssUrlReplacer improvement - base64 content

2015-02-16 Thread Tobias Soloschenko
And its done - here is the while loop inside the CssUrlReplacer - I'm going to open a pull request after the fixes are merged: while (matcher.find()) { Url imageCandidateUrl = Url.parse(matcher.group(1)); CharSequence processedUrl; if (imageCan

CssUrlReplacer improvement - base64 content

2015-02-16 Thread Tobias Soloschenko
Hi all, as you can see in the commit history - you can replace image urls within CSS files loaded with a CssResourceReference by their corresponding wicket url representation, so that images are resolved from within the class path. (currently with 7.0.0-SNAPSHOT) I'm thinking of improve the