BTW AFIAK trivial stuff like a javadoc fix is always permitted through
a pull request.
As long as the contribution/patch is a couple of trivial code lines,
you can include it.
It becomes different when someone includes a package.html and complete
javadoc sections for classes and methods. That is
I've asked the legal folks:
http://markmail.org/message/3gvsg4qgc2khve27
Martijn
On Tue, Apr 3, 2012 at 9:16 AM, Martin Grigorov wrote:
> Martijn,
>
> Can you confirm that by making a Pull Request at
> https://github.com/apache/wicket the contributor is donating his code
> according to ASF IP r
Martijn,
Can you confirm that by making a Pull Request at
https://github.com/apache/wicket the contributor is donating his code
according to ASF IP rules ? I.e. there is no reason for explicit ICLA
or checking radio button "This code is for ASF".
On Tue, Apr 3, 2012 at 8:28 AM, Martin Grigorov w
For the record: https://issues.apache.org/jira/browse/INFRA-4635
On Tue, Apr 3, 2012 at 1:20 AM, Igor Vaynberg wrote:
> also, a quick way to apply a pull request is to format it as a patch
> and run it through git's mailbox support:
>
> curl https://github.com/apache/wicket/pull/4.patch | git am
also, a quick way to apply a pull request is to format it as a patch
and run it through git's mailbox support:
curl https://github.com/apache/wicket/pull/4.patch | git am -s
(notice .patch appending to pull request url)
-igor
On Mon, Apr 2, 2012 at 2:56 PM, Jeremy Thomerson
wrote:
> After I saw
After I saw the pull request below [1] I realized that our GitHub mirror
wasn't ever switched to pull from our Git@ASF repo. I requested that it be
changed. Jukka apparently updated it because it is now in sync.
This means future pull requests should automatically close themselves once
the commi
