ListChoice weird way to set default max rows

2012-02-23 Thread Martin Grigorov
Hi, ListChoice component uses a strange way to set/get the default max rows via protected static methods. What is the design choice here ? This default value is used if the user didn't provide the value explicitly as a constructor parameter. By using 'protected' method to set a new value the

Re: ListChoice weird way to set default max rows

2012-02-23 Thread Igor Vaynberg
imho the entire component can be removed. all that code just to set the size which can easily be done with an anon subclass. the size attribute is usually static anyways and comes from markup... -igor On Thu, Feb 23, 2012 at 7:14 AM, Martin Grigorov mgrigo...@apache.org wrote: Hi, ListChoice