Hi Maxim,
thanks for your feedback.
Sven
On 27.03.20 05:06, Maxim Solodovnik wrote:
Still no issues reported after 2 days of work at our demo server
Seems this solution can be released :)
On Wed, 25 Mar 2020 at 18:24, Maxim Solodovnik wrote:
first results: everything seems to work as
Still no issues reported after 2 days of work at our demo server
Seems this solution can be released :)
On Wed, 25 Mar 2020 at 18:24, Maxim Solodovnik wrote:
> first results: everything seems to work as expected
> will continue testing
>
> On Wed, 25 Mar 2020 at 01:12, Sven Meier wrote:
>
>>
first results: everything seems to work as expected
will continue testing
On Wed, 25 Mar 2020 at 01:12, Sven Meier wrote:
> Hi,
>
> ok, let's give it a try!
>
> All hidden elements (hidden form fields or placeholders) are hidden via
> "hidden" attribute now.
>
> Have fun
> Sven
>
>
> On
Hi,
ok, let's give it a try!
All hidden elements (hidden form fields or placeholders) are hidden via
"hidden" attribute now.
Have fun
Sven
On 24.03.20 08:15, Emond Papegaaij wrote:
Hi all,
If you want to go ahead and remove the core CSS, please make sure all
components keep working. For
Hi all,
If you want to go ahead and remove the core CSS, please make sure all
components keep working. For example, in wicket extensions I had to
use the 'wicket--hidden' class in progressbar.js. Just do a grep on
'wicket--hidden' and double-check those components in the examples.
Best regards,
Let's try to remove this CSS and check :)
I'm currently using latest wicket SNAPSHOT at master so most probably
will provide some feedback :)
On Fri, 20 Mar 2020 at 19:51, Martin Grigorov wrote:
>
> In this case I am fine to go with 'hidden'.
> We can introduce wicket-core.css later if needed.
>
In this case I am fine to go with 'hidden'.
We can introduce wicket-core.css later if needed.
On Fri, Mar 20, 2020 at 1:44 PM Sven Meier wrote:
> Hi Martin,
>
> these stylings?
>
> width: 0px;
> height: 0px;
> position: absolute;
> left: -100px;
> top: -100px;
>
Hi Sven,
What about wicket--hidden-fields ?
We still need wicket-core.css for it.
Martin
On Wed, Mar 18, 2020 at 11:25 PM Sven Meier wrote:
> Hi all,
>
> I've built an example to better demonstrate my argument:
>
> a) "hidden" tags work fine out-of-the-box :)
>
>
Hi all,
I've built an example to better demonstrate my argument:
a) "hidden" tags work fine out-of-the-box :)
https://jsfiddle.net/p8s7Lrk2/1/
b) changing display of tags changes "hidden" tags too :(
https://jsfiddle.net/p8s7Lrk2/2/
c) and a simple fix for "hidden" tags - no
Hello Sven,
I always thought:having override like this will require re-testing all
3rd-party components manually
(I don't have that much time)
So I'm using library as-is and override as minimum as possible :)
On Tue, 17 Mar 2020 at 18:56, Sven Meier wrote:
>
> Hi Maxim,
>
> what is difficult
Hi Martin,
sorry, I don't get it.
You can equally well just style it via "hidden" attribute:
*[hidden] {
display: none;
}
And no, this does *not* need to be provided by Wicket:
Whoever decides to flex *all* divs (you or your web designer), he will
be
Hi Maxim,
what is difficult about that?
Actually it is recommended to have it in your normalize.css (formerly
reset.css).
Here one without !important:
https://github.com/necolas/normalize.css/blob/master/normalize.css
Sven
On 13.03.20 15:21, Maxim Solodovnik wrote:
Additional note:
Oh dear - why devs don’t stop using !important - it is so hard to customize it
by use more specific selectors... anyway - as long as the css are clear and
simple to support functions of the backend they are ok. Users can even
customize them. display: none to hide something is simple and clear
Additional note:
Bootstrap has following CSS
[hidden] {
display: none !important;
}
which makes life much more diffiicult ...
On Fri, 13 Mar 2020 at 21:17, Martin Grigorov wrote:
>
> On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov
> wrote:
>
> > Hi Sven,
> >
> >
> >
> >
> >
On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov
wrote:
> Hi Sven,
>
>
>
>
>
> /* rule from the application that should be used when the
> element is visible */
> div {
> display: flex;
> margin-bottom: 200px;
> }
Hi Sven,
/* rule from the application that should be used when the
element is visible */
div {
display: flex;
margin-bottom: 200px;
}
/* Rule coming from wicket-core.css */
.wicket--hidden
Hi all,
I've looked at all responses and most arguments in favor of a "core.css"
boil down to:
> `hidden` attribute doesn't work (even `display: flex` breaks it)
> Using the hidden attribute puts the responsibility with the developer
> where this should be on the framework. The hidden
Hi Andrew,
I thought of this solution as well and it will work. The major
advantage is that the styling is only added when it is actually used.
But it requires significantly more work to build and is a lot more
complex than the current solution. For this, we need some place to
accumulate element
Just as a brainstorm. Not sure if it's a good idea.
Wicket potentially can add nounced style to the document with hidden
elements hidden by id.
Imagine generated HTML has components like these
#ida and #id9 must be hidden, so in the page header we add something like
this
On Thu, Feb 27, 2020 at 11:56 AM Ernesto Reinaldo Barreiro
wrote:
> On Thu, Feb 27, 2020 at 12:33 PM Andrea Del Bene
> > In which way sub-frameworks should be affected? I mean, as far as I
> > understand it, if we disable CSP blocking configuration everything should
> > work "the old way", and
Hi,
On Thu, Feb 27, 2020 at 12:33 PM Andrea Del Bene
wrote:
> On Wed, Feb 26, 2020 at 10:26 AM Ernesto Reinaldo Barreiro <
> reier...@gmail.com> wrote:
>
> > Hi,
> >
> > Right now I have no enough knowledge to vote in this feature. One thing I
> > didn't like, and I already mentioned it before,
On Wed, Feb 26, 2020 at 10:26 AM Ernesto Reinaldo Barreiro <
reier...@gmail.com> wrote:
> Hi,
>
> Right now I have no enough knowledge to vote in this feature. One thing I
> didn't like, and I already mentioned it before, is some of us were waiting
> for 9.x to be released some time ago (at least
Hi,
as you know I am a big fan of HTML5 and was experimenting a lot with it, I
would also vote to stay with a core css and clean it up, because of a better
backward compatibility. flex is used a LOT in modern layouts and would break
the other option.
kind regards
Tobias
> Am 26.02.2020 um
On Wed, Feb 26, 2020 at 11:15 AM Emond Papegaaij
wrote:
> > On Tue, Feb 25, 2020 at 10:54 PM Sven Meier wrote:
> > > - it's a kitchen-sink for left-over styles (see .wicket--color-red)
> >
> > I agree that for this one Wicket can just add the CSS class (e.g.
> > wicket-feedback-indicator) on
On Tue, Feb 25, 2020 at 9:54 PM Sven Meier wrote:
> [] leave as is with .wicket--hidden & wicket-core.css
>
> [] use HTML5 "hidden" attribute instead
>
While it is true that Wicket hasn't depended on a CSS file for its own use,
it has been dependent on its own styles, spread out through our
On Wed, Feb 26, 2020 at 10:53 AM Martin Grigorov wrote:
> I am also not big fan of CSP but users ask for it and I see no other way
> but to move all inline styles in such .css resource
IMHO CSP is one of the changes to the web application ecosystem that
Wicket will need an answer on to stay
Hi Sven,
On Tue, Feb 25, 2020 at 10:54 PM Sven Meier wrote:
> Hi all,
>
> we have a disagreement on how to style hidden elements in Wicket 9.x.
>
> Due to the new CSP support we can no longer use inline styling to hide
> elements.
> WICKET-6725 introduces new CSS classes and a file
Hi,
Right now I have no enough knowledge to vote in this feature. One thing I
didn't like, and I already mentioned it before, is some of us were waiting
for 9.x to be released some time ago (at least a few months ago I was
preparing some branch of our application and ported it to 9.x, after
[+] leave as is with .wicket--hidden & wicket-core.css
IMO we should sheep the version which will work as expected out-of-the-box
According to my tests `hidden` attribute doesn't work (even `display:
flex` breaks it)
On Wed, 26 Feb 2020 at 15:22, Andrea Del Bene wrote:
>
> +1 to vote. I find
+1 to vote. I find your concerns legitimate
On Tue, Feb 25, 2020 at 9:54 PM Sven Meier wrote:
> Hi all,
>
> we have a disagreement on how to style hidden elements in Wicket 9.x.
>
> Due to the new CSP support we can no longer use inline styling to hide
> elements.
> WICKET-6725 introduces new
30 matches
Mail list logo
