Re: final Page.onInitialize()

2011-02-10 Thread Clint Checketts
Hans, I'm agreeing. I'm just saying that if you start treating the onIniliaze() as the place to create your components then you are stuck with the same problem as before: class MyPage { MyPage() { } * onInitialize() < Using onInitialize in the page doesn't give you anything, so that i

Re: final Page.onInitialize()

2011-02-10 Thread Hans Lesmeister 2
Hi, Clint Checketts wrote: > > I don't believe the goal of onInitiallize is to move all component > creation > from the constructor to onInitialize, since if you are adding the > component > to the parent in the onInitialize method then you are back to the problem > of > not being able to call

Re: final Page.onInitialize()

2011-02-03 Thread Daniel Soneira
Hi, That's exactly how I am using onInitialize on Pages / Components - to call overridable factory methods outside of the constructor. So for me: +1 (re-)make onInitialize non final Regards, Daniel On 02.02.2011 11:11, Hans Lesmeister 2 wrote: Hi, After onInitialize was introduced in 1.4.1

Re: final Page.onInitialize()

2011-02-02 Thread Pedro Santos
I think onInitialize is playing the role of the Component#addNotify method from awt framework. It is an useful callback to not root components, were they can adjust their sate based on the existing component tree. And if we rename it to onAddedToComponentTree or addNotify as in the awt framework? A

Re: final Page.onInitialize()

2011-02-02 Thread Clint Checketts
I don't believe the goal of onInitiallize is to move all component creation from the constructor to onInitialize, since if you are adding the component to the parent in the onInitialize method then you are back to the problem of not being able to call getPage() in your components. I say keep const

Re: final Page.onInitialize()

2011-02-02 Thread Hans Lesmeister 2
Hi, After onInitialize was introduced in 1.4.12 we have done a lot of refactoring in a lot of pages to get component-creation out of the constructors and into onInitialize. Especially calling overridable factory methods from a constructor is gone now which we and PMD really appreciate. Carl-Er

Re: final Page.onInitialize()

2011-02-01 Thread Carl-Eric Menzel
On Tue, 1 Feb 2011 08:52:03 -0800 Igor Vaynberg wrote: > apparently some people also use it as a post-construct callback, which > sort of makes sense. for example, to call overridable factory methods, > which you cannot do from the constructor. > > the solution is to delay all calls to oninitial

Re: final Page.onInitialize()

2011-02-01 Thread Igor Vaynberg
apparently some people also use it as a post-construct callback, which sort of makes sense. for example, to call overridable factory methods, which you cannot do from the constructor. the solution is to delay all calls to oninitialize until just before the very first call to onconfigure. i have mi

Re: final Page.onInitialize()

2011-02-01 Thread Pedro Santos
onInitialize is only there to provide an place on the component code where you can rely on a path to the page from the component. It is useless inside an page. On Tue, Feb 1, 2011 at 9:25 AM, tetsuo wrote: > Overriding onInitialize() on Pages certainly may cause some problems, > if you mix addin