Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Sven Meier
I agree, it would be better placed in wicket-authroles. Sven On 10/25/2012 07:19 PM, Jesse Long wrote: Hi all, IAuthenticationStrategy is pretty much only used by wicket-authroles. This was enough cause to get Session#authenticate kicked out. Also, the interface makes some assumptions

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Martin Grigorov
Why not to improve it ? Instead of using username/password we can improve it to use Token, with UsernamePasswordToken as default impl for DefaultAuthenticationStrategy (UsernamePasswordAuthenticationStrategy). Moving it to wicket-auth-roles will lead to explanations like: To be able to do simple

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Ron Smits
I would definitly not like it when IAuthStrategy is removed. Most companies where we use Wicket have strange/homebrewn/or plain oldfashioned strange authentication systems. Having IAuthStrategy available makes it so much easier to abstract it away. Ron Smits I Haven't Lost My Mind - It's Backed

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Sven Meier
Why not to improve it ? Sure, we can improve it. But for now it's just an ugly interface (see the #load() method) which is used by SignInPanel in wicket-auth-roles. -auth-roles which is actually an example How does keeping IAuthenticationStrategy in core help wicket-auth-roles being more

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Martin Grigorov
On Fri, Oct 26, 2012 at 11:20 AM, Sven Meier s...@meiers.net wrote: Why not to improve it ? Sure, we can improve it. But for now it's just an ugly interface (see the #load() method) which is used by SignInPanel in wicket-auth-roles. -auth-roles which is actually an example How does

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Sven Meier
I don't want to promote wicket-auth-roles to be something more than example but moving IAuthenticationStrategy there will help for this. Ok, now I understand. Perhaps time to move wicket-auth-roles to wicket-examples then :P. For me IAuthenticationStrategy is an example only, so it fits

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Martin Grigorov
On Fri, Oct 26, 2012 at 11:34 AM, Sven Meier s...@meiers.net wrote: I don't want to promote wicket-auth-roles to be something more than example but moving IAuthenticationStrategy there will help for this. Ok, now I understand. Perhaps time to move wicket-auth-roles to wicket-examples then :P.

Re: Remove IAuthenticationStrategy in 7

2012-10-26 Thread Burton, Tom F (DOR)
Burton Sent from my HTC - Reply message - From: Jesse Long j...@unknown.za.net To: dev@wicket.apache.org dev@wicket.apache.org Subject: Remove IAuthenticationStrategy in 7 Date: Thu, Oct 25, 2012 11:37 am Hi Tom, Igor covers IAuthorizationStrategy (very nicely, I might add) in his

Remove IAuthenticationStrategy in 7

2012-10-25 Thread Jesse Long
Hi all, IAuthenticationStrategy is pretty much only used by wicket-authroles. This was enough cause to get Session#authenticate kicked out. Also, the interface makes some assumptions about username and password being the only possible authentication tokens. Maybe it should be moved to

RE: Remove IAuthenticationStrategy in 7

2012-10-25 Thread Burton, Tom F (DOR)
implemented any page component level permissions yet.) Just my $0.02, Tom Burton -Original Message- From: Jesse Long [mailto:j...@unknown.za.net] Sent: Thursday, October 25, 2012 9:19 AM To: dev@wicket.apache.org Subject: Remove IAuthenticationStrategy in 7 Hi all, IAuthenticationStrategy

Re: Remove IAuthenticationStrategy in 7

2012-10-25 Thread Jesse Long
Burton -Original Message- From: Jesse Long [mailto:j...@unknown.za.net] Sent: Thursday, October 25, 2012 9:19 AM To: dev@wicket.apache.org Subject: Remove IAuthenticationStrategy in 7 Hi all, IAuthenticationStrategy is pretty much only used by wicket-authroles. This was enough cause to get