Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-05-03 Thread Thomas Heigl
not clear and good here. Sorry :( > > - Ursprüngliche Mail - > > Von: "Korbinian Bachl" > > An: "dev" > > Gesendet: Freitag, 1. April 2022 12:27:19 > > Betreff: Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea > why I get this?

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-04-01 Thread Korbinian Bachl
Bachl" > An: "dev" > Gesendet: Freitag, 1. April 2022 12:27:19 > Betreff: Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I > get this? > Hi Thomas, > > it is indeed WICKET-6963. The reason from my understanding is the way we > "tr

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-04-01 Thread Korbinian Bachl
me fields to final static and only production errors let me know :X Do you know when a 9.9.1 will be out? Best, KB - Ursprüngliche Mail - > Von: "Thomas Heigl" > An: "dev" > Gesendet: Donnerstag, 31. März 2022 11:35:45 > Betreff: Re: wicket 9.9.0 - MarkupE

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
It's just a single commit. I have reverted it for both 9.x and master. Best, Thomas On Thu, Mar 31, 2022 at 11:06 AM Andrea Del Bene wrote: > On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl wrote: > > > Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code > > related to this

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Andrea Del Bene
On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl wrote: > Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code > related to this flag is quite convoluted and full of TODOs and WHY > comments. I think I will have to do another take on this and replace the > field with a parameter,

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Korbinian Bachl
det: Donnerstag, 31. März 2022 10:18:12 > Betreff: Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I > get this? > Although the JavaDoc states that this should be possible: > > // reset for each render in case the strategy is re-used > noMoreWicketHeadTagsAllowed

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code related to this flag is quite convoluted and full of TODOs and WHY comments. I think I will have to do another take on this and replace the field with a parameter, but this will take some time. I would suggest we revert

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
Although the JavaDoc states that this should be possible: // reset for each render in case the strategy is re-used noMoreWicketHeadTagsAllowed = false; It would be great if we had a failing test-case for this. In my production environment with about 5000 panels, there are none of these issues.

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Maxim Solodovnik
It seems I should cancel wicketstuff build :(( On Thu, 31 Mar 2022 at 15:14, Thomas Heigl wrote: > I think we will have to revert WICKET-6963. > > I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed > in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton >

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
I think we will have to revert WICKET-6963. I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton strategy doesn't work. Thomas On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl wrote: > This is probably

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl
This is probably caused by my change in https://issues.apache.org/jira/browse/WICKET-6963 I have been using this code in production for a couple of weeks now without issues, but there seem to be cases where the singleton strategy doesn't work. Can you reproduce this issue in a test-case? Thomas

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Korbinian Bachl
lodovnik" > An: "dev" > Gesendet: Donnerstag, 31. März 2022 10:06:34 > Betreff: Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I > get this? > " tags are only allowed before , , > etc. tag" > sounds reasonable :) > > On

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Martin Grigorov
Hi, The changelog is quite short: CHANGELOG for 9.9.0: ** Bug * [WICKET-6957] - Declare JSPM 'uses' for IInitializer * [WICKET-6965] - Memory leak in WicketEndpoint ** Improvement * [WICKET-6960] - Reduce allocations when encoding ComponentInfo * [WICKET-6963] - Use

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Maxim Solodovnik
" tags are only allowed before , , etc. tag" sounds reasonable :) On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl < korbinian.ba...@whiskyworld.de> wrote: > Hi, > > I deployed our app on 9.9.0 this morning and after initializing a crawl of > the page I ended up getting a low quote of 503s. > >

wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Korbinian Bachl
Hi, I deployed our app on 9.9.0 this morning and after initializing a crawl of the page I ended up getting a low quote of 503s. The 503s are always the same: 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper] Unexpected error occurred