[GitHub] [wicket] martin-g commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
martin-g commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476773719 :+1: if everything still works ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476751902 I would say `cglib-nodep` is better option since we have `asm` as separate dependency ... @martin-g, @svenmeier, @bitstorm WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476750648 There is a cglib-nodep that wicket-ioc could depend on, and then inherit the asm dependency (which is used by other wicket modules). Q: This seems to be a driver's choice option here-- is there a strong preference to stay tightly coupled to cglib's transitive dependency on asm, or would the cglib-nodep approach be useful? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748823 @mattrpav PR with the link to JIRA is perfectly fine :) You did everything right :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] mattrpav edited a comment on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
mattrpav edited a comment on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748019 @solomax re the wicket-8.x patch-- what is the preferred workflow for patches? Do you merge PR's from here or other? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748019 @solomax what is the preferred workflow for patches? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476747443 @solomax apologies for the build warn. I created this PR to see if there was some CI/CD tied to Wicket's PR's. This is a simple fix to exclude asm requested by cglib. I need to upgrade my local JDK and will re-test. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476743542 @mattrpav I got build error with this change: ``` WARNING] Dependency convergence error for org.ow2.asm:asm:7.0 paths to dependency are: +-org.apache.wicket:wicket-ioc:9.0.0-SNAPSHOT +-cglib:cglib:3.2.10 +-org.ow2.asm:asm:7.0 and +-org.apache.wicket:wicket-ioc:9.0.0-SNAPSHOT +-org.ow2.asm:asm-util:7.1 +-org.ow2.asm:asm:7.1 and +-org.apache.wicket:wicket-ioc:9.0.0-SNAPSHOT +-org.ow2.asm:asm-util:7.1 +-org.ow2.asm:asm-tree:7.1 +-org.ow2.asm:asm:7.1 icket-ioc: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed ``` I'm afraid some additional changes are required BTW can you close #350, I'll cherry-pick this one into wicket-8.x This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] mattrpav opened a new pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x
mattrpav opened a new pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x URL: https://github.com/apache/wicket/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] mattrpav opened a new pull request #349: [WICKET-6647] Upgrade asm to 7.1 in master
mattrpav opened a new pull request #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
